From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/3] drm: rcar-du: Reject planes located fully off-screen Date: Thu, 28 Sep 2017 12:16:48 +0300 Message-ID: <37669611.vtIjLgZvls@avalon> References: <20170815230338.14913-1-laurent.pinchart+renesas@ideasonboard.com> <20170928071034.ovxweoxdp3sb3ij2@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20170928071034.ovxweoxdp3sb3ij2@phenom.ffwll.local> Sender: linux-renesas-soc-owner@vger.kernel.org To: Daniel Vetter Cc: kieran.bingham@ideasonboard.com, Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Daniel, On Thursday, 28 September 2017 10:10:34 EEST Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 07:58:42PM +0100, Kieran Bingham wrote: > > Hi Laurent, > > > > Thankyou for the patch, > > > > This looks good, and passes the tests. > > > > On 16/08/17 00:03, Laurent Pinchart wrote: > > > There is no point in accepting fully off-screen planes as they won't be > > > displayed. Reject them in the atomic check. > > > > > > Signed-off-by: Laurent Pinchart > > > > > > > Reviewed-by: Kieran Bingham > > Just a note, this is different from what i915 does. Not sure you want to > intentionally be incompatible with i915 and hence defacto make this part > of atomic undefined (or break some apps, depending upon how this pans > out). I think X loves to put the cursor offscreen at least. > > I think we even have igts to test this properly. If you update the documentation I'll submit a v2 that allows fully off-screen planes :-) -- Regards, Laurent Pinchart