[PATCH v2 0/1] Mark xe driver as BROKEN if kernel page size is not 4kB

[PATCH v2 0/1] Mark xe driver as BROKEN if kernel page size is not 4kB

[Simon Richter]

Hi,

until either of

 - https://patchwork.freedesktop.org/series/150230/

or the (same but rebased)

 - https://patchwork.freedesktop.org/series/151983/

goes in, the xe module will Oops on insmod when kernel page size is not 4kB.
This disables the module for the time being, and should be reverted for fixed
versions.

This should probably also be added to the stable kernel series which will
likely not receive the fix.

Simon Richter (1):
  Mark xe driver as BROKEN if kernel page size is not 4kB

 drivers/gpu/drm/xe/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.47.2

[PATCH v2 1/1] Mark xe driver as BROKEN if kernel page size is not 4kB

[Simon Richter]

This driver, for the time being, assumes that the kernel page size is 4kB,
so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with 64kB
pages.

Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/xe/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 2bb2bc052120..7c9f1de7b35f 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_XE
 	tristate "Intel Xe2 Graphics"
-	depends on DRM && PCI
+	depends on DRM && PCI && (PAGE_SIZE_4KB || BROKEN)
 	depends on KUNIT || !KUNIT
 	depends on INTEL_VSEC || !INTEL_VSEC
 	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)
-- 
2.47.2

Re: [PATCH v2 1/1] Mark xe driver as BROKEN if kernel page size is not 4kB

[Thomas Hellström]

On Sun, 2025-07-27 at 16:04 +0900, Simon Richter wrote:
> This driver, for the time being, assumes that the kernel page size is
> 4kB,
> so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with
> 64kB
> pages.
> 
> Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> Cc: stable@vger.kernel.org

This looks reasonable to me. During your testing, did you notice
whether there were compilation errors on !4K as well? If not, what do
you thing on allowing !4K also for COMPILE_TEST?

Thanks,
Thomas


> ---
>  drivers/gpu/drm/xe/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 2bb2bc052120..7c9f1de7b35f 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config DRM_XE
>  	tristate "Intel Xe2 Graphics"
> -	depends on DRM && PCI
> +	depends on DRM && PCI && (PAGE_SIZE_4KB || BROKEN)
>  	depends on KUNIT || !KUNIT
>  	depends on INTEL_VSEC || !INTEL_VSEC
>  	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)

[PATCH v3] Mark xe driver as BROKEN if kernel page size is not 4kB

[Simon Richter]

This driver, for the time being, assumes that the kernel page size is 4kB,
so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with 64kB
pages.

Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/xe/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 2bb2bc052120..ea12ff033439 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_XE
 	tristate "Intel Xe2 Graphics"
-	depends on DRM && PCI
+	depends on DRM && PCI && (PAGE_SIZE_4KB || COMPILE_TEST || BROKEN)
 	depends on KUNIT || !KUNIT
 	depends on INTEL_VSEC || !INTEL_VSEC
 	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)
-- 
2.47.2

Re: [PATCH v2 1/1] Mark xe driver as BROKEN if kernel page size is not 4kB

[Simon.Richter]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Hi,

added COMPILE_TEST — the goal behind this patch is to revert it as soon as possible, which will require some more testing though, and Debian wants something we can release that does not Oops on boot.

Presumably, the same change needs to be done for a few others (nouveau? amd?), but I haven't gotten around to testing yet if they actually fail with 64k pages, because this involves moving GPUs around — and testing 16k and 256k is even more effort, especially 256k, because that is larger than the default alignment of ELF binaries.

   Simon

[-- Attachment #2: Type: text/html, Size: 991 bytes --]

Re: [PATCH v3] Mark xe driver as BROKEN if kernel page size is not 4kB

[Thomas Hellström]

On Fri, 2025-08-01 at 19:19 +0900, Simon Richter wrote:
> This driver, for the time being, assumes that the kernel page size is
> 4kB,
> so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with
> 64kB
> pages.
> 
> Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> Cc: stable@vger.kernel.org

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
I will add a Fixes: tag and push this.

Thanks,
Thomas


> ---
>  drivers/gpu/drm/xe/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 2bb2bc052120..ea12ff033439 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config DRM_XE
>  	tristate "Intel Xe2 Graphics"
> -	depends on DRM && PCI
> +	depends on DRM && PCI && (PAGE_SIZE_4KB || COMPILE_TEST ||
> BROKEN)
>  	depends on KUNIT || !KUNIT
>  	depends on INTEL_VSEC || !INTEL_VSEC
>  	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)

Re: [PATCH v3] Mark xe driver as BROKEN if kernel page size is not 4kB

[Thomas Hellström]

On Fri, 2025-08-01 at 16:39 +0200, Thomas Hellström wrote:
> On Fri, 2025-08-01 at 19:19 +0900, Simon Richter wrote:
> > This driver, for the time being, assumes that the kernel page size
> > is
> > 4kB,
> > so it fails on loong64 and aarch64 with 16kB pages, and ppc64el
> > with
> > 64kB
> > pages.
> > 
> > Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> > Cc: stable@vger.kernel.org
> 
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> I will add a Fixes: tag and push this.
> 
> Thanks,
> Thomas

Actually, I see that the patch in its current form will cause grief
when backporting since that depends line has changed during driver
lifetime. I noticed that when trying to find a good Fixes: tag.

Would you mind if we did the following:

> 
> 
> > ---
> >  drivers/gpu/drm/xe/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/Kconfig
> > b/drivers/gpu/drm/xe/Kconfig
> > index 2bb2bc052120..ea12ff033439 100644
> > --- a/drivers/gpu/drm/xe/Kconfig
> > +++ b/drivers/gpu/drm/xe/Kconfig
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> >  config DRM_XE
> >  	tristate "Intel Xe2 Graphics"
> > -	depends on DRM && PCI
> > +	depends on DRM && PCI && (PAGE_SIZE_4KB || COMPILE_TEST ||
> > BROKEN)

Scratch this change

> >  	depends on KUNIT || !KUNIT
> >  	depends on INTEL_VSEC || !INTEL_VSEC
> >  	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)

And instead here add
	depends on PAGE_SIZE_4KB || COMPILE_TEST || BROKEN

Thanks,
Thomas


> 
> 

Re: [PATCH v3] Mark xe driver as BROKEN if kernel page size is not 4kB

[Simon Richter]

[-- Attachment #1.1: Type: text/plain, Size: 233 bytes --]

Hi,

On 8/1/25 23:56, Thomas Hellström wrote:

> Would you mind if we did the following:

[...]

> And instead here add
> 	depends on PAGE_SIZE_4KB || COMPILE_TEST || BROKEN

That is a lot nicer, I like it.

    Simon

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH v4] Mark xe driver as BROKEN if kernel page size is not 4kB

[Simon Richter]

This driver, for the time being, assumes that the kernel page size is 4kB,
so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with 64kB
pages.

Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/xe/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 2bb2bc052120..714d5702dfd7 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -5,6 +5,7 @@ config DRM_XE
 	depends on KUNIT || !KUNIT
 	depends on INTEL_VSEC || !INTEL_VSEC
 	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)
+	depends on PAGE_SIZE_4KB || COMPILE_TEST || BROKEN
 	select INTERVAL_TREE
 	# we need shmfs for the swappable backing store, and in particular
 	# the shmem_readpage() which depends upon tmpfs
-- 
2.47.2

Re: [PATCH v4] Mark xe driver as BROKEN if kernel page size is not 4kB

[Thomas Hellström]

On Sat, 2025-08-02 at 11:40 +0900, Simon Richter wrote:
> This driver, for the time being, assumes that the kernel page size is
> 4kB,
> so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with
> 64kB
> pages.
> 
> Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/xe/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 2bb2bc052120..714d5702dfd7 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -5,6 +5,7 @@ config DRM_XE
>  	depends on KUNIT || !KUNIT
>  	depends on INTEL_VSEC || !INTEL_VSEC
>  	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)
> +	depends on PAGE_SIZE_4KB || COMPILE_TEST || BROKEN
>  	select INTERVAL_TREE
>  	# we need shmfs for the swappable backing store, and in
> particular
>  	# the shmem_readpage() which depends upon tmpfs

R-B still stands.

I've pushed this to drm-xe-next with a Fixes: tag which means it will
likely end up in Linus' tree the upcoming weekend.

Thanks,
Thomas