From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Date: Fri, 12 May 2017 12:35:28 +0300 Message-ID: <3844793.Y2ncMspPzi@avalon> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A0376E009 for ; Fri, 12 May 2017 09:35:28 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Jose Abreu , Daniel Vetter , Alexey Brodkin , linux-kernel@vger.kernel.org, Carlos Palminha List-Id: dri-devel@lists.freedesktop.org SGkgSm9zZSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlc2RheSAwOSBNYXkgMjAx NyAxODowMDoxMiBKb3NlIEFicmV1IHdyb3RlOgo+IFRoaXMgY2hhbmdlcyB0aGUgY29ubmVjdG9y IHByb2JlIGhlbHBlciBmdW5jdGlvbiB0byB1c2UgdGhlIG5ldwo+IGVuY29kZXItPm1vZGVfdmFs aWQoKSBhbmQgY3J0Yy0+bW9kZV92YWxpZCgpIGhlbHBlciBjYWxsYmFja3MgdG8KPiB2YWxpZGF0 ZSB0aGUgbW9kZXMuCj4gCj4gVGhlIG5ldyBjYWxsYmFja3MgYXJlIG9wdGlvbmFsIHNvIHRoZSBi ZWhhdmlvdXIgcmVtYWlucyB0aGUgc2FtZQo+IGlmIHRoZXkgYXJlIG5vdCBpbXBsZW1lbnRlZC4g SWYgdGhleSBhcmUsIHRoZW4gdGhlIGNvZGUgbG9vcHMKPiB0aHJvdWdoIGFsbCB0aGUgY29ubmVj dG9yJ3MgZW5jb2RlcnNYY3J0Y3MgYW5kIGNhbGxzIHRoZQo+IGNhbGxiYWNrLgo+IAo+IElmIGF0 IGxlYXN0IGEgdmFsaWQgZW5jb2RlclhjcnRjIGNvbWJpbmF0aW9uIGlzIGZvdW5kIHdoaWNoCj4g YWNjZXB0cyB0aGUgbW9kZSB0aGVuIHRoZSBmdW5jdGlvbiByZXR1cm5zIE1PREVfT0suCj4gCj4g U2lnbmVkLW9mZi1ieTogSm9zZSBBYnJldSA8am9hYnJldUBzeW5vcHN5cy5jb20+Cj4gQ2M6IENh cmxvcyBQYWxtaW5oYSA8cGFsbWluaGFAc3lub3BzeXMuY29tPgo+IENjOiBBbGV4ZXkgQnJvZGtp biA8YWJyb2RraW5Ac3lub3BzeXMuY29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgo+IENjOiBEYXZlIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogQW5k cnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KPiBDYzogQXJjaGl0IFRhbmVqYSA8YXJj aGl0dEBjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiAKPiBDaGFuZ2VzIHYxLT52MjoKPiAJLSBVc2Ug bmV3IGhlbHBlcnMgc3VnZ2VzdGVkIGJ5IFZpbGxlCj4gCS0gQ2hhbmdlIGRvY3VtZW50YXRpb24g KERhbmllbCkKPiAKPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyB8IDYwICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1NyBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hl bHBlci5jIGluZGV4IDFiMGMxNGEuLmRlNDc0MTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVf aGVscGVyLmMKPiBAQCAtMzksNiArMzksOCBAQAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9oZWxw ZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fZWRpZC5oPgo+IAo+ICsjaW5jbHVkZSAiZHJtX2Ny dGNfaW50ZXJuYWwuaCIKPiArCj4gIC8qKgo+ICAgKiBET0M6IG91dHB1dCBwcm9iaW5nIGhlbHBl ciBvdmVydmlldwo+ICAgKgo+IEBAIC04MCw2ICs4Miw1NCBAQAo+ICAJcmV0dXJuIE1PREVfT0s7 Cj4gIH0KPiAKPiArc3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVzCj4gK2RybV9tb2RlX3ZhbGlk YXRlX2Nvbm5lY3RvcihzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICsJCQkgICAg c3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCgpUaGlzIGRvZXMgbW9yZSB0aGFuIHZhbGlk YXRpbmcgdGhlIG1vZGUgYWdhaW5zdCB0aGUgY29ubmVjdG9yLCBpdCB2YWxpZGF0ZXMgaXQgCmFn YWluc3QgdGhlIHdob2xlIHBpcGVsaW5lLiBJIHdvdWxkIGNhbGwgdGhlIGZ1bmN0aW9uIApkcm1f bW9kZV92YWxpZGF0ZV9waXBlbGluZSgpIChvciBhbnkgb3RoZXIgc2ltaWxhciBuYW1lKS4KCj4g K3sKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjb25uZWN0b3ItPmRldjsKPiArCXVpbnQz Ml90ICppZHMgPSBjb25uZWN0b3ItPmVuY29kZXJfaWRzOwo+ICsJZW51bSBkcm1fbW9kZV9zdGF0 dXMgcmV0ID0gTU9ERV9PSzsKPiArCXVuc2lnbmVkIGludCBpOwo+ICsKPiArCS8qIFN0ZXAgMTog VmFsaWRhdGUgYWdhaW5zdCBjb25uZWN0b3IgKi8KPiArCXJldCA9IGRybV9jb25uZWN0b3JfbW9k ZV92YWxpZChjb25uZWN0b3IsIG1vZGUpOwo+ICsJaWYgKHJldCAhPSBNT0RFX09LKQo+ICsJCXJl dHVybiByZXQ7Cj4gKwo+ICsJLyogU3RlcCAyOiBWYWxpZGF0ZSBhZ2FpbnN0IGVuY29kZXJzIGFu ZCBjcnRjcyAqLwo+ICsJZm9yIChpID0gMDsgaSA8IERSTV9DT05ORUNUT1JfTUFYX0VOQ09ERVI7 IGkrKykgewo+ICsJCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciA9IGRybV9lbmNvZGVyX2Zp bmQoZGV2LCBpZHNbaV0pOwo+ICsJCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiArCj4gKwkJaWYg KCFlbmNvZGVyKQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJcmV0ID0gZHJtX2VuY29kZXJfbW9k ZV92YWxpZChlbmNvZGVyLCBtb2RlKTsKPiArCQlpZiAocmV0ICE9IE1PREVfT0spIHsKPiArCQkJ LyogTm8gcG9pbnQgaW4gY29udGludWluZyBmb3IgY3J0YyBjaGVjayBhcyB0aGlzIAplbmNvZGVy Cj4gKwkJCSAqIHdpbGwgbm90IGFjY2VwdCB0aGUgbW9kZSBhbnl3YXkuIElmIGFsbCBlbmNvZGVy cwo+ICsJCQkgKiByZWplY3QgdGhlIG1vZGUgdGhlbiwgYXQgZXhpdCwgcmV0IHdpbGwgbm90IGJl Cj4gKwkJCSAqIE1PREVfT0suICovCj4gKwkJCWNvbnRpbnVlOwo+ICsJCX0KPiArCj4gKwkJZHJt X2Zvcl9lYWNoX2NydGMoY3J0YywgZGV2KSB7Cj4gKwkJCWlmICghZHJtX2VuY29kZXJfY3J0Y19v ayhlbmNvZGVyLCBjcnRjKSkKPiArCQkJCWNvbnRpbnVlOwo+ICsKPiArCQkJcmV0ID0gZHJtX2Ny dGNfbW9kZV92YWxpZChjcnRjLCBtb2RlKTsKPiArCQkJaWYgKHJldCA9PSBNT0RFX09LKSB7Cj4g KwkJCQkvKiBJZiB3ZSBnZXQgdG8gdGhpcyBwb2ludCB0aGVyZSBpcyBhdCBsZWFzdAo+ICsJCQkJ ICogb25lIGNvbWJpbmF0aW9uIG9mIGVuY29kZXIrY3J0YyB0aGF0IHdvcmtzCj4gKwkJCQkgKiBm b3IgdGhpcyBtb2RlLiBMZXRzIHJldHVybiBub3cuICovCj4gKwkJCQlyZXR1cm4gcmV0Owo+ICsJ CQl9Cj4gKwkJfQo+ICsJfQo+ICsKPiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gIHN0YXRpYyBp bnQgZHJtX2hlbHBlcl9wcm9iZV9hZGRfY21kbGluZV9tb2RlKHN0cnVjdCBkcm1fY29ubmVjdG9y Cj4gKmNvbm5lY3RvcikKPiAgewo+ICAJc3RydWN0IGRybV9jbWRsaW5lX21vZGUgKmNtZGxpbmVf bW9kZTsKPiBAQCAtMjg0LDcgKzMzNCwxMSBAQCB2b2lkIGRybV9rbXNfaGVscGVyX3BvbGxfZW5h YmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAqICAgIC0gZHJtX21vZGVfdmFsaWRhdGVf ZmxhZygpIGNoZWNrcyB0aGUgbW9kZXMgYWdhaW5zdCBiYXNpYyBjb25uZWN0b3IKPiAgICogICAg ICBjYXBhYmlsaXRpZXMgKGludGVybGFjZV9hbGxvd2VkLGRvdWJsZXNjYW5fYWxsb3dlZCxzdGVy ZW9fYWxsb3dlZCkKPiAgICogICAgLSB0aGUgb3B0aW9uYWwgJmRybV9jb25uZWN0b3JfaGVscGVy X2Z1bmNzLm1vZGVfdmFsaWQgaGVscGVyIGNhbgo+IHBlcmZvcm0KPiAtICogICAgICBkcml2ZXIg YW5kL29yIGhhcmR3YXJlIHNwZWNpZmljIGNoZWNrcwo+ICsgKiAgICAgIGRyaXZlciBhbmQvb3Ig c2luayBzcGVjaWZpYyBjaGVja3MKPiArICogICAgLSB0aGUgb3B0aW9uYWwgJmRybV9jcnRjX2hl bHBlcl9mdW5jcy5tb2RlX3ZhbGlkIGFuZAo+ICsgKiAgICAgICZkcm1fZW5jb2Rlcl9oZWxwZXJf ZnVuY3MubW9kZV92YWxpZCBoZWxwZXJzIGNhbiBwZXJmb3JtIGRyaXZlcgo+IGFuZC9vcgo+ICsg KiAgICAgIHNvdXJjZSBzcGVjaWZpYyBjaGVja3Mgd2hpY2ggYXJlIGFsc28gZW5mb3JjZWQgYnkg dGhlCj4gbW9kZXNldC9hdG9taWMKPiArICogICAgICBoZWxwZXJzCj4gICAqCj4gICAqIDUuIEFu eSBtb2RlIHdob3NlIHN0YXR1cyBpcyBub3QgT0sgaXMgcHJ1bmVkIGZyb20gdGhlIGNvbm5lY3Rv cidzIG1vZGVzCj4gbGlzdCwKPiAgICogICAgYWNjb21wYW5pZWQgYnkgYSBkZWJ1ZyBtZXNzYWdl IGluZGljYXRpbmcgdGhlIHJlYXNvbiBmb3IgdGhlIG1vZGUncwo+IEBAIC00MjgsOCArNDgyLDgg QEAgaW50Cj4gZHJtX2hlbHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9yX21vZGVzKHN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJaWYgKG1vZGUtPnN0YXR1cyA9PSBNT0RFX09L KQo+ICAJCQltb2RlLT5zdGF0dXMgPSBkcm1fbW9kZV92YWxpZGF0ZV9mbGFnKG1vZGUsCj4gbW9k ZV9mbGFncyk7Cj4gCj4gLQkJaWYgKG1vZGUtPnN0YXR1cyA9PSBNT0RFX09LICYmIGNvbm5lY3Rv cl9mdW5jcy0+bW9kZV92YWxpZCkKPiAtCQkJbW9kZS0+c3RhdHVzID0gY29ubmVjdG9yX2Z1bmNz LT5tb2RlX3ZhbGlkKGNvbm5lY3RvciwKPiArCQlpZiAobW9kZS0+c3RhdHVzID09IE1PREVfT0sp Cj4gKwkJCW1vZGUtPnN0YXR1cyA9IGRybV9tb2RlX3ZhbGlkYXRlX2Nvbm5lY3Rvcihjb25uZWN0 b3IsCj4gIAkJCQkJCQkJICAgbW9kZSk7CgpJIHdvdWxkIHJldmVyc2UgdGhlIGFyZ3VtZW50cyBv cmRlciB0byBtYXRjaCB0aGUgc3R5bGUgb2YgdGhlIG90aGVyIHZhbGlkYXRpb24gCmZ1bmN0aW9u cy4KCj4gIAl9CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=