From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Sekhar Nori <nsekhar@ti.com>, LKML <linux-kernel@vger.kernel.org>,
linux-drm <dri-devel@lists.freedesktop.org>,
Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate()
Date: Wed, 28 Sep 2016 14:55:18 +0300 [thread overview]
Message-ID: <39ca356b-6cf5-e905-1d22-284014b7318e@ti.com> (raw)
In-Reply-To: <CAMpxmJWtxhNHJ1ShHsxjOHfdDKWVGPwRGCaRez+dOkmhRa0ydg@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 701 bytes --]
On 28/09/16 14:43, Bartosz Golaszewski wrote:
> how far is far enough to emit a warning? On da850 the requested rate
> is 228000000 Hz, while the calculated divider is 6, which results in
> the real rate of 225000000 Hz. This is less than 1% difference -
> should we take this value as reference?
Good question, and I don't have a clear answer. But I think the point is
just to inform the user that it's likely that his LCD won't work
properly, and often LCDs are quite tolerant about the pclk. So diff less
than 1% is just fine. Even 5% sounds still fine to me, perhaps even 10%.
I think we just have to try something out, and adjust it if people get
the message too often.
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-09-28 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 15:29 [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate() Bartosz Golaszewski
2016-09-28 10:57 ` Jyri Sarha
2016-09-28 11:19 ` Tomi Valkeinen
2016-09-28 11:43 ` Bartosz Golaszewski
2016-09-28 11:55 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ca356b-6cf5-e905-1d22-284014b7318e@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox