From: Steven Price <steven.price@arm.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 08/12] drm/panfrost: Do the exception -> string translation using a table
Date: Mon, 21 Jun 2021 16:19:38 +0100 [thread overview]
Message-ID: <39e7887f-dc9a-376f-0b0e-e15835ed139a@arm.com> (raw)
In-Reply-To: <20210621133907.1683899-9-boris.brezillon@collabora.com>
On 21/06/2021 14:39, Boris Brezillon wrote:
> Do the exception -> string translation using a table so we can add extra
> fields if we need to. While at it add an error field to ease the
> exception -> error conversion which we'll need if we want to set the
> fence error to something that reflects the exception code.
>
> TODO: fix the error codes.
TODO: Do the TODO ;)
I'm not sure how useful translating the hardware error codes to Linux
ones are. E.g. 'OOM' means something quite different from a normal
-ENOMEM. One is running out of a space in a predefined buffer, the other
is Linux not able to allocate memory.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 134 +++++++++++++--------
> drivers/gpu/drm/panfrost/panfrost_device.h | 1 +
> 2 files changed, 88 insertions(+), 47 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index f7f5ca94f910..2de011cee258 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -292,55 +292,95 @@ void panfrost_device_fini(struct panfrost_device *pfdev)
> panfrost_clk_fini(pfdev);
> }
>
> -const char *panfrost_exception_name(u32 exception_code)
> -{
> - switch (exception_code) {
> - /* Non-Fault Status code */
> - case 0x00: return "NOT_STARTED/IDLE/OK";
> - case 0x01: return "DONE";
> - case 0x02: return "INTERRUPTED";
> - case 0x03: return "STOPPED";
> - case 0x04: return "TERMINATED";
> - case 0x08: return "ACTIVE";
> - /* Job exceptions */
> - case 0x40: return "JOB_CONFIG_FAULT";
> - case 0x41: return "JOB_POWER_FAULT";
> - case 0x42: return "JOB_READ_FAULT";
> - case 0x43: return "JOB_WRITE_FAULT";
> - case 0x44: return "JOB_AFFINITY_FAULT";
> - case 0x48: return "JOB_BUS_FAULT";
> - case 0x50: return "INSTR_INVALID_PC";
> - case 0x51: return "INSTR_INVALID_ENC";
> - case 0x52: return "INSTR_TYPE_MISMATCH";
> - case 0x53: return "INSTR_OPERAND_FAULT";
> - case 0x54: return "INSTR_TLS_FAULT";
> - case 0x55: return "INSTR_BARRIER_FAULT";
> - case 0x56: return "INSTR_ALIGN_FAULT";
> - case 0x58: return "DATA_INVALID_FAULT";
> - case 0x59: return "TILE_RANGE_FAULT";
> - case 0x5A: return "ADDR_RANGE_FAULT";
> - case 0x60: return "OUT_OF_MEMORY";
> - /* GPU exceptions */
> - case 0x80: return "DELAYED_BUS_FAULT";
> - case 0x88: return "SHAREABILITY_FAULT";
> - /* MMU exceptions */
> - case 0xC1: return "TRANSLATION_FAULT_LEVEL1";
> - case 0xC2: return "TRANSLATION_FAULT_LEVEL2";
> - case 0xC3: return "TRANSLATION_FAULT_LEVEL3";
> - case 0xC4: return "TRANSLATION_FAULT_LEVEL4";
> - case 0xC8: return "PERMISSION_FAULT";
> - case 0xC9 ... 0xCF: return "PERMISSION_FAULT";
> - case 0xD1: return "TRANSTAB_BUS_FAULT_LEVEL1";
> - case 0xD2: return "TRANSTAB_BUS_FAULT_LEVEL2";
> - case 0xD3: return "TRANSTAB_BUS_FAULT_LEVEL3";
> - case 0xD4: return "TRANSTAB_BUS_FAULT_LEVEL4";
> - case 0xD8: return "ACCESS_FLAG";
> - case 0xD9 ... 0xDF: return "ACCESS_FLAG";
> - case 0xE0 ... 0xE7: return "ADDRESS_SIZE_FAULT";
> - case 0xE8 ... 0xEF: return "MEMORY_ATTRIBUTES_FAULT";
> +#define PANFROST_EXCEPTION(id, err) \
> + [DRM_PANFROST_EXCEPTION_ ## id] = { \
> + .name = #id, \
> + .error = err, \
> }
>
> - return "UNKNOWN";
> +struct panfrost_exception_info {
> + const char *name;
> + int error;
> +};
> +
> +static const struct panfrost_exception_info panfrost_exception_infos[] = {
> + PANFROST_EXCEPTION(OK, 0),
> + PANFROST_EXCEPTION(DONE, 0),
> + PANFROST_EXCEPTION(STOPPED, 0),
> + PANFROST_EXCEPTION(TERMINATED, 0),
STOPPED/TERMINATED are not really 'success' from an application
perspective. But equally they are ones that need special handling from
the kernel.
> + PANFROST_EXCEPTION(KABOOM, 0),
> + PANFROST_EXCEPTION(EUREKA, 0),
> + PANFROST_EXCEPTION(ACTIVE, 0),
> + PANFROST_EXCEPTION(JOB_CONFIG_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(JOB_POWER_FAULT, -ECANCELED),
> + PANFROST_EXCEPTION(JOB_READ_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(JOB_WRITE_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(JOB_AFFINITY_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(JOB_BUS_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(INSTR_INVALID_PC, -EINVAL),
> + PANFROST_EXCEPTION(INSTR_INVALID_ENC, -EINVAL),
> + PANFROST_EXCEPTION(INSTR_BARRIER_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(DATA_INVALID_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(TILE_RANGE_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_RANGE_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(IMPRECISE_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(OOM, -ENOMEM),
> + PANFROST_EXCEPTION(UNKNOWN, -EINVAL),
We should probably make a distinction between this 'special' UNKNOWN
that the hardware can report...
> + PANFROST_EXCEPTION(DELAYED_BUS_FAULT, -EINVAL),
> + PANFROST_EXCEPTION(GPU_SHAREABILITY_FAULT, -ECANCELED),
> + PANFROST_EXCEPTION(SYS_SHAREABILITY_FAULT, -ECANCELED),
> + PANFROST_EXCEPTION(GPU_CACHEABILITY_FAULT, -ECANCELED),
> + PANFROST_EXCEPTION(TRANSLATION_FAULT_0, -EINVAL),
> + PANFROST_EXCEPTION(TRANSLATION_FAULT_1, -EINVAL),
> + PANFROST_EXCEPTION(TRANSLATION_FAULT_2, -EINVAL),
> + PANFROST_EXCEPTION(TRANSLATION_FAULT_3, -EINVAL),
> + PANFROST_EXCEPTION(TRANSLATION_FAULT_4, -EINVAL),
> + PANFROST_EXCEPTION(TRANSLATION_FAULT_IDENTITY, -EINVAL),
> + PANFROST_EXCEPTION(PERM_FAULT_0, -EINVAL),
> + PANFROST_EXCEPTION(PERM_FAULT_1, -EINVAL),
> + PANFROST_EXCEPTION(PERM_FAULT_2, -EINVAL),
> + PANFROST_EXCEPTION(PERM_FAULT_3, -EINVAL),
> + PANFROST_EXCEPTION(TRANSTAB_BUS_FAULT_0, -EINVAL),
> + PANFROST_EXCEPTION(TRANSTAB_BUS_FAULT_1, -EINVAL),
> + PANFROST_EXCEPTION(TRANSTAB_BUS_FAULT_2, -EINVAL),
> + PANFROST_EXCEPTION(TRANSTAB_BUS_FAULT_3, -EINVAL),
> + PANFROST_EXCEPTION(ACCESS_FLAG_0, -EINVAL),
> + PANFROST_EXCEPTION(ACCESS_FLAG_1, -EINVAL),
> + PANFROST_EXCEPTION(ACCESS_FLAG_2, -EINVAL),
> + PANFROST_EXCEPTION(ACCESS_FLAG_3, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_IN0, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_IN1, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_IN2, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_IN3, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_OUT0, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_OUT1, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_OUT2, -EINVAL),
> + PANFROST_EXCEPTION(ADDR_SIZE_FAULT_OUT3, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_FAULT_0, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_FAULT_1, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_FAULT_2, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_FAULT_3, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_NONCACHE_0, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_NONCACHE_1, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_NONCACHE_2, -EINVAL),
> + PANFROST_EXCEPTION(MEM_ATTR_NONCACHE_3, -EINVAL),
> +};
> +
> +const char *panfrost_exception_name(u32 exception_code)
> +{
> + if (WARN_ON(exception_code >= ARRAY_SIZE(panfrost_exception_infos) ||
> + !panfrost_exception_infos[exception_code].name))
> + return "UNKNOWN";
...and this UNKNOWN that just means we don't have a clue what the magic
number is.
Steve
> +
> + return panfrost_exception_infos[exception_code].name;
> +}
> +
> +int panfrost_exception_to_error(u32 exception_code)
> +{
> + if (WARN_ON(exception_code >= ARRAY_SIZE(panfrost_exception_infos)))
> + return 0;
> +
> + return panfrost_exception_infos[exception_code].error;
> }
>
> void panfrost_device_reset(struct panfrost_device *pfdev)
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h
> index 1c6a3597eba0..498c7b5dccd0 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.h
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.h
> @@ -174,6 +174,7 @@ int panfrost_device_resume(struct device *dev);
> int panfrost_device_suspend(struct device *dev);
>
> const char *panfrost_exception_name(u32 exception_code);
> +int panfrost_exception_to_error(u32 exception_code);
>
> static inline void
> panfrost_device_schedule_reset(struct panfrost_device *pfdev)
>
next prev parent reply other threads:[~2021-06-21 15:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 13:38 [PATCH v2 00/12] drm/panfrost: Misc fixes/improvements Boris Brezillon
2021-06-21 13:38 ` [PATCH v2 01/12] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv Boris Brezillon
2021-06-21 13:57 ` Alyssa Rosenzweig
2021-06-21 14:29 ` Steven Price
2021-06-21 14:44 ` Boris Brezillon
2021-06-24 8:03 ` Boris Brezillon
2021-06-21 13:38 ` [PATCH v2 02/12] drm/panfrost: Get rid of the unused JS_STATUS_EVENT_ACTIVE definition Boris Brezillon
2021-06-21 14:34 ` Steven Price
2021-06-21 14:49 ` Boris Brezillon
2021-06-21 14:54 ` Steven Price
2021-06-21 13:38 ` [PATCH v2 03/12] drm/panfrost: Drop the pfdev argument passed to panfrost_exception_name() Boris Brezillon
2021-06-21 14:36 ` Steven Price
2021-06-21 13:38 ` [PATCH v2 04/12] drm/panfrost: Expose exception types to userspace Boris Brezillon
2021-06-21 14:49 ` Steven Price
2021-06-21 14:55 ` Boris Brezillon
2021-06-21 13:39 ` [PATCH v2 05/12] drm/panfrost: Disable the AS on unhandled page faults Boris Brezillon
2021-06-21 15:08 ` Boris Brezillon
2021-06-21 15:09 ` Steven Price
2021-06-21 15:32 ` Boris Brezillon
2021-06-21 13:39 ` [PATCH v2 06/12] drm/panfrost: Expose a helper to trigger a GPU reset Boris Brezillon
2021-06-21 15:10 ` Steven Price
2021-06-21 13:39 ` [PATCH v2 07/12] drm/panfrost: Reset the GPU when the AS_ACTIVE bit is stuck Boris Brezillon
2021-06-21 15:11 ` Steven Price
2021-06-21 13:39 ` [PATCH v2 08/12] drm/panfrost: Do the exception -> string translation using a table Boris Brezillon
2021-06-21 15:19 ` Steven Price [this message]
2021-06-21 15:46 ` Boris Brezillon
2021-06-21 13:39 ` [PATCH v2 09/12] drm/panfrost: Don't reset the GPU on job faults unless we really have to Boris Brezillon
2021-06-21 15:26 ` Steven Price
2021-06-21 13:39 ` [PATCH v2 10/12] drm/panfrost: Kill in-flight jobs on FD close Boris Brezillon
2021-06-21 15:31 ` Steven Price
2021-06-21 13:39 ` [PATCH v2 11/12] drm/panfrost: Make ->run_job() return an ERR_PTR() when appropriate Boris Brezillon
2021-06-21 15:33 ` Steven Price
2021-06-21 13:39 ` [PATCH v2 12/12] drm/panfrost: Shorten the fence signalling section Boris Brezillon
2021-06-21 15:43 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e7887f-dc9a-376f-0b0e-e15835ed139a@arm.com \
--to=steven.price@arm.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox