From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1D40C07E97 for ; Tue, 5 Dec 2023 13:05:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D178910E514; Tue, 5 Dec 2023 13:05:39 +0000 (UTC) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79BD910E514 for ; Tue, 5 Dec 2023 13:05:37 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id BCF13580995; Tue, 5 Dec 2023 08:05:36 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 05 Dec 2023 08:05:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701781536; x=1701788736; bh=zv 8E1tGkz8JRoBtprl3IIFJf3pqYhFYTFABmpiAXWAw=; b=3WQNels8GZT9EHjAGe 8yfIGTf6t1rQoHVS0QDsjV/1Tkqf1GPB1IVd2yS7sVoLExG8iqjS8uPv5XwVpv39 jlFbgdIvDOafO5fmVa2Er6yIcNwxHCoNlokod1SrXZw8RNvJs8wQF6zCzTn3jpID Ss3nDuYnLEKXbcZZAtlsqlF67+azlHhK/2GRq9SwOa3CJAv7v7p1DgfhuCiMXMBB OE0Q9jvcIZIxPk7RJwZhwiLLuEjViqjU1eqhwWNN4zE3CPO3Tx+YCmS8bM4DazwM h/2kkZOJ17rU0BNUizcCbuD6VH3OIdZwjTpCxtxTSlxrk2ctYbStFsPLeMhJE/C0 2fCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701781536; x=1701788736; bh=zv8E1tGkz8JRo Btprl3IIFJf3pqYhFYTFABmpiAXWAw=; b=wlpv/9HnZko73ZnxFuSLnB5FO3HGW DhMsSqbTGUW7mNrYTONRLLTwBAv4W0Ql0T9FtUAstavChyMo7lPd7Uqkp6Tb5z2b KoQ9a4ghH4y320yL2wOeSC6uCN/U1vKhABUiDBy4/v6T6Z0fQmRMYiUBQxX/E9kE Kyx6mJYgEmXXKMFcCmkGPKpCNKSor4qkqGOitktJniahB0IQGMC282ZhwpICp/eM 2Km1E8Wc6XsBUInY2WqMTRAPEzdKE7r0k6sauJIDLHD4550BRFSbxUB04/q+xN4A Xt5q4cGHn1chsJ3D/xmriqqhSTnBaw/8RR7bWSidwZ4KBmAUPKntYDygg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejkedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B88B2B60089; Tue, 5 Dec 2023 08:05:32 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 MIME-Version: 1.0 Message-Id: <3acae2ba-e91a-46d2-8748-b2cb1b369063@app.fastmail.com> In-Reply-To: References: Date: Tue, 05 Dec 2023 14:05:11 +0100 From: "Arnd Bergmann" To: "Yoshinori Sato" , linux-sh@vger.kernel.org Subject: Re: [DO NOT MERGE v5 10/37] sh: Common PCI Framework driver support. Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , linux-fbdev@vger.kernel.org, Rich Felker , Herve Codina , Geert Uytterhoeven , Bin Meng , Michael Turquette , linux-pci@vger.kernel.org, Jacky Huang , Palmer Dabbelt , Max Filippov , guoren , Lee Jones , Krzysztof Kozlowski , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jiri Slaby , linux-clk@vger.kernel.org, Stephen Rothwell , Laurent Pinchart , Baoquan He , Jonathan Corbet , Helge Deller , Daniel Lezcano , Magnus Damm , Javier Martinez Canillas , Jernej Skrabec , linux-serial@vger.kernel.org, David Rientjes , Lukas Bulwahn , Lorenzo Pieralisi , Guenter Roeck , devicetree@vger.kernel.org, Conor Dooley , Thomas Zimmermann , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Maxime Ripard , Sam Ravnborg , Rob Herring , dri-devel@lists.freedesktop.org, Chris Morgan , John Paul Adrian Glaubitz , Bjorn Helgaas , Thomas Gleixner , Vlastimil Babka , Sergey Shtylyov , linux-ide@vger.kernel.org, Stephen Boyd , Greg Kroah-Hartman , Randy Dunlap , Biju Das , linux-kernel@vger.kernel.org, Azeem Shaikh , Linux-Renesas , Tom Rix , Damien Le Moal , Michael Karcher , Andrew Morton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > + > +#if defined(CONFIG_PCI) && !defined(CONFIG_GENERIC_IOMAP) > +void pci_iounmap(struct pci_dev *dev, void __iomem *addr) > +{ > + iounmap(addr); > +} > +EXPORT_SYMBOL(pci_iounmap); This definition does not work for addresses that are returned by ioport_map(), include pci_iomap() on IORESOURCE_IO. However, the definition in lib/pci_iomap.c should work fine, you just need to #define ARCH_WANTS_GENERIC_PCI_IOUNMAP to get that. Arnd