From: "Souza, Jose" <jose.souza@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/edid: Clean up some curly braces
Date: Wed, 1 Jul 2020 00:01:56 +0000 [thread overview]
Message-ID: <3b39c148c6cd8a6927101ca1afb29a94248f57bb.camel@intel.com> (raw)
In-Reply-To: <20200527130310.27099-3-ville.syrjala@linux.intel.com>
On Wed, 2020-05-27 at 16:03 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Drop some pointless curly braces, and add some across the
> else when the if has them too.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index dcb23563d29d..8a951e2bfb41 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -5836,22 +5836,21 @@ static void drm_parse_tiled_block(struct drm_connector *connector,
> DRM_DEBUG_KMS("vend %c%c%c\n", tile->topology_id[0], tile->topology_id[1], tile->topology_id[2]);
>
> tg = drm_mode_get_tile_group(connector->dev, tile->topology_id);
> - if (!tg) {
> + if (!tg)
> tg = drm_mode_create_tile_group(connector->dev, tile->topology_id);
> - }
> if (!tg)
> return;
>
> if (connector->tile_group != tg) {
> /* if we haven't got a pointer,
> take the reference, drop ref to old tile group */
> - if (connector->tile_group) {
> + if (connector->tile_group)
> drm_mode_put_tile_group(connector->dev, connector->tile_group);
> - }
> connector->tile_group = tg;
> - } else
> + } else {
> /* if same tile group, then release the ref we just took. */
> drm_mode_put_tile_group(connector->dev, tg);
> + }
> }
>
> static void drm_displayid_parse_tiled(struct drm_connector *connector,
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-01 0:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:03 [PATCH 1/3] drm/edid: Allow looking for ext blocks starting from a specified index Ville Syrjala
2020-05-27 13:03 ` [PATCH 2/3] drm/edid: Iterate through all DispID ext blocks Ville Syrjala
2020-07-01 0:00 ` [Intel-gfx] " Souza, Jose
2020-05-27 13:03 ` [PATCH 3/3] drm/edid: Clean up some curly braces Ville Syrjala
2020-07-01 0:01 ` Souza, Jose [this message]
2020-06-30 23:42 ` [Intel-gfx] [PATCH 1/3] drm/edid: Allow looking for ext blocks starting from a specified index Souza, Jose
2020-07-02 14:40 ` Ville Syrjälä
2020-07-02 20:45 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b39c148c6cd8a6927101ca1afb29a94248f57bb.camel@intel.com \
--to=jose.souza@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox