From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/1] Revert "gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle" Date: Tue, 13 Sep 2016 15:28:21 +0300 Message-ID: <3b3d1cd4-edf2-add6-ba4e-271b8a8cff69@ti.com> References: <1470908694-16362-1-git-send-email-peter.chen@nxp.com> <79f4ebd5-bb8b-fd33-c4aa-e0f342407407@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2058270206==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id A5CC26E00C for ; Tue, 13 Sep 2016 12:28:26 +0000 (UTC) In-Reply-To: <79f4ebd5-bb8b-fd33-c4aa-e0f342407407@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@linux.ie Cc: Peter Chen , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2058270206== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xBIV53VMUq5f43eFnIlVolxFL6fSkoLht" --xBIV53VMUq5f43eFnIlVolxFL6fSkoLht Content-Type: multipart/mixed; boundary="wksI9p09MtglPlv1emUGLJJLCx8arjoMk"; protected-headers="v1" From: Tomi Valkeinen To: airlied@linux.ie Cc: Peter Chen , seanpaul@chromium.org, dri-devel@lists.freedesktop.org Message-ID: <3b3d1cd4-edf2-add6-ba4e-271b8a8cff69@ti.com> Subject: Re: [PATCH 1/1] Revert "gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle" References: <1470908694-16362-1-git-send-email-peter.chen@nxp.com> <79f4ebd5-bb8b-fd33-c4aa-e0f342407407@ti.com> In-Reply-To: <79f4ebd5-bb8b-fd33-c4aa-e0f342407407@ti.com> --wksI9p09MtglPlv1emUGLJJLCx8arjoMk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Dave, Ping on this. This one is already in drm-next, so one can just cherry-pick it: 5a78ff7bf7e25191144b550961001bbf6c734da4 Tomi On 06/09/16 15:18, Tomi Valkeinen wrote: > Hi Dave, >=20 > Can you pick this for drm-fixes? The bug is causing scary looking stack= > dumps when loading omapdrm. >=20 > Apparently this fix went into drm-next accidentally instead of > drm-fixes. I hope having the same patch in both trees won't be causing > any extra conflicts. >=20 > Tomi >=20 > On 11/08/16 12:44, Peter Chen wrote: >> This reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f. >> >> The of_get_next_parent will drop refcount on the passed node, so the r= everted >> patch is wrong, thanks for Tomi Valkeinen points it. >> >> Cc: Tomi Valkeinen >> Signed-off-by: Peter Chen >> --- >> drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b/drivers/gpu/drm/om= apdrm/dss/dss-of.c >> index e256d87..dfd4e96 100644 >> --- a/drivers/gpu/drm/omapdrm/dss/dss-of.c >> +++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c >> @@ -125,16 +125,15 @@ u32 dss_of_port_get_port_number(struct device_no= de *port) >> =20 >> static struct device_node *omapdss_of_get_remote_port(const struct de= vice_node *node) >> { >> - struct device_node *np, *np_parent; >> + struct device_node *np; >> =20 >> np =3D of_parse_phandle(node, "remote-endpoint", 0); >> if (!np) >> return NULL; >> =20 >> - np_parent =3D of_get_next_parent(np); >> - of_node_put(np); >> + np =3D of_get_next_parent(np); >> =20 >> - return np_parent; >> + return np; >> } >> =20 >> struct device_node * >> >=20 --wksI9p09MtglPlv1emUGLJJLCx8arjoMk-- --xBIV53VMUq5f43eFnIlVolxFL6fSkoLht Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX1/DlAAoJEPo9qoy8lh7102wP/1ugiZ8wjNTDh6fCieG8nvAQ Aks1Tdy9nF+ZcMyh0v/0gmJeX9buVvZHLFKcCqKRlvQAMN6MDsw63w1hr1zxOwZK APO48MXGLPN9GbiKj0jYzWe58qYc4+P+xYoS/5HM6M42foNCsSmUtf/GicRhvAeq csi8o7CD2L6xnrgoOJi5/KpNn9Lhy7EJlQ337XBCIFvkWaMygwXgSiIqy3An+aap WCz4qK8bb+sORLfY5WAvFCZ7/fGQ/JvtEq23ZVsxxLMedTxT87Bw9bonCwrobKFi xzJy3g5iEkyH6Vr0zjm8nF2LxeOs6YXadMg3bK7RXnjBomyIeHmrh9p7pa9MuW7Q 6B4VNSryO/PGJeX1WkNiIY3IPFLTsmBD2iEhOXrGt5go6JIq1yAJVO/oqvnWC0Yl QI2CJj7T+2Jvuw2GGBFqmHjsPiqzMx3etTnrwK8iTo2BSsAwmcscRfj+g5pyqQxq oK1HpiqMt2fyI15+lyKZ9OUrBT9ca84MW4yDaTZiWGhPanVXQgnr0XwqZR870p1u XJgUB0u2sekRtRmBBE8K9qydMBXsbjYBEqmGSUdIvZo31FsS434AHOGgd2vOqWti 0f4uPz+GxwtEfzqtpTWK1oye7UrAtaQXMPjeeuBbzw5XpJPTQ71i9/VVLo0J6Xk8 vtqyYD7Kjg0ZutSi0Xyb =C40U -----END PGP SIGNATURE----- --xBIV53VMUq5f43eFnIlVolxFL6fSkoLht-- --===============2058270206== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2058270206==--