From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth' Date: Tue, 26 Mar 2019 12:24:33 +0530 Message-ID: <3b86d359-bfba-8f4e-a8c1-64d233867940@codeaurora.org> References: <20190323024606.163683-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1484109405==" Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7E896E791 for ; Tue, 26 Mar 2019 06:54:44 +0000 (UTC) In-Reply-To: <20190323024606.163683-1-yuehaibing@huawei.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YueHaibing , VMware Graphics , Thomas Hellstrom , David Airlie , Daniel Vetter Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1484109405== Content-Type: multipart/alternative; boundary="------------2E669B8BE99B2CB50AF41101" Content-Language: en-US This is a multi-part message in MIME format. --------------2E669B8BE99B2CB50AF41101 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/23/2019 8:16 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init': > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning: > variable 'fb_offset' set but not used [-Wunused-but-set-variable] > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:19: warning: > variable 'fb_depth' set but not used [-Wunused-but-set-variable] > > They're not used any more, so can be removed. > > Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha > Thanks. Mukesh > --- > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > index 2a9112515f46..86efb91f5034 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > @@ -642,12 +642,11 @@ int vmw_fb_init(struct vmw_private *vmw_priv) > struct vmw_fb_par *par; > struct fb_info *info; > unsigned fb_width, fb_height; > - unsigned fb_bpp, fb_depth, fb_offset, fb_pitch, fb_size; > + unsigned fb_bpp, fb_pitch, fb_size; > struct drm_display_mode *init_mode; > int ret; > > fb_bpp = 32; > - fb_depth = 24; > > /* XXX As shouldn't these be as well. */ > fb_width = min(vmw_priv->fb_max_width, (unsigned)2048); > @@ -655,7 +654,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv) > > fb_pitch = fb_width * fb_bpp / 8; > fb_size = fb_pitch * fb_height; > - fb_offset = vmw_read(vmw_priv, SVGA_REG_FB_OFFSET); > > info = framebuffer_alloc(sizeof(*par), device); > if (!info) > > > --------------2E669B8BE99B2CB50AF41101 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit


On 3/23/2019 8:16 AM, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning:
 variable 'fb_offset' set but not used [-Wunused-but-set-variable]

drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:19: warning:
 variable 'fb_depth' set but not used [-Wunused-but-set-variable]

They're not used any more, so can be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Thanks.
Mukesh 


---
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
index 2a9112515f46..86efb91f5034 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
@@ -642,12 +642,11 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
 	struct vmw_fb_par *par;
 	struct fb_info *info;
 	unsigned fb_width, fb_height;
-	unsigned fb_bpp, fb_depth, fb_offset, fb_pitch, fb_size;
+	unsigned fb_bpp, fb_pitch, fb_size;
 	struct drm_display_mode *init_mode;
 	int ret;
 
 	fb_bpp = 32;
-	fb_depth = 24;
 
 	/* XXX As shouldn't these be as well. */
 	fb_width = min(vmw_priv->fb_max_width, (unsigned)2048);
@@ -655,7 +654,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
 
 	fb_pitch = fb_width * fb_bpp / 8;
 	fb_size = fb_pitch * fb_height;
-	fb_offset = vmw_read(vmw_priv, SVGA_REG_FB_OFFSET);
 
 	info = framebuffer_alloc(sizeof(*par), device);
 	if (!info)
--------------2E669B8BE99B2CB50AF41101-- --===============1484109405== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1484109405==--