From: Haneen Mohammed <hamohammed.sa@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com
Subject: [PATCH 2/4] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks
Date: Mon, 9 Jul 2018 18:46:49 +0300 [thread overview]
Message-ID: <3c62d375dc439268e9ea77fb8f3d599ee927a2a6.1531149873.git.hamohammed.sa@gmail.com> (raw)
In-Reply-To: <cover.1531149873.git.hamohammed.sa@gmail.com>
This patch map/unmap GEM backing memory to kernel address space
in prepare/cleanup_fb respectively and cache the virtual address
for later use.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
drivers/gpu/drm/vkms/vkms_plane.c | 41 +++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
index f7f63143f6d0..f464eb0e05dd 100644
--- a/drivers/gpu/drm/vkms/vkms_plane.c
+++ b/drivers/gpu/drm/vkms/vkms_plane.c
@@ -9,6 +9,7 @@
#include "vkms_drv.h"
#include <drm/drm_plane_helper.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
static const struct drm_plane_funcs vkms_plane_funcs = {
.update_plane = drm_atomic_helper_update_plane,
@@ -30,9 +31,49 @@ static void vkms_primary_plane_update(struct drm_plane *plane,
{
}
+static int vkms_prepare_fb(struct drm_plane *plane,
+ struct drm_plane_state *state)
+{
+ struct drm_gem_object *gem_obj;
+ struct vkms_gem_object *vkms_obj;
+
+ if (!state->fb)
+ return 0;
+
+ gem_obj = drm_gem_fb_get_obj(state->fb, 0);
+ vkms_obj = container_of(gem_obj, struct vkms_gem_object, gem);
+ vkms_obj->vaddr = vkms_gem_vmap(gem_obj);
+
+ if (!vkms_obj->vaddr)
+ DRM_INFO("vmap failed\n");
+
+ return drm_gem_fb_prepare_fb(plane, state);
+}
+
+static void vkms_cleanup_fb(struct drm_plane *plane,
+ struct drm_plane_state *old_state)
+{
+ struct drm_gem_object *gem_obj;
+ struct vkms_gem_object *vkms_obj;
+
+ if (!old_state->fb)
+ return;
+
+ gem_obj = drm_gem_fb_get_obj(old_state->fb, 0);
+ vkms_obj = container_of(gem_obj, struct vkms_gem_object, gem);
+
+ if (vkms_obj && vkms_obj->pages) {
+ vunmap(vkms_obj->vaddr);
+ drm_gem_put_pages(gem_obj, vkms_obj->pages, false, true);
+ vkms_obj->pages = NULL;
+ }
+}
+
static const struct drm_plane_helper_funcs vkms_primary_helper_funcs = {
.atomic_check = vkms_plane_atomic_check,
.atomic_update = vkms_primary_plane_update,
+ .prepare_fb = vkms_prepare_fb,
+ .cleanup_fb = vkms_cleanup_fb,
};
struct drm_plane *vkms_plane_init(struct vkms_device *vkmsdev)
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-09 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:42 [PATCH 0/4] Add infrastructure needed for CRC support Haneen Mohammed
2018-07-09 15:44 ` [PATCH 1/4] drm/vkms: Add functions to map GEM backing storage Haneen Mohammed
2018-07-10 8:00 ` Daniel Vetter
2018-07-10 8:12 ` Chris Wilson
2018-07-10 15:12 ` Haneen Mohammed
2018-07-09 15:46 ` Haneen Mohammed [this message]
2018-07-10 8:04 ` [PATCH 2/4] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks Daniel Vetter
2018-07-09 15:47 ` [PATCH 3/4] drm/vkms: Add atomic_helper_check_plane_state Haneen Mohammed
2018-07-10 8:07 ` Daniel Vetter
2018-07-09 15:48 ` [PATCH 4/4] drm/vkms: subclass CRTC state Haneen Mohammed
2018-07-10 8:10 ` Daniel Vetter
2018-07-10 15:13 ` Haneen Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c62d375dc439268e9ea77fb8f3d599ee927a2a6.1531149873.git.hamohammed.sa@gmail.com \
--to=hamohammed.sa@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).