From: Neil Armstrong <neil.armstrong@linaro.org>
To: "Guido Günther" <agx@sigxcpu.org>,
"Jessica Zhang" <jessica.zhang@oss.qualcomm.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/panel: visionox-rm69299: Don't clear all mode flags
Date: Tue, 2 Sep 2025 09:33:25 +0200 [thread overview]
Message-ID: <3c8571cc-ab41-4231-9950-45d3e207927e@linaro.org> (raw)
In-Reply-To: <20250901-shift6mq-panel-v1-2-444b4abbfaea@sigxcpu.org>
On 01/09/2025 16:22, Guido Günther wrote:
> Don't clear all mode flags. We only want to maek sure we use HS mode
> during unprepare.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> index e65697ce6f51c7d64b786da18cf44b16de5d6919..2216d38366ea37368d15480f9d8a8ccbfe77ba3b 100644
> --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> @@ -192,7 +192,7 @@ static int visionox_rm69299_unprepare(struct drm_panel *panel)
> struct visionox_rm69299 *ctx = panel_to_ctx(panel);
> struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
>
> - ctx->dsi->mode_flags = 0;
> + ctx->dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
>
> mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
>
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2025-09-02 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 14:22 [PATCH 0/3] drm/panel: visionox-rm69299: Add backlight support and small fixes Guido Günther
2025-09-01 14:22 ` [PATCH 1/3] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq Guido Günther
2025-09-01 14:22 ` [PATCH 2/3] drm/panel: visionox-rm69299: Don't clear all mode flags Guido Günther
2025-09-02 7:33 ` Neil Armstrong [this message]
2025-09-01 14:22 ` [PATCH 3/3] drm/panel: visionox-rm69299: Add backlight support Guido Günther
2025-09-02 7:34 ` Neil Armstrong
2025-09-02 11:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c8571cc-ab41-4231-9950-45d3e207927e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).