dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"
@ 2024-02-02 22:23 Rob Herring
  2024-02-03  2:55 ` Dmitry Baryshkov
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Rob Herring @ 2024-02-02 22:23 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Daniel Vetter,
	Krzysztof Kozlowski, Conor Dooley, Neil Armstrong
  Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel

In order to check schemas for missing additionalProperties or
unevaluatedProperties, cases allowing extra properties must be explicit.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
index bd11119dc93d..24cece1e888b 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
@@ -37,18 +37,21 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         const: qcom,sm8650-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         const: qcom,sm8650-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         items:
@@ -57,6 +60,7 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         const: qcom,sm8650-dsi-phy-4nm
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"
  2024-02-02 22:23 [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties" Rob Herring
@ 2024-02-03  2:55 ` Dmitry Baryshkov
  2024-02-05 13:58   ` Rob Herring
  2024-02-05  9:23 ` Krzysztof Kozlowski
  2024-02-19 12:30 ` Dmitry Baryshkov
  2 siblings, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-02-03  2:55 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Daniel Vetter, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
	linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel

On Fri, 2 Feb 2024 at 23:23, Rob Herring <robh@kernel.org> wrote:
>
> In order to check schemas for missing additionalProperties or
> unevaluatedProperties, cases allowing extra properties must be explicit.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Rob, if you need it for some rework, please feel free to pick it into
your tree, otherwise I'll pick it for msm-next in the next few days.


> ---
>  .../devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml     | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
> index bd11119dc93d..24cece1e888b 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
> @@ -37,18 +37,21 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
>      properties:
>        compatible:
>          const: qcom,sm8650-dpu
>
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
>      properties:
>        compatible:
>          const: qcom,sm8650-dp
>
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
>      properties:
>        compatible:
>          items:
> @@ -57,6 +60,7 @@ patternProperties:
>
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
>      properties:
>        compatible:
>          const: qcom,sm8650-dsi-phy-4nm
> --
> 2.43.0
>


--
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"
  2024-02-02 22:23 [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties" Rob Herring
  2024-02-03  2:55 ` Dmitry Baryshkov
@ 2024-02-05  9:23 ` Krzysztof Kozlowski
  2024-02-19 12:30 ` Dmitry Baryshkov
  2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-05  9:23 UTC (permalink / raw)
  To: Rob Herring, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
	Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Daniel Vetter,
	Krzysztof Kozlowski, Conor Dooley, Neil Armstrong
  Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel

On 02/02/2024 23:23, Rob Herring wrote:
> In order to check schemas for missing additionalProperties or
> unevaluatedProperties, cases allowing extra properties must be explicit.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml     | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"
  2024-02-03  2:55 ` Dmitry Baryshkov
@ 2024-02-05 13:58   ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-02-05 13:58 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Daniel Vetter, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
	linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel

On Sat, Feb 03, 2024 at 03:55:54AM +0100, Dmitry Baryshkov wrote:
> On Fri, 2 Feb 2024 at 23:23, Rob Herring <robh@kernel.org> wrote:
> >
> > In order to check schemas for missing additionalProperties or
> > unevaluatedProperties, cases allowing extra properties must be explicit.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Rob, if you need it for some rework, please feel free to pick it into
> your tree, otherwise I'll pick it for msm-next in the next few days.

msm-next is fine.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"
  2024-02-02 22:23 [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties" Rob Herring
  2024-02-03  2:55 ` Dmitry Baryshkov
  2024-02-05  9:23 ` Krzysztof Kozlowski
@ 2024-02-19 12:30 ` Dmitry Baryshkov
  2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-02-19 12:30 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Daniel Vetter, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
	Rob Herring
  Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel


On Fri, 02 Feb 2024 16:23:37 -0600, Rob Herring wrote:
> In order to check schemas for missing additionalProperties or
> unevaluatedProperties, cases allowing extra properties must be explicit.
> 
> 

Applied, thanks!

[1/1] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"
      https://gitlab.freedesktop.org/lumag/msm/-/commit/4825b207002a

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-02-19 12:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 22:23 [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties" Rob Herring
2024-02-03  2:55 ` Dmitry Baryshkov
2024-02-05 13:58   ` Rob Herring
2024-02-05  9:23 ` Krzysztof Kozlowski
2024-02-19 12:30 ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).