From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 765D2EE6B6F for ; Mon, 9 Feb 2026 08:29:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D812A10E339; Mon, 9 Feb 2026 08:29:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="wusa2wa6"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NkMMrhv7"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="wusa2wa6"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NkMMrhv7"; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8A1810E339 for ; Mon, 9 Feb 2026 08:29:21 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 789543E6C7; Mon, 9 Feb 2026 08:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770625760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jtuTDxY7i+svsyCsq+GKz0aedAFlP9eKwiSdAJ63xQQ=; b=wusa2wa6Z2UOWVvigQCwABDu40yx/OEwLgUTNnP4yMHfP545JdD8vuUNktUOjwFvHacXF7 d/UhsM+f5zqPFayhf/bipdinSKnpHNVWieZ+bcrHLIgxyvynqaqKkvg6jOfGtlD5fPBdL2 Pn8vU7aVDodAYOdGmXC/75D3jFoLsSU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770625760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jtuTDxY7i+svsyCsq+GKz0aedAFlP9eKwiSdAJ63xQQ=; b=NkMMrhv7wLoZOd3p+nYcn/H8eNjZkN1b5R7kVITWmQU59THhcchzisN/8gcbZFc53itdyl /srsJaMFcK+ZU4Bg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wusa2wa6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NkMMrhv7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770625760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jtuTDxY7i+svsyCsq+GKz0aedAFlP9eKwiSdAJ63xQQ=; b=wusa2wa6Z2UOWVvigQCwABDu40yx/OEwLgUTNnP4yMHfP545JdD8vuUNktUOjwFvHacXF7 d/UhsM+f5zqPFayhf/bipdinSKnpHNVWieZ+bcrHLIgxyvynqaqKkvg6jOfGtlD5fPBdL2 Pn8vU7aVDodAYOdGmXC/75D3jFoLsSU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770625760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jtuTDxY7i+svsyCsq+GKz0aedAFlP9eKwiSdAJ63xQQ=; b=NkMMrhv7wLoZOd3p+nYcn/H8eNjZkN1b5R7kVITWmQU59THhcchzisN/8gcbZFc53itdyl /srsJaMFcK+ZU4Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 406063EA63; Mon, 9 Feb 2026 08:29:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2HpJDuCaiWnTNgAAD6G6ig (envelope-from ); Mon, 09 Feb 2026 08:29:20 +0000 Message-ID: <3d62d7de-692b-43fc-9f58-ce79b8d0f4ee@suse.de> Date: Mon, 9 Feb 2026 09:29:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/15] drm/atomic: Add new atomic_create_state callback to drm_private_obj To: Maxime Ripard , Maarten Lankhorst , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Dmitry Baryshkov References: <20260128-drm-private-obj-reset-v4-0-90891fa3d3b0@redhat.com> <20260128-drm-private-obj-reset-v4-2-90891fa3d3b0@redhat.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260128-drm-private-obj-reset-v4-2-90891fa3d3b0@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[kernel.org,linux.intel.com,gmail.com,ffwll.ch]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; URIBL_BLOCKED(0.00)[qualcomm.com:email,suse.de:dkim,suse.de:mid,suse.de:email,suse.com:url,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.com:url, qualcomm.com:email] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 789543E6C7 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 28.01.26 um 13:43 schrieb Maxime Ripard: > The drm_private_obj initialization was inconsistent with the rest of the > KMS objects. Indeed, it required to pass a preallocated state in > drm_private_obj_init(), while all the others objects would have a reset > callback that would be called later on to create the state. > > However, reset really is meant to reset the hardware and software state. > That it creates an initial state is a side-effect that has been used in > all objects but drm_private_obj. This is made more complex since some > drm_private_obj, the DisplayPort ones in particular, need to be > persistent across and suspend/resume cycle, and such a cycle would call > drm_mode_config_reset(). > > Thus, we need to add a new callback to allocate a pristine state for a > given private object. > > This discussion has also came up during the atomic state readout > discussion, so it might be introduced into the other objects later on. > > Until all drivers are converted to that new allocation pattern, we will > only call it if the passed state is NULL. This will be removed > eventually. > > Signed-off-by: Maxime Ripard > Reviewed-by: Dmitry Baryshkov Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_atomic.c | 18 ++++++++++++++++-- > include/drm/drm_atomic.h | 13 +++++++++++++ > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 4191a8333fc4ebdfc10f664c837a3f1693eff022..e3029c8f02e5a3698781117bcc80eff98407cf16 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -939,15 +939,29 @@ int drm_atomic_private_obj_init(struct drm_device *dev, > memset(obj, 0, sizeof(*obj)); > > drm_modeset_lock_init(&obj->lock); > > obj->dev = dev; > - obj->state = state; > obj->funcs = funcs; > list_add_tail(&obj->head, &dev->mode_config.privobj_list); > > - state->obj = obj; > + /* > + * Not all users of drm_atomic_private_obj_init have been > + * converted to using &drm_private_obj_funcs.atomic_create_state yet. > + * For the time being, let's only call reset if the passed state is > + * NULL. Otherwise, we will fallback to the previous behaviour. > + */ > + if (!state) { > + state = obj->funcs->atomic_create_state(obj); > + if (IS_ERR(state)) > + return PTR_ERR(state); > + > + obj->state = state; > + } else { > + obj->state = state; > + state->obj = obj; > + } > > return 0; > } > EXPORT_SYMBOL(drm_atomic_private_obj_init); > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index 712f5fb977bff8a15592a3949444d9ac306e6c54..0b1b32bcd2bda1b92299fd369ba7c23b1c2d3dfa 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -259,10 +259,23 @@ struct drm_private_state; > * added to the atomic states is expected to have an implementation of these > * hooks and pass a pointer to its drm_private_state_funcs struct to > * drm_atomic_get_private_obj_state(). > */ > struct drm_private_state_funcs { > + /** > + * @atomic_create_state: > + * > + * Allocates a pristine, initialized, state for the private > + * object and returns it. > + * > + * RETURNS: > + * > + * A new, pristine, private state instance or an error pointer > + * on failure. > + */ > + struct drm_private_state *(*atomic_create_state)(struct drm_private_obj *obj); > + > /** > * @atomic_duplicate_state: > * > * Duplicate the current state of the private object and return it. It > * is an error to call this before obj->state has been initialized. > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)