dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Francois Dugast <francois.dugast@intel.com>
Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] drm/gem: fix build for mm_get_unmapped_area() call after backmerge
Date: Mon, 15 Dec 2025 12:40:07 +0200	[thread overview]
Message-ID: <3d78a20a6960e69cbb477ab366e82b8c1567b1e6@intel.com> (raw)
In-Reply-To: <aT_Wn63528lO8fOu@fdugast-desk>

On Mon, 15 Dec 2025, Francois Dugast <francois.dugast@intel.com> wrote:
> On Mon, Dec 15, 2025 at 11:27:06AM +0200, Jani Nikula wrote:
>> Commit 9ac09bb9feac ("mm: consistently use current->mm in
>> mm_get_unmapped_area()") upstream dropped a parameter from
>> mm_get_unmapped_area() while commit 99bda20d6d4c ("drm/gem: Introduce
>> drm_gem_get_unmapped_area() fop") in drm-misc-next added a new user.
>> 
>> Drop the extra parameter from the call.
>> 
>> Fixes: 7f790dd21a93 ("Merge drm/drm-next into drm-misc-next")
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Francois Dugast <francois.dugast@intel.com>

Thanks, pushed to drm-misc-next.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/drm_gem.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index bcc08a6aebf8..28d6792112be 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -1303,8 +1303,7 @@ unsigned long drm_gem_get_unmapped_area(struct file *filp, unsigned long uaddr,
>>  
>>  	obj = drm_gem_object_lookup_at_offset(filp, pgoff, len >> PAGE_SHIFT);
>>  	if (IS_ERR(obj) || !obj->filp || !obj->filp->f_op->get_unmapped_area)
>> -		return mm_get_unmapped_area(current->mm, filp, uaddr, len, 0,
>> -					    flags);
>> +		return mm_get_unmapped_area(filp, uaddr, len, 0, flags);
>>  
>>  	ret = obj->filp->f_op->get_unmapped_area(obj->filp, uaddr, len, 0,
>>  						 flags);
>> -- 
>> 2.47.3
>> 

-- 
Jani Nikula, Intel

  reply	other threads:[~2025-12-15 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15  9:27 [PATCH] drm/gem: fix build for mm_get_unmapped_area() call after backmerge Jani Nikula
2025-12-15  9:36 ` Francois Dugast
2025-12-15 10:40   ` Jani Nikula [this message]
2025-12-15  9:50 ` Nilawar, Badal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d78a20a6960e69cbb477ab366e82b8c1567b1e6@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).