From: "Christian König" <christian.koenig@amd.com>
To: Nayan Deshmukh <nayan26deshmukh@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/scheduler: fix param documentation
Date: Mon, 26 Mar 2018 18:57:30 +0200 [thread overview]
Message-ID: <3f0f3e2e-0e8c-0403-3235-0a2f710b1bd2@amd.com> (raw)
In-Reply-To: <20180326152114.24948-1-nayan26deshmukh@gmail.com>
A bit more commit message would be nice to have, like "There is no more
@kernel parameter and document the new @guilty parameter".
Am 26.03.2018 um 17:21 schrieb Nayan Deshmukh:
> Signed-off-by: Nayan Deshmukh <nayan26deshmukh@gmail.com>
With the commit message fixed the patch is Reviewed-by: Christian König
<christian.koenig@amd.com>.
Christian.
> ---
> drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> index 0d95888ccc3e..1d368bc66ac2 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
> * @sched The pointer to the scheduler
> * @entity The pointer to a valid drm_sched_entity
> * @rq The run queue this entity belongs
> - * @kernel If this is an entity for the kernel
> * @jobs The max number of jobs in the job queue
> + * @guilty atomic_t set to 1 when a job on this queue
> + * is found to be guilty causing a timeout
> *
> * return 0 if succeed. negative error code on failure
> */
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-26 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 11:09 [PATCH] drm/scheduler: remove incorrect param documentation Nayan Deshmukh
2018-03-25 11:14 ` Christian König
2018-03-25 11:21 ` Nayan Deshmukh
2018-03-25 11:29 ` Christian König
2018-03-26 15:21 ` [PATCH] drm/scheduler: fix " Nayan Deshmukh
2018-03-26 16:57 ` Christian König [this message]
2018-03-26 17:16 ` Nayan Deshmukh
2018-03-27 8:17 ` Daniel Vetter
2018-03-27 17:29 ` Nayan Deshmukh
2018-03-29 15:26 ` Alex Deucher
2018-03-29 17:08 ` Nayan Deshmukh
2018-03-26 15:29 ` [PATCH] drm/scheduler: remove incorrect " Nayan Deshmukh
2018-03-26 16:59 ` Christian König
2018-03-26 17:04 ` Nayan Deshmukh
-- strict thread matches above, loose matches on Subject: below --
2018-08-09 9:48 [PATCH] drm/scheduler: fix " Nayan Deshmukh
2018-08-09 14:15 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f0f3e2e-0e8c-0403-3235-0a2f710b1bd2@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nayan26deshmukh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox