From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH v2 2/5] video: smscufx: Less checks in ufx_usb_probe() after error detection Date: Sun, 26 Nov 2017 08:38:49 +0100 Message-ID: <3f66c1b1-bf12-94ed-4dc9-34094c0d5816@users.sourceforge.net> References: <73df7ce0-c4b0-aec7-ee7e-74f55a0fe708@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.web.de (mout.web.de [212.227.15.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6072D6E06E for ; Sun, 26 Nov 2017 07:39:47 +0000 (UTC) In-Reply-To: <73df7ce0-c4b0-aec7-ee7e-74f55a0fe708@users.sourceforge.net> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Steve Glendinning Cc: kernel-janitors@vger.kernel.org, LKML List-Id: dri-devel@lists.freedesktop.org RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgpEYXRl OiBTdW4sIDI2IE5vdiAyMDE3IDA4OjE4OjIwICswMTAwCgpVcCB0byBmb3VyIGNoZWNrcyBjb3Vs ZCBiZSByZXBlYXRlZCBieSB0aGUgdWZ4X3VzYl9wcm9iZSgpIGZ1bmN0aW9uCmR1cmluZyBlcnJv ciBoYW5kbGluZyBldmVuIGlmIHRoZSByZWxldmFudCBwcm9wZXJ0aWVzIGNhbiBiZSBkZXRlcm1p bmVkCmZvciB0aGUgaW52b2x2ZWQgdmFyaWFibGVzIGJlZm9yZSBieSBzb3VyY2UgY29kZSBhbmFs eXNpcy4KCiogUmV0dXJuIGRpcmVjdGx5IGFmdGVyIGEgY2FsbCBvZiB0aGUgZnVuY3Rpb24gImt6 YWxsb2MiIGZhaWxlZAogIGF0IHRoZSBiZWdpbm5pbmcuCgoqIEFkanVzdCBqdW1wIHRhcmdldHMg c28gdGhhdCBleHRyYSBjaGVja3MgY2FuIGJlIG9taXR0ZWQgYXQgdGhlIGVuZC4KCiogRGVsZXRl IGluaXRpYWxpc2F0aW9ucyBmb3IgdGhlIHZhcmlhYmxlcyAiaW5mbyIgYW5kICJyZXR2YWwiCiAg d2hpY2ggYmVjYW1lIHVubmVjZXNzYXJ5IHdpdGggdGhpcyByZWZhY3RvcmluZy4KClNpZ25lZC1v ZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4KLS0t Cgp2MjoKQSBjYWxsIG9mIHRoZSBmdW5jdGlvbiAiZmJfZGVhbGxvY19jbWFwIiB3YXMgcHJlc2Vy dmVkIGZvciB0aGUgZXhjZXB0aW9uCmhhbmRsaW5nIGF0IHRoZSBlbmQuCgogZHJpdmVycy92aWRl by9mYmRldi9zbXNjdWZ4LmMgfCA0NiArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMjcgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi9zbXNjdWZ4LmMgYi9kcml2ZXJz L3ZpZGVvL2ZiZGV2L3Ntc2N1ZnguYwppbmRleCAzMmRlMDdkNzcxODQuLmE0OGEyZGVjM2Y1ZSAx MDA2NDQKLS0tIGEvZHJpdmVycy92aWRlby9mYmRldi9zbXNjdWZ4LmMKKysrIGIvZHJpdmVycy92 aWRlby9mYmRldi9zbXNjdWZ4LmMKQEAgLTE2MTksOCArMTYxOSw4IEBAIHN0YXRpYyBpbnQgdWZ4 X3VzYl9wcm9iZShzdHJ1Y3QgdXNiX2ludGVyZmFjZSAqaW50ZXJmYWNlLAogewogCXN0cnVjdCB1 c2JfZGV2aWNlICp1c2JkZXY7CiAJc3RydWN0IHVmeF9kYXRhICpkZXY7Ci0Jc3RydWN0IGZiX2lu Zm8gKmluZm8gPSBOVUxMOwotCWludCByZXR2YWwgPSAtRU5PTUVNOworCXN0cnVjdCBmYl9pbmZv ICppbmZvOworCWludCByZXR2YWw7CiAJdTMyIGlkX3JldiwgZnBnYV9yZXY7CiAKIAkvKiB1c2Ig aW5pdGlhbGl6YXRpb24gKi8KQEAgLTE2MjksNyArMTYyOSw3IEBAIHN0YXRpYyBpbnQgdWZ4X3Vz Yl9wcm9iZShzdHJ1Y3QgdXNiX2ludGVyZmFjZSAqaW50ZXJmYWNlLAogCiAJZGV2ID0ga3phbGxv YyhzaXplb2YoKmRldiksIEdGUF9LRVJORUwpOwogCWlmICghZGV2KQotCQlnb3RvIGVycm9yOwor CQlyZXR1cm4gLUVOT01FTTsKIAogCS8qIHdlIG5lZWQgdG8gd2FpdCBmb3IgYm90aCB1c2IgYW5k IGZiZGV2IHRvIHNwaW4gZG93biBvbiBkaXNjb25uZWN0ICovCiAJa3JlZl9pbml0KCZkZXYtPmty ZWYpOyAvKiBtYXRjaGluZyBrcmVmX3B1dCBpbiB1c2IgLmRpc2Nvbm5lY3QgZm4gKi8KQEAgLTE2 NDksOSArMTY0OSw4IEBAIHN0YXRpYyBpbnQgdWZ4X3VzYl9wcm9iZShzdHJ1Y3QgdXNiX2ludGVy ZmFjZSAqaW50ZXJmYWNlLAogCWRldl9kYmcoZGV2LT5nZGV2LCAiZmJfZGVmaW8gZW5hYmxlPSVk XG4iLCBmYl9kZWZpbyk7CiAKIAlpZiAoIXVmeF9hbGxvY191cmJfbGlzdChkZXYsIFdSSVRFU19J Tl9GTElHSFQsIE1BWF9UUkFOU0ZFUikpIHsKLQkJcmV0dmFsID0gLUVOT01FTTsKIAkJZGV2X2Vy cihkZXYtPmdkZXYsICJ1ZnhfYWxsb2NfdXJiX2xpc3QgZmFpbGVkXG4iKTsKLQkJZ290byBlcnJv cjsKKwkJZ290byBlX25vbWVtOwogCX0KIAogCS8qIFdlIGRvbid0IHJlZ2lzdGVyIGEgbmV3IFVT QiBjbGFzcy4gT3VyIGNsaWVudCBpbnRlcmZhY2UgaXMgZmJkZXYgKi8KQEAgLTE2NTksOSArMTY1 OCw4IEBAIHN0YXRpYyBpbnQgdWZ4X3VzYl9wcm9iZShzdHJ1Y3QgdXNiX2ludGVyZmFjZSAqaW50 ZXJmYWNlLAogCS8qIGFsbG9jYXRlcyBmcmFtZWJ1ZmZlciBkcml2ZXIgc3RydWN0dXJlLCBub3Qg ZnJhbWVidWZmZXIgbWVtb3J5ICovCiAJaW5mbyA9IGZyYW1lYnVmZmVyX2FsbG9jKDAsICZ1c2Jk ZXYtPmRldik7CiAJaWYgKCFpbmZvKSB7Ci0JCXJldHZhbCA9IC1FTk9NRU07CiAJCWRldl9lcnIo ZGV2LT5nZGV2LCAiZnJhbWVidWZmZXJfYWxsb2MgZmFpbGVkXG4iKTsKLQkJZ290byBlcnJvcjsK KwkJZ290byBlX25vbWVtOwogCX0KIAogCWRldi0+aW5mbyA9IGluZm87CkBAIC0xNjcyLDcgKzE2 NzAsNyBAQCBzdGF0aWMgaW50IHVmeF91c2JfcHJvYmUoc3RydWN0IHVzYl9pbnRlcmZhY2UgKmlu dGVyZmFjZSwKIAlyZXR2YWwgPSBmYl9hbGxvY19jbWFwKCZpbmZvLT5jbWFwLCAyNTYsIDApOwog CWlmIChyZXR2YWwgPCAwKSB7CiAJCWRldl9lcnIoZGV2LT5nZGV2LCAiZmJfYWxsb2NfY21hcCBm YWlsZWQgJXhcbiIsIHJldHZhbCk7Ci0JCWdvdG8gZXJyb3I7CisJCWdvdG8gZGVzdHJveV9tb2Rl ZGI7CiAJfQogCiAJSU5JVF9ERUxBWUVEX1dPUksoJmRldi0+ZnJlZV9mcmFtZWJ1ZmZlcl93b3Jr LApAQCAtMTczMywyNiArMTczMSwyMCBAQCBzdGF0aWMgaW50IHVmeF91c2JfcHJvYmUoc3RydWN0 IHVzYl9pbnRlcmZhY2UgKmludGVyZmFjZSwKIAlyZXR1cm4gMDsKIAogZXJyb3I6Ci0JaWYgKGRl dikgewotCQlpZiAoaW5mbykgewotCQkJaWYgKGluZm8tPmNtYXAubGVuICE9IDApCi0JCQkJZmJf ZGVhbGxvY19jbWFwKCZpbmZvLT5jbWFwKTsKLQkJCWlmIChpbmZvLT5tb25zcGVjcy5tb2RlZGIp Ci0JCQkJZmJfZGVzdHJveV9tb2RlZGIoaW5mby0+bW9uc3BlY3MubW9kZWRiKTsKLQkJCXZmcmVl KGluZm8tPnNjcmVlbl9iYXNlKTsKLQotCQkJZmJfZGVzdHJveV9tb2RlbGlzdCgmaW5mby0+bW9k ZWxpc3QpOwotCi0JCQlmcmFtZWJ1ZmZlcl9yZWxlYXNlKGluZm8pOwotCQl9Ci0KLQkJa3JlZl9w dXQoJmRldi0+a3JlZiwgdWZ4X2ZyZWUpOyAvKiByZWYgZm9yIGZyYW1lYnVmZmVyICovCi0JCWty ZWZfcHV0KCZkZXYtPmtyZWYsIHVmeF9mcmVlKTsgLyogbGFzdCByZWYgZnJvbSBrcmVmX2luaXQg Ki8KLQotCQkvKiBkZXYgaGFzIGJlZW4gZGVhbGxvY2F0ZWQuIERvIG5vdCBkZXJlZmVyZW5jZSAq LwotCX0KLQorCWZiX2RlYWxsb2NfY21hcCgmaW5mby0+Y21hcCk7CitkZXN0cm95X21vZGVkYjoK KwlmYl9kZXN0cm95X21vZGVkYihpbmZvLT5tb25zcGVjcy5tb2RlZGIpOworCXZmcmVlKGluZm8t PnNjcmVlbl9iYXNlKTsKKwlmYl9kZXN0cm95X21vZGVsaXN0KCZpbmZvLT5tb2RlbGlzdCk7CisJ ZnJhbWVidWZmZXJfcmVsZWFzZShpbmZvKTsKK3B1dF9yZWY6CisJa3JlZl9wdXQoJmRldi0+a3Jl ZiwgdWZ4X2ZyZWUpOyAvKiByZWYgZm9yIGZyYW1lYnVmZmVyICovCisJa3JlZl9wdXQoJmRldi0+ a3JlZiwgdWZ4X2ZyZWUpOyAvKiBsYXN0IHJlZiBmcm9tIGtyZWZfaW5pdCAqLwogCXJldHVybiBy ZXR2YWw7CisKK2Vfbm9tZW06CisJcmV0dmFsID0gLUVOT01FTTsKKwlnb3RvIHB1dF9yZWY7CiB9 CiAKIHN0YXRpYyB2b2lkIHVmeF91c2JfZGlzY29ubmVjdChzdHJ1Y3QgdXNiX2ludGVyZmFjZSAq aW50ZXJmYWNlKQotLSAKMi4xNS4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK