From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E74B2CAC5BB for ; Wed, 1 Oct 2025 07:51:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51A4A10E6A3; Wed, 1 Oct 2025 07:51:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZT1WoixW"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02E0710E69C for ; Wed, 1 Oct 2025 07:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759305067; x=1790841067; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0OY0NcjVCVKMaDSgV+18argZn0XvRbHmjxQNkDCy5U0=; b=ZT1WoixWly9Y0buhPL/IcLSvDIPnzrDFnDhM0RT3ML1CqWDjtevrO7/p wD75x6WXQVG1bOmzD74Pj8hUT1LaCKasVsNDt72CwqFHFs3oHEkYmanps 2a5Vnd8cZtBxJrFc3oRZqH0ijTZRLHuyi+cmqkx7KQdt9+PyEro5JxwFz xH/K6qQFvBuP00yKF4ndm4EZM3gZvF4js8Nz04lipI45jSUT4h07k5FUg mSJS48UjAEUyMi1NEu1oSkwZcpFCPBQff06lczREFaDLyx3gIQWoERPYb yLzYtqOqvSJYlk/FONVi4nEWqY/s2Ky5aekcqdyevV4jm35BoHB85NLD8 Q==; X-CSE-ConnectionGUID: 1sjXaPDHR3KBlC/dUm1i8Q== X-CSE-MsgGUID: 5AJ6Dgj1Tpq0y3X3452qJg== X-IronPort-AV: E=McAfee;i="6800,10657,11569"; a="79222448" X-IronPort-AV: E=Sophos;i="6.18,306,1751266800"; d="scan'208";a="79222448" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2025 00:51:07 -0700 X-CSE-ConnectionGUID: yYXWExz9Q0qCnlEzrMhlsA== X-CSE-MsgGUID: aZcNzq3qRE6VeQIuoDOWYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,306,1751266800"; d="scan'208";a="182748793" Received: from unknown (HELO [10.102.88.152]) ([10.102.88.152]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2025 00:51:05 -0700 Message-ID: <3fa5c368-726e-42f7-9900-cdbe3189a57c@linux.intel.com> Date: Wed, 1 Oct 2025 09:51:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] accel/ivpu: Improve BO alloc/free warnings To: Maciej Falkowski , dri-devel@lists.freedesktop.org Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com, lizhi.hou@amd.com, Jacek Lawrynowicz References: <20250925145154.1446427-1-maciej.falkowski@linux.intel.com> Content-Language: en-US From: Karol Wachowski Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20250925145154.1446427-1-maciej.falkowski@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Reviewed-by: Karol Wachowski On 9/25/2025 4:51 PM, Maciej Falkowski wrote: > From: Jacek Lawrynowicz > > Add additional warnings related to allocation and > deallocation of buffer objects to better track possible > memory leaks and generally the BO's lifecycle. > > Introduce checks for handle_count to ensure it is zero > before creating a new handle, and exactly one > after successfully creating a handle. > > Introduce also a check to warn if the VMA node is not > empty when freeing the buffer object. > > Signed-off-by: Jacek Lawrynowicz > Signed-off-by: Maciej Falkowski > --- > drivers/accel/ivpu/ivpu_gem.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c > index 38ecf933d144..e9830ad48d4b 100644 > --- a/drivers/accel/ivpu/ivpu_gem.c > +++ b/drivers/accel/ivpu/ivpu_gem.c > @@ -332,6 +332,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj) > drm_WARN_ON(&vdev->drm, bo->ctx); > > drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1); > + drm_WARN_ON(obj->dev, bo->base.base.vma_node.vm_files.rb_node); > drm_gem_shmem_free(&bo->base); > } > > @@ -370,12 +371,16 @@ int ivpu_bo_create_ioctl(struct drm_device *dev, void *data, struct drm_file *fi > return PTR_ERR(bo); > } > > + drm_WARN_ON(&vdev->drm, bo->base.base.handle_count != 0); > + > ret = drm_gem_handle_create(file, &bo->base.base, &args->handle); > - if (ret) > + if (ret) { > ivpu_err(vdev, "Failed to create handle for BO: %pe (ctx %u size %llu flags 0x%x)", > bo, file_priv->ctx.id, args->size, args->flags); > - else > + } else { > args->vpu_addr = bo->vpu_addr; > + drm_WARN_ON(&vdev->drm, bo->base.base.handle_count != 1); > + } > > drm_gem_object_put(&bo->base.base); >