From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mihail Atanassov Subject: Re: drm/komeda: Don't flush inactive pipes Date: Mon, 21 Oct 2019 14:03:48 +0000 Message-ID: <4038026.EQVCqvRzMf@e123338-lin> References: <20191010102950.56253-1-mihail.atanassov@arm.com> <20191016082117.GA18601@jamwan02-TSP300> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20191016082117.GA18601@jamwan02-TSP300> Content-Language: en-US Content-ID: <0533DF58170BF348BE6D64481660898F@eurprd08.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: "james qian wang (Arm Technology China)" Cc: "dri-devel@lists.freedesktop.org" , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , nd List-Id: dri-devel@lists.freedesktop.org On Wednesday, 16 October 2019 09:21:24 BST james qian wang (Arm Technology = China) wrote: > On Thu, Oct 10, 2019 at 10:30:07AM +0000, Mihail Atanassov wrote: > > HW doesn't allow flushing inactive pipes and raises an MERR interrupt > > if you try to do so. Stop triggering the MERR interrupt in the > > middle of a commit by calling drm_atomic_helper_commit_planes > > with the ACTIVE_ONLY flag. > >=20 > > Signed-off-by: Mihail Atanassov > > --- > > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/= gpu/drm/arm/display/komeda/komeda_kms.c > > index 8820ce15ce37..ae274902ff92 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > > @@ -82,7 +82,8 @@ static void komeda_kms_commit_tail(struct drm_atomic_= state *old_state) > > =20 > > drm_atomic_helper_commit_modeset_disables(dev, old_state); > > =20 > > - drm_atomic_helper_commit_planes(dev, old_state, 0); > > + drm_atomic_helper_commit_planes(dev, old_state, > > + DRM_PLANE_COMMIT_ACTIVE_ONLY); > > >=20 > Looks good to me. > Reviewed-by: James Qian Wang (Arm Technology China) Thanks for the review, applied to drm-misc-fixes - b88639b8e3808c948169af390bd7e84e909bde8d. >=20 > > drm_atomic_helper_commit_modeset_enables(dev, old_state); > > =20 >=20 --=20 Mihail