From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E066C433ED for ; Wed, 19 May 2021 03:41:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28A38600D4 for ; Wed, 19 May 2021 03:41:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28A38600D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E83D86E188; Wed, 19 May 2021 03:41:51 +0000 (UTC) Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 654A36E188 for ; Wed, 19 May 2021 03:41:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1621395710; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=WqoS9E4WNEnuTzuu8mBefr5gA3kuqZaXEvJiKfOXllI=; b=D9BZwaYc/08lq9hwzYXZqydWo4zw78VQMGipIzJUaiwsGMFDReDURhbU1MBxOiEOadedMZev tg9ypT66Vr50jPjIS+OFnfVPilxN+cBKlfxS6ncsD6+IX201eBrcWvZ3p/lfRNmaHrgxuFnj bFzQs5lfxmz6vEeOMc08BKzVv8w= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60a488f62bff04e53b6e38a7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 19 May 2021 03:41:42 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B6959C4323A; Wed, 19 May 2021 03:41:42 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id EA3C2C433F1; Wed, 19 May 2021 03:41:41 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 18 May 2021 20:41:41 -0700 From: abhinavk@codeaurora.org To: Bjorn Andersson Subject: Re: [Freedreno] [PATCH 0/4] drm/msm/dp: Add support for SC8180x eDP controller In-Reply-To: <20210511042043.592802-1-bjorn.andersson@linaro.org> References: <20210511042043.592802-1-bjorn.andersson@linaro.org> Message-ID: <40f6aefd3fa341e2bec2060106389be7@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Tanmay Shah , Stephen Boyd , dri-devel@lists.freedesktop.org, Dmitry Baryshkov , sbillaka@codeaurora.org, Sean Paul , Chandan Uddaraju Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Bjorn I had a quick glance on the series and before getting to other things wanted to know how you are initializing two different connectors for DP & EDP resp. The connector type for DP should be DRM_MODE_CONNECTOR_DisplayPort and eDP should be DRM_MODE_CONNECTOR_eDP. We need both to be created so that both EDP and DP can be supported concurrently. Will these changes work for concurrent eDP and DP case? Thanks Abhinav On 2021-05-10 21:20, Bjorn Andersson wrote: > The first patch in the series is somewhat unrelated to the support, but > simplifies reasoning and debugging of timing related issues. > > The second patch introduces support for dealing with different register > block > layouts, which is used in the forth patch to describe the hardware > blocks found > in the SC8180x eDP block. > > The third patch configures the INTF_CONFIG register, which carries the > configuration for widebus handling. As with the DPU the bootloader > enables > widebus and we need to disable it, or implement support for adjusting > the > timing. > > Bjorn Andersson (4): > drm/msm/dp: Simplify the mvid/nvid calculation > drm/msm/dp: Store each subblock in the io region > drm/msm/dp: Initialize the INTF_CONFIG register > drm/msm/dp: Add support for SC8180x eDP > > drivers/gpu/drm/msm/dp/dp_catalog.c | 99 +++++++---------------------- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > drivers/gpu/drm/msm/dp/dp_parser.c | 22 +++++++ > drivers/gpu/drm/msm/dp/dp_parser.h | 8 +++ > 4 files changed, 53 insertions(+), 77 deletions(-)