dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Chanho Park <chanho61.park@samsung.com>,
	inki.dae@samsung.com, kgene.kim@samsung.com,
	dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com,
	mark.rutland@arm.com, l.stach@pengutronix.de,
	s.nawrocki@samsung.com, tomasz.figa@gmail.com,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Thomas Abraham <thomas.abraham@linaro.org>,
	ian.campbell@citrix.com, rob.herring@calxeda.com,
	pawel.moll@arm.com
Subject: Re: [PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator
Date: Fri, 09 Aug 2013 19:05:18 +0200	[thread overview]
Message-ID: <4138489.peCz4QHBct@amdc1227> (raw)
In-Reply-To: <52051B06.7000209@wwwdotorg.org>

On Friday 09 of August 2013 10:38:30 Stephen Warren wrote:
> On 08/09/2013 07:15 AM, Tomasz Figa wrote:
> > Hi Chanho,
> > 
> > On Friday 09 of August 2013 16:40:53 Chanho Park wrote:
> >> This patch describes each nodes of rotator and specifies a example how
> >> to bind it.
> >> 
> >> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> >> 
> >> +* Samsung Image Rotator
> >> +
> >> +Required properties:
> >> +  - compatible : value should be following:
> >> +	(a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210
> >> +	(b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412
> >> +	(c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250
> 
> Is "rotator" the name that the HW documentation uses to refer to this
> block?

Yes, it is. More specifically it is referred to as "Image Rotator".

Best regards,
Tomasz

> If so, those compatible values seem fine. If not, they seem
> slightly too generic for me; perhaps better to use the raw HW block name?

  reply	other threads:[~2013-08-09 17:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  7:40 [PATCHv2 0/5] device tree support for exynos rotator Chanho Park
2013-08-09  7:40 ` [PATCHv2 1/5] drm/exynos: add device tree support for rotator Chanho Park
2013-08-09  9:48   ` Sachin Kamat
2013-08-09 10:29     ` Chanho Park
2013-08-09 12:50   ` Tomasz Figa
2013-08-12  2:48     ` Chanho Park
2013-08-09  7:40 ` [PATCHv2 2/5] ARM: dts: Add rotator node for exynos4210 Chanho Park
2013-08-09 12:56   ` Tomasz Figa
2013-08-12  2:51     ` Chanho Park
2013-08-09  7:40 ` [PATCHv2 3/5] ARM: dts: Add rotator node for exynos4x12 Chanho Park
2013-08-09  7:40 ` [PATCHv2 4/5] ARM: dts: Add rotator node for exynos5250 Chanho Park
2013-08-09  7:40 ` [PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator Chanho Park
2013-08-09  9:40   ` Sachin Kamat
2013-08-09 10:22     ` Chanho Park
2013-08-09 13:15   ` Tomasz Figa
2013-08-09 16:38     ` Stephen Warren
2013-08-09 17:05       ` Tomasz Figa [this message]
2013-08-12  2:58     ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4138489.peCz4QHBct@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ian.campbell@citrix.com \
    --cc=inki.dae@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=s.nawrocki@samsung.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thomas.abraham@linaro.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox