From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Kuehling Subject: Re: [PATCH] drm/amdkfd: Fix potential NULL pointer dereferences Date: Wed, 10 Jan 2018 17:26:05 -0500 Message-ID: <413c85ee-aca0-fd86-4792-0d620b9251e2@amd.com> References: <20180110165008.GA10691@embeddedor.com> <20180110155849.Horde.DDGbi3ysasL2eHmvZ4k8adb@gator4166.hostgator.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0086.outbound.protection.outlook.com [104.47.40.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6455789D87 for ; Wed, 10 Jan 2018 22:26:10 +0000 (UTC) In-Reply-To: <20180110155849.Horde.DDGbi3ysasL2eHmvZ4k8adb@gator4166.hostgator.com> Content-Language: en-CA List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: dri-devel@lists.freedesktop.org WWVhaCwgdGhpcyBsb29rcyBnb29kIHRvIG1lLgoKUmVnYXJkcywKwqAgRmVsaXgKCgpPbiAyMDE4 LTAxLTEwIDA0OjU4IFBNLCBHdXN0YXZvIEEuIFIuIFNpbHZhIHdyb3RlOgo+IEhpIEZlbGl4LAo+ Cj4gUXVvdGluZyBGZWxpeCBLdWVobGluZyA8ZmVsaXgua3VlaGxpbmdAYW1kLmNvbT46Cj4KPj4g SGkgR3VzdGF2bywKPj4KPj4gVGhhbmtzIGZvciBjYXRjaGluZyB0aGF0LiBXaGVuIHJldHVybmlu ZyBhIGZhdWx0LCBJIHRoaW5rIHlvdSBhbHNvIG5lZWQKPj4gdG8gc3JjdV9yZWFkX3VubG9jaygm a2ZkX3Byb2Nlc3Nlc19zcmN1LCBpZHgpLgo+Pgo+PiBIb3dldmVyLCBpbnN0ZWFkIG9mIHJldHVy bmluZyBhbiBlcnJvciwgSSB0aGluayBJJ2QgcHJlZmVyIHRvIHNraXAgUEREcwo+PiB0aGF0IGNh bid0IGJlIGZvdW5kIHdpdGggY29udGludWUgc3RhdGVtZW50cy4gVGhhdCB3YXkgb3RoZXJzIHdv dWxkCj4+IHN0aWxsIHN1c3BlbmQgYW5kIHJlc3VtZSBzdWNjZXNzZnVsbHkuIE1heWJlIGp1c3Qg cHJpbnQgYSBXQVJOX09OIGZvcgo+PiBQRERzIHRoYXQgYXJlbid0IGZvdW5kLCBiZWNhdXNlIHRo YXQncyBhbiB1bmV4cGVjdGVkIHNpdHVhdGlvbiwKPj4gY3VycmVudGx5LiBNYXliZSBpbiB0aGUg ZnV0dXJlIGl0IGNvdWxkIGJlIG5vcm1hbCB0aGluZyBpZiB3ZSBldmVyCj4+IHN1cHBvcnQgR1BV IGhvdHBsdWcuCj4+Cj4KPiBJIGdvdCBpdC4gSW4gdGhhdCBjYXNlLCB3aGF0IGRvIHlvdSB0aGlu ayBhYm91dCB0aGUgZm9sbG93aW5nIHBhdGNoCj4gaW5zdGVhZD8KPgo+IGluZGV4IGEyMmZiMDcx Li40ZmY1ZjBmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9w cm9jZXNzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfcHJvY2Vzcy5j Cj4gQEAgLTQ2MSw3ICs0NjEsOCBAQCBpbnQga2ZkX2JpbmRfcHJvY2Vzc2VzX3RvX2RldmljZShz dHJ1Y3Qga2ZkX2RldiAqZGV2KQo+IMKgwqDCoMKgwqDCoMKgIGhhc2hfZm9yX2VhY2hfcmN1KGtm ZF9wcm9jZXNzZXNfdGFibGUsIHRlbXAsIHAsIGtmZF9wcm9jZXNzZXMpIHsKPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgbXV0ZXhfbG9jaygmcC0+bXV0ZXgpOwo+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBwZGQgPSBrZmRfZ2V0X3Byb2Nlc3NfZGV2aWNlX2RhdGEoZGV2 LCBwKTsKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAocGRkLT5ib3VuZCAhPSBQ RERfQk9VTkRfU1VTUEVOREVEKSB7Cj4gKwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGlmIChXQVJOX09OKCFwZGQpIHx8IHBkZC0+Ym91bmQgIT0gUEREX0JPVU5EX1NVU1BFTkRFRCkg ewo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbXV0ZXhf dW5sb2NrKCZwLT5tdXRleCk7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBjb250aW51ZTsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfQo+ IEBAIC01MDEsNiArNTAyLDExIEBAIHZvaWQga2ZkX3VuYmluZF9wcm9jZXNzZXNfZnJvbV9kZXZp Y2Uoc3RydWN0Cj4ga2ZkX2RldiAqZGV2KQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBtdXRleF9sb2NrKCZwLT5tdXRleCk7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHBkZCA9IGtmZF9nZXRfcHJvY2Vzc19kZXZpY2VfZGF0YShkZXYsIHApOwo+Cj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKFdBUk5fT04oIXBkZCkpIHsKPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbXV0ZXhfdW5sb2NrKCZwLT5tdXRleCk7 Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnRpbnVl Owo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiArCj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGlmIChwZGQtPmJvdW5kID09IFBERF9CT1VORCkKPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBkZC0+Ym91bmQgPSBQRERfQk9V TkRfU1VTUEVOREVEOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtdXRleF91bmxv Y2soJnAtPm11dGV4KTsKPgo+Cj4gVGhhbmsgeW91IGZvciB0aGUgZmVlZGJhY2suCj4gLS0gCj4g R3VzdGF2bwo+Cj4+IFJlZ2FyZHMsCj4+IMKgIEZlbGl4Cj4+Cj4+Cj4+IE9uIDIwMTgtMDEtMTAg MTE6NTAgQU0sIEd1c3Rhdm8gQS4gUi4gU2lsdmEgd3JvdGU6Cj4+PiBJbiBjYXNlIGtmZF9nZXRf cHJvY2Vzc19kZXZpY2VfZGF0YSByZXR1cm5zIG51bGwsIHRoZXJlIGFyZSBzb21lCj4+PiBudWxs IHBvaW50ZXIgZGVyZWZlcmVuY2VzIGluIGZ1bmN0aW9ucyBrZmRfYmluZF9wcm9jZXNzZXNfdG9f ZGV2aWNlCj4+PiBhbmQga2ZkX3VuYmluZF9wcm9jZXNzZXNfZnJvbV9kZXZpY2UuCj4+Pgo+Pj4g Rml4IHRoaXMgYnkgbnVsbCBjaGVja2luZyBwZGQgYmVmb3JlIGRlcmVmZXJlbmNpbmcgaXQuCj4+ Pgo+Pj4gQWRkcmVzc2VzLUNvdmVyaXR5LUlEOiAxNDYzNzk0ICgiRGVyZWZlcmVuY2UgbnVsbCBy ZXR1cm4gdmFsdWUiKQo+Pj4gQWRkcmVzc2VzLUNvdmVyaXR5LUlEOiAxNDYzNzcyICgiRGVyZWZl cmVuY2UgbnVsbCByZXR1cm4gdmFsdWUiKQo+Pj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBBLiBS LiBTaWx2YSA8Z2Fyc2lsdmFAZW1iZWRkZWRvci5jb20+Cj4+PiAtLS0KPj4+IMKgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYyB8IDEyICsrKysrKysrKysrKwo+Pj4gwqAx IGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfcHJvY2Vzcy5jCj4+PiBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1ka2ZkL2tmZF9wcm9jZXNzLmMKPj4+IGluZGV4IGEyMmZiMDcxLi4yOWQ1MWQ1IDEw MDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYwo+ Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYwo+Pj4gQEAg LTQ2MSw2ICs0NjEsMTMgQEAgaW50IGtmZF9iaW5kX3Byb2Nlc3Nlc190b19kZXZpY2Uoc3RydWN0 IGtmZF9kZXYKPj4+ICpkZXYpCj4+PiDCoMKgwqDCoCBoYXNoX2Zvcl9lYWNoX3JjdShrZmRfcHJv Y2Vzc2VzX3RhYmxlLCB0ZW1wLCBwLCBrZmRfcHJvY2Vzc2VzKSB7Cj4+PiDCoMKgwqDCoMKgwqDC oMKgIG11dGV4X2xvY2soJnAtPm11dGV4KTsKPj4+IMKgwqDCoMKgwqDCoMKgwqAgcGRkID0ga2Zk X2dldF9wcm9jZXNzX2RldmljZV9kYXRhKGRldiwgcCk7Cj4+PiArCj4+PiArwqDCoMKgwqDCoMKg wqAgaWYgKCFwZGQpIHsKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByX2VycigiUHJvY2Vz cyBkZXZpY2UgZGF0YSBkb2Vzbid0IGV4aXN0XG4iKTsKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIG11dGV4X3VubG9jaygmcC0+bXV0ZXgpOwo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg cmV0dXJuIC1FRkFVTFQ7Cj4+PiArwqDCoMKgwqDCoMKgwqAgfQo+Pj4gKwo+Pj4gwqDCoMKgwqDC oMKgwqDCoCBpZiAocGRkLT5ib3VuZCAhPSBQRERfQk9VTkRfU1VTUEVOREVEKSB7Cj4+PiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgbXV0ZXhfdW5sb2NrKCZwLT5tdXRleCk7Cj4+PiDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgY29udGludWU7Cj4+PiBAQCAtNTAxLDYgKzUwOCwxMSBAQCB2b2lk IGtmZF91bmJpbmRfcHJvY2Vzc2VzX2Zyb21fZGV2aWNlKHN0cnVjdAo+Pj4ga2ZkX2RldiAqZGV2 KQo+Pj4gwqDCoMKgwqDCoMKgwqDCoCBtdXRleF9sb2NrKCZwLT5tdXRleCk7Cj4+PiDCoMKgwqDC oMKgwqDCoMKgIHBkZCA9IGtmZF9nZXRfcHJvY2Vzc19kZXZpY2VfZGF0YShkZXYsIHApOwo+Pj4K Pj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoIXBkZCkgewo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqAgbXV0ZXhfdW5sb2NrKCZwLT5tdXRleCk7Cj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm47Cj4+PiArwqDCoMKgwqDCoMKgwqAgfQo+Pj4gKwo+Pj4gwqDCoMKgwqDCoMKgwqDCoCBp ZiAocGRkLT5ib3VuZCA9PSBQRERfQk9VTkQpCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg cGRkLT5ib3VuZCA9IFBERF9CT1VORF9TVVNQRU5ERUQ7Cj4+PiDCoMKgwqDCoMKgwqDCoMKgIG11 dGV4X3VubG9jaygmcC0+bXV0ZXgpOwo+Cj4KPgo+Cj4KPgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==