From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround
Date: Fri, 6 Apr 2018 14:15:34 +0200
Message-ID: <418cb54d-a423-e36c-d792-e3f0cdfe8758@redhat.com>
References: <20180328012451.31479-1-emil.l.velikov@gmail.com>
 <20180328012451.31479-3-emil.l.velikov@gmail.com>
 <4b461dc5-5bff-af82-2716-7228b5f16d76@redhat.com>
 <CACvgo505ZrxdzUdL+yHagdsiDPYB_aBfL=pGyOQ70YoXqD_mhw@mail.gmail.com>
 <8627a2a2-21dc-92a7-7916-35777252032d@redhat.com>
 <CACvgo51JHOz9Oymvaph6ZMaKKbEaOW8DAbkRQgazrngnoeuSNw@mail.gmail.com>
 <569d6ab7-7728-3623-30ec-7ca6751641ca@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 06E866E12F
 for <dri-devel@lists.freedesktop.org>; Fri,  6 Apr 2018 12:15:37 +0000 (UTC)
In-Reply-To: <569d6ab7-7728-3623-30ec-7ca6751641ca@redhat.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Gerd Hoffmann <kraxel@redhat.com>, ML dri-devel <dri-devel@lists.freedesktop.org>, Hans de Goede <hdegoede@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

T24gMDQvMDQvMTggMTk6MjksIExhc3psbyBFcnNlayB3cm90ZToKPiBIaSBFbWlsLAo+Cj4gT24g
MDQvMDMvMTggMTk6MTMsIEVtaWwgVmVsaWtvdiB3cm90ZToKPj4gT24gMjkgTWFyY2ggMjAxOCBh
dCAxMjoxNywgTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4gd3JvdGU6Cj4+PiBPbiAw
My8yOC8xOCAxNjozNSwgRW1pbCBWZWxpa292IHdyb3RlOgo+Pj4+IE9uIDI4IE1hcmNoIDIwMTgg
YXQgMTE6MjcsIExhc3psbyBFcnNlayA8bGVyc2VrQHJlZGhhdC5jb20+IHdyb3RlOgo+Pj4+PiBP
biAwMy8yOC8xOCAwMzoyNCwgRW1pbCBWZWxpa292IHdyb3RlOgo+Pj4KPj4+Pj4+IEdlbnRzLCBj
YW4gc29tZW9uZSBkb3VibGUtY2hlY2sgdGhpcyBwbGVhc2U/IEp1c3QgaW4gY2FzZS4KPj4+Pj4K
Pj4+Pj4gSSBndWVzcyBJIHNob3VsZCB0ZXN0IHdoZXRoZXIgdGhpcyBzZXJpZXMgcmVncmVzc2Vz
IHRoZSB1c2UgY2FzZQo+Pj4+PiBkZXNjcmliZWQgaW4gYzJjYmMzOGI5NzsgaXMgdGhhdCBjb3Jy
ZWN0Pwo+Pj4+Pgo+Pj4+IFByZWNpc2VseS4KPj4+Cj4+Pj4gWzNdIGh0dHBzOi8vZ2l0aHViLmNv
bS9ldmVsaWtvdi9saW51eC9jb21taXRzL2lvY3RsLWNsZWFudXBzCj4+Pgo+Pj4gVW5mb3J0dW5h
dGVseSwgdGhpcyBzZXJpZXMgc2VlbXMgdG8gcmVpbnRyb2R1Y2UgdGhlIHJlZ3Jlc3Npb24gZml4
ZWQKPj4+IC8gZGVzY3JpYmVkIGVhcmxpZXIgaW4gY29tbWl0IGMyY2JjMzhiOTcuCj4+Pgo+PiBU
aGFuayB5b3UgdmVyeSBtdWNoIGZvciB0ZXN0aW5nLgo+Pgo+PiBCZWxpZXZlIEkndmUgdHJhY2tl
ZCBpdCBkb3duIHRvIGEgYnJva2VuIGNvbW1pdCBmcm9tIDIwMTQgOy0pCj4+IFBsZWFzZSB0cnkg
dGhlIGZvbGxvd2luZyBicmFuY2ggWzFdIC0gaXQncyB1bnRlc3RlZCwgYnV0IEknbSA5OSUgc3Vy
ZQo+PiBpdCB3aWxsIHdvcmsgbGlrZSBhIGNoYXJtLgo+Cj4gQWxhcywgaXQgZG9lcyBub3Qgd29y
ay4KCkkndmUgZG9uZSBzb21lIG1vcmUgZGlnZ2luZy4gTGV0IG1lIHF1b3RlIHRoZSBjb21taXQg
bWVzc2FnZSBvbiB0aGUKcHJvcG9zZWQgcGF0Y2ggYWdhaW46Cgo+IEVhbGllciBjb21taXQgYTMy
NTcyNTYzM2MyNmFhNjZhYjk0MGY3NjJhNmIwNzc4ZWRmNzZjMCBkaWQgbm90IGF0dHJpYnV0ZQo+
IHRoYXQgdmlydGlvIGNhbiBiZSBlaXRoZXIgUENJIG9yIGEgcGxhdGZvcm0gZGV2aWNlIGFuZCBy
ZW1vdmVkIHRoZQo+IC5zZXRfYnVzaWQgaG9vay4gV2hlcmVhcyBvbmx5IHRoZSAicGxhdGZvcm0i
IGluc3RhbmNlIHNob3VsZCBoYXZlIGJlZW4KPiByZW1vdmVkLgo+Cj4gU2luY2UgdGhlbiwgdHdv
IHRoaW5ncyBoYXZlIGhhcHBlbmVkOgo+ICAtIHRoZSBkcml2ZXIgbWFudWFsbHkgY2FsbHMgZHJt
X2Rldl9zZXRfdW5pcXVlLCBhZGRyZXNzaW5nIHRoZSBYc2VydmVyCj4gcmVncmVzc2lvbiAtIHNl
ZSBjb21taXQgOTc4NWI0MzIxYjBiZDcwMWY4ZDIxZDNkM2M2NzZhNzczOWE1Y2YyMgo+ICAtIGNv
cmUgaXRzZWxmIGNhbGxzIGRybV9wY2lfc2V0X2J1c2lkLCBvbiBkcm1fc2V0X2J1c2lkIElPQ1RM
IHNldHRpbmcKPiB0aGUgYnVzaWQsIHNvIHdlIGRvbid0IG5lZWQgdG8gZmFsbGJhY2sgdG8gZGV2
LT51bmlxdWUgLSBzZWUgY29tbWl0Cj4gNWM0ODRjZWU3ZWY5YzRmZDI5ZmEwYmEwOTY0MGQ1NTk2
MDk3NzE0NQo+Cj4gV2l0aCB0aGF0IGluIHBsYWNlIHdlIGNhbiByZW1vdmUgdGhlIGxvY2FsIHdv
cmthcm91bmQuCgpUaGlzIHdyaXRlLXVwIG9mIGV2ZW50cyBpcyBub3QgcHJlY2lzZSBlbm91Z2gu
IEluc3RlYWQsIEkgdGhpbmsgdGhlCnRpbWVsaW5lIGlzIGFzIGZvbGxvd3M6CgooMSkgQ29tbWl0
IGEzMjU3MjU2MzNjMiAoImRybTogTG9ib3RvbWl6ZSBzZXRfYnVzaWQgbm9uc2Vuc2UgZm9yICFw
Y2kKICAgIGRyaXZlcnMiLCAyMDE2LTA2LTIxKSBpbnRyb2R1Y2VkIHRoZSByZWdyZXNzaW9uLiBC
eSByZW1vdmluZwogICAgZHJtX3ZpcnRpb19zZXRfYnVzaWQoKSwgY29tbWl0IGEzMjU3MjU2MzNj
MiBjaGFuZ2VkIHRoZSBiZWhhdmlvciBvZgogICAgdGhlIGZvbGxvd2luZyBmdW5jdGlvbjoKCj4g
c3RhdGljIGludCBkcm1fc2V0X2J1c2lkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBk
cm1fZmlsZSAqZmlsZV9wcml2KQo+IHsKPiAJc3RydWN0IGRybV9tYXN0ZXIgKm1hc3RlciA9IGZp
bGVfcHJpdi0+bWFzdGVyOwo+IAlpbnQgcmV0Owo+Cj4gCWlmIChtYXN0ZXItPnVuaXF1ZSAhPSBO
VUxMKQo+IAkJZHJtX3Vuc2V0X2J1c2lkKGRldiwgbWFzdGVyKTsKPgo+IAlpZiAoZGV2LT5kcml2
ZXItPnNldF9idXNpZCkgewo+IAkJcmV0ID0gZGV2LT5kcml2ZXItPnNldF9idXNpZChkZXYsIG1h
c3Rlcik7Cj4gCQlpZiAocmV0KSB7Cj4gCQkJZHJtX3Vuc2V0X2J1c2lkKGRldiwgbWFzdGVyKTsK
PiAJCQlyZXR1cm4gcmV0Owo+IAkJfQo+IAl9IGVsc2Ugewo+IAkJV0FSTl9PTighZGV2LT51bmlx
dWUpOwo+IAkJbWFzdGVyLT51bmlxdWUgPSBrc3RyZHVwKGRldi0+dW5pcXVlLCBHRlBfS0VSTkVM
KTsKPiAJCWlmIChtYXN0ZXItPnVuaXF1ZSkKPiAJCQltYXN0ZXItPnVuaXF1ZV9sZW4gPSBzdHJs
ZW4oZGV2LT51bmlxdWUpOwo+IAl9Cj4KPiAJcmV0dXJuIDA7Cj4gfQoKICAgIFdoZW4gYTMyNTcy
NTYzM2MyIHJlbW92ZWQgZHJtX3ZpcnRpb19zZXRfYnVzaWQoKSwgZHJtX3NldF9idXNpZCgpCiAg
ICBzdGFydGVkIHRha2luZyB0aGUgc2Vjb25kIGJyYW5jaCwgd2hpY2ggd2Fzbid0IGRvaW5nIHRo
ZSByaWdodCB0aGluZwogICAgZm9yIHZpcnRpby12Z2EgYXQgdGhlIHRpbWUuCgooMikgVGhlcmUg
d2VyZSB0d28gd2F5cyB0byBmaXggdGhlIHJlZ3Jlc3Npb246IGVpdGhlciAoYSkgcmV0dXJuCiAg
ICBkcm1fc2V0X2J1c2lkKCkgdG8gdGFraW5nIHRoZSBmaXJzdCBicmFuY2gsIG9yIChiKSB0d2Vh
ayB0aGUKICAgIHZpcnRpby12Z2EgZHJpdmVyIHNvIHRoYXQgdGhlIHNlY29uZCBicmFuY2ggaW4g
ZHJtX3NldF9idXNpZCgpIHN0YXJ0CiAgICB0byBiZWhhdmUgcmlnaHQuCgogICAgTXkgY29tbWl0
IGMyY2JjMzhiOTcxNSAoImRybTogdmlydGlvOiByZWluc3RhdGUKICAgIGRybV92aXJ0aW9fc2V0
X2J1c2lkKCkiLCAyMDE2LTEwLTA0KSBpbXBsZW1lbnRlZCAoYSksIGJ5IHJldmVydGluZyBhCiAg
ICBmZXcgY2h1bmtzIG9mIGEzMjU3MjU2MzNjMi4KCigzKSBHZXJkIHRob3VnaHQgdGhhdCBhcHBy
b2FjaCAoYikgd2FzIHN1cGVyaW9yIChhbmQgSSB0b3RhbGx5IGRlZmVyIHRvCiAgICBoaW0gb24g
dGhpcywgbm93IHRoYXQgSSdtIGxlYXJuaW5nIG9mIGhpcyBwYXRjaGVzIGluIHRoZSBmaXJzdCBw
bGFjZQogICAgOikgKS4gTmFtZWx5LCBpbiBjb21taXQgOTc4NWI0MzIxYjBiICgiZHJtL3ZpcnRp
bzogZml4IGJ1c2lkCiAgICByZWdyZXNzaW9uIiwgMjAxNi0xMS0xNSksIGhlIGltcGxlbWVudGVk
IGFwcHJvYWNoIChiKSwgYW5kIHJpZ2h0CiAgICBhZnRlciwgaW4gY29tbWl0IDE3NzVkYjA3NGEz
MiAoIlJldmVydCAiZHJtOiB2aXJ0aW86IHJlaW5zdGF0ZQogICAgZHJtX3ZpcnRpb19zZXRfYnVz
aWQoKSIiLCAyMDE2LTExLTE1KSwgaGUgdW5kaWQgbXkgY29tbWl0CiAgICBjMmNiYzM4Yjk3MTUu
CgogICAgSW4gb3RoZXIgd29yZHMsIEdlcmQgcmVwbGFjZWQgYXBwcm9hY2ggKGEpIHdpdGggYXBw
cm9hY2ggKGIpLgoKKDQpIFN1YnNlcXVlbnRseSwgY29tbWl0IDVjNDg0Y2VlN2VmOSAoImRybTog
UmVtb3ZlCiAgICBkcm1fZHJpdmVyLT5zZXRfYnVzaWQgaG9vayIsIDIwMTctMDYtMjApLCBjaGFu
Z2VkIGRybV9zZXRfYnVzaWQoKQogICAgdG8gIHRoZSBmb2xsb3dpbmc6Cgo+IHN0YXRpYyBpbnQg
ZHJtX3NldF9idXNpZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZp
bGVfcHJpdikKPiB7Cj4gCXN0cnVjdCBkcm1fbWFzdGVyICptYXN0ZXIgPSBmaWxlX3ByaXYtPm1h
c3RlcjsKPiAJaW50IHJldDsKPgo+IAlpZiAobWFzdGVyLT51bmlxdWUgIT0gTlVMTCkKPiAJCWRy
bV91bnNldF9idXNpZChkZXYsIG1hc3Rlcik7Cj4KPiAJaWYgKGRldl9pc19wY2koZGV2LT5kZXYp
KSB7Cj4gCQlyZXQgPSBkcm1fcGNpX3NldF9idXNpZChkZXYsIG1hc3Rlcik7Cj4gCQlpZiAocmV0
KSB7Cj4gCQkJZHJtX3Vuc2V0X2J1c2lkKGRldiwgbWFzdGVyKTsKPiAJCQlyZXR1cm4gcmV0Owo+
IAkJfQo+IAl9IGVsc2Ugewo+IAkJV0FSTl9PTighZGV2LT51bmlxdWUpOwo+IAkJbWFzdGVyLT51
bmlxdWUgPSBrc3RyZHVwKGRldi0+dW5pcXVlLCBHRlBfS0VSTkVMKTsKPiAJCWlmIChtYXN0ZXIt
PnVuaXF1ZSkKPiAJCQltYXN0ZXItPnVuaXF1ZV9sZW4gPSBzdHJsZW4oZGV2LT51bmlxdWUpOwo+
IAl9Cj4KPiAJcmV0dXJuIDA7Cj4gfQoKICAgIFBlcmhhcHMgc3VycHJpc2luZ2x5LCB0aGlzIGNo
YW5nZSBkaWQgbm90IGFmZmVjdCAob3IgImhlbHAiKQogICAgdmlydGlvLXZnYSBhdCBhbGwsIGRl
c3BpdGUgdGhlIGZhY3QgdGhhdCBkcm1fdmlydGlvX3NldF9idXNpZCgpIGFsc28KICAgIHVzZWQg
dG8gY2FsbCBkcm1fcGNpX3NldF9idXNpZCgpLgoKICAgIFRoZSByZWFzb24gZm9yIGNvbW1pdCA1
YzQ4NGNlZTdlZjkgbm90IGFmZmVjdGluZyB2aXJ0aW8tdmdhIGlzIHRoYXQKICAgIHRoZSBmaXJz
dCBicmFuY2ggd291bGQgbm90IGJlIHRha2VuIGp1c3QgdGhlIHNhbWUsIGJlY2F1c2UKICAgIGRl
dl9pc19wY2koKSByZXR1cm5zIGZhbHNlIGZvciB2aXJ0aW8tdmdhLiAoU28sIHRoZSBkaWZmZXJl
bmNlIHdpdGgKICAgIGRybV92aXJ0aW9fc2V0X2J1c2lkKCkgaXMgdGhhdCBkcm1fdmlydGlvX3Nl
dF9idXNpZCgpIHdvdWxkIGNhbGwKICAgIGRybV9wY2lfc2V0X2J1c2lkKCkgd2l0aG91dCBjaGVj
a2luZyBkZXZfaXNfcGNpKCkgZmlyc3QuKQoKICAgIEhlcmUncyB0aGUgZGVmaW5pdGlvbiBvZiB0
aGUgZGV2X2lzX3BjaSgpIG1hY3JvLCBmcm9tCiAgICAiaW5jbHVkZS9saW51eC9wY2kuaCI6Cgo+
ICNkZWZpbmUgZGV2X2lzX3BjaShkKSAoKGQpLT5idXMgPT0gJnBjaV9idXNfdHlwZSkKCiAgICBI
b3dldmVyLCB0aGUgYnVzIHR5cGUgZm9yIHZpcnRpby12Z2EgaXMgInZpcnRpb19idXMiLCBub3QK
ICAgICJwY2lfYnVzX3R5cGUiLiBOYW1lbHksIHZpcnRpb19wY2lfcHJvYmUoKQogICAgW2RyaXZl
cnMvdmlydGlvL3ZpcnRpb19wY2lfY29tbW9uLmNdIGNhbGxzIHJlZ2lzdGVyX3ZpcnRpb19kZXZp
Y2UoKQogICAgW2RyaXZlcnMvdmlydGlvL3ZpcnRpby5jXSwgYW5kIHRoZXJlIHdlIGhhdmUKCj4g
aW50IHJlZ2lzdGVyX3ZpcnRpb19kZXZpY2Uoc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikKPiB7
Cj4gCWludCBlcnI7Cj4KPiAJZGV2LT5kZXYuYnVzID0gJnZpcnRpb19idXM7CgogICAgVGhpcyBt
ZWFucyB0aGF0IHBvc3QtNWM0ODRjZWU3ZWY5LCB3ZSByZW1haW4gcmVsaWFudCBvbiB0aGUgc2Vj
b25kCiAgICBicmFuY2ggaW4gZHJtX3NldF9idXNpZCgpLCBhbmQgdGhlcmVmb3JlIEdlcmQncyBj
b21taXQgOTc4NWI0MzIxYjBiLAogICAgZnJvbSBwb2ludCAoMyksIHNob3VsZCBub3QgYmUgYmFj
a2VkIG91dC4KCldoYXQgSSBjb3VsZCBzZWUgYXMganVzdGlmaWVkIGlzIGEgbG91ZCBjb21tZW50
IGluIGRybV92aXJ0aW9faW5pdCgpLApqdXN0IGFib3ZlIHRoZSBjYWxsIHRvIGRybV9kZXZfc2V0
X3VuaXF1ZSgpLCBleHBsYWluaW5nIHdoeSBpdCBpcwpuZWNlc3NhcnkgdG8gc2V0ICJ1bmlxdWUi
IG1hbnVhbGx5LiBUaGUgcmVhc29uIGlzIHRoYXQgdmlydGlvLXZnYQp0ZWNobmljYWxseSBoYXMg
InZpcnRpb19idXMiLCBub3QgInBjaV9idXNfdHlwZSIsIGZvciBidXMgdHlwZSwgYW5kIHNvCnRo
ZSBnZW5lcmljIFBDSSBCdXNJRC1zZXR0aW5nIHdpbGwgbm90IGNvdmVyIGl0LgoKVGhhbmtzCkxh
c3psbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt
ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK