From: Demi Marie Obenour <demiobenour@gmail.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
"Huang, Honglei1" <Honglei1.Huang@amd.com>,
David Airlie <airlied@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Gurchetan Singh <gurchetansingh@chromium.org>,
Chia-I Wu <olvaffe@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Simona Vetter <simona@ffwll.ch>, Rob Clark <robdclark@gmail.com>,
Huang Rui <ray.huang@amd.com>
Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/7] virtio-gpu api: add blob userptr resource
Date: Sat, 29 Mar 2025 15:50:46 -0400 [thread overview]
Message-ID: <42048a80-a736-4ccc-953b-924d1e640cd0@gmail.com> (raw)
In-Reply-To: <85470439-3c03-4787-be91-b6b680a5aca5@collabora.com>
On 3/26/25 10:46 AM, Dmitry Osipenko wrote:
> On 3/6/25 13:51, Huang, Honglei1 wrote:
>>
>> On 2025/3/1 5:21, Demi Marie Obenour wrote:
>>> On 2/28/25 12:36 AM, Honglei Huang wrote:
>>>> From: Honglei Huang <Honglei1.Huang@amd.com>
>>>>
>>>> Add a new resource for blob resource, called userptr, used for let
>>>> host access guest user space memory, to acquire buffer based userptr
>>>> feature in virtio GPU.
>>>>
>>>> - The capset VIRTIO_GPU_CAPSET_HSAKMT used for context init,
>>>> in this series patches only HSAKMT context can use the userptr
>>>> feature. HSAKMT is a GPU compute library in HSA stack, like
>>>> the role libdrm in mesa stack.
>>>
>>> Userptr should not be limited to HSMKMT contexts. Userptr can
>>> accelerate shm buffers by avoiding a copy from guest to host, and
>>> it can be implemented using grant tables on Xen.
>>
>> Yes, I totally agree userptr can accelerate shm buffers, but I currently
>> don't know if there are any other projects working on similar features,
>> or if maintainers have any opinions or better ways to implement them, so
>> I temporarily limit this feature to HSAKMT context only.
>>
>> I am waiting for everyone's opinions, please provide your thoughts.
>
> USERPTR should be relevant for anything Vulkan-related, like Venus and
> native contexts. I expect that this new feature will work universally
> good for all context types.
>
> In order to merge USERPTR support upstream, we at least will need to
> prototype the guest USERPTR in one of native context driver to know that
> it works. You'll need to post the whole set of host/guest USERPTR
> patches including QEMU and etc, not just the kernel patches.
Does the user-mode VMM need to be QEMU or would patches to
another open-source VMM, such as crosvm, be sufficient?
--
Sincerely,
Demi Marie Obenour (she/her/hers)
next prev parent reply other threads:[~2025-03-29 19:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 5:36 [PATCH v1 0/7] Add virtio gpu userptr support Honglei Huang
2025-02-28 5:36 ` [PATCH v1 1/7] virtio-gpu api: add blob userptr resource Honglei Huang
2025-02-28 21:21 ` Demi Marie Obenour
2025-03-06 10:51 ` Huang, Honglei1
2025-03-18 1:37 ` Gurchetan Singh
2025-03-18 11:25 ` Huang, Honglei1
2025-03-24 2:44 ` Huang, Honglei1
2025-03-26 14:46 ` Dmitry Osipenko
2025-03-27 3:00 ` Huang, Honglei1
2025-03-28 1:39 ` Dmitry Osipenko
2025-03-29 19:50 ` Demi Marie Obenour [this message]
2025-03-30 11:57 ` Dmitry Osipenko
2025-02-28 5:36 ` [PATCH v1 2/7] drm/virtgpu " Honglei Huang
2025-02-28 5:36 ` [PATCH v1 3/7] drm/virtio: implement userptr: probe for the feature Honglei Huang
2025-02-28 5:36 ` [PATCH v1 4/7] drm/virtio: implement userptr: add userptr obj Honglei Huang
2025-02-28 5:36 ` [PATCH v1 5/7] drm/virtio: advertise base userptr feature to userspace Honglei Huang
2025-02-28 5:36 ` [PATCH v1 6/7] drm/virtio: implement userptr: add interval tree Honglei Huang
2025-02-28 5:36 ` [PATCH v1 7/7] drm/virtio: implement userptr: add mmu notifier Honglei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42048a80-a736-4ccc-953b-924d1e640cd0@gmail.com \
--to=demiobenour@gmail.com \
--cc=Honglei1.Huang@amd.com \
--cc=airlied@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=ray.huang@amd.com \
--cc=robdclark@gmail.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).