From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH v6 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages() Date: Tue, 19 Nov 2019 23:03:10 -0800 Message-ID: <42c80c0a-ad2c-fe74-babd-57680882c7e2@nvidia.com> References: <20191119081643.1866232-1-jhubbard@nvidia.com> <20191119081643.1866232-16-jhubbard@nvidia.com> <2ae65d1b-a3eb-74ed-afce-c493de5bbfd3@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2ae65d1b-a3eb-74ed-afce-c493de5bbfd3@kernel.dk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jens Axboe , Andrew Morton Cc: Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko List-Id: dri-devel@lists.freedesktop.org On 11/19/19 8:10 AM, Jens Axboe wrote: > On 11/19/19 1:16 AM, John Hubbard wrote: >> Convert fs/io_uring to use the new pin_user_pages() call, which sets >> FOLL_PIN. Setting FOLL_PIN is now required for code that requires >> tracking of pinned pages, and therefore for any code that calls >> put_user_page(). >> >> In partial anticipation of this work, the io_uring code was already >> calling put_user_page() instead of put_page(). Therefore, in order to >> convert from the get_user_pages()/put_page() model, to the >> pin_user_pages()/put_user_page() model, the only change required >> here is to change get_user_pages() to pin_user_pages(). >> >> Reviewed-by: Jan Kara >> Signed-off-by: John Hubbard > > You dropped my reviewed-by now... Given the file, you'd probably want > to keep that. Hi Jens, Yes, I was being too conservative I guess. I changed the patch somewhat and dropped the reviewed-by because of those changes...I'm adding it back for v7 based on this, thanks! thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4885C432C0 for ; Wed, 20 Nov 2019 07:03:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B533C21D7F for ; Wed, 20 Nov 2019 07:03:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B533C21D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7C986E0F0; Wed, 20 Nov 2019 07:03:13 +0000 (UTC) Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C7D16E0F0 for ; Wed, 20 Nov 2019 07:03:12 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 19 Nov 2019 23:03:07 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 19 Nov 2019 23:03:11 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 19 Nov 2019 23:03:11 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 20 Nov 2019 07:03:10 +0000 Subject: Re: [PATCH v6 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages() To: Jens Axboe , Andrew Morton References: <20191119081643.1866232-1-jhubbard@nvidia.com> <20191119081643.1866232-16-jhubbard@nvidia.com> <2ae65d1b-a3eb-74ed-afce-c493de5bbfd3@kernel.dk> X-Nvconfidentiality: public From: John Hubbard Message-ID: <42c80c0a-ad2c-fe74-babd-57680882c7e2@nvidia.com> Date: Tue, 19 Nov 2019 23:03:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <2ae65d1b-a3eb-74ed-afce-c493de5bbfd3@kernel.dk> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574233388; bh=ccH+u52vDWCSpx4Mj41DBPFk4Bnr7E1/buLUhbEm50I=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=JgB1DKCfL3XJ8zWGygaD3BUGSICo+/trsKwCSHVYrMBALdO+vFpmYy6dqLGjIrPUQ sF8xGbyB1ACyvX2yUiKVkLwR0sQwJE97fwYv43/2HldX2Up5joY07G6jGvVqUmPQbs s7aCBGJCkJx2+gmT6XrOocwOkA9Y2V4feML4cKWbwQHDTj0KN68vQj8arDmTnlLpeV Vl2szJ5e3K6FGqS7Ak9pQCBtOltdIBEAKXl2K2K6H027fUCWGLfdlzI522BqaVGPv9 4MOGZXHfPcXsBvyqnQSS/gMqKBesz8M6hmg3+jR2K/xr7fDjV/7ORS+2k7FT5h4Hcc +4RQhVotw05/w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Shuah Khan , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Ira Weiny , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , Magnus Karlsson , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191120070310.RZWo8hxIgifWSWEBMtIFdfKBwYGY5yQBkeEJPxaAzuo@z> T24gMTEvMTkvMTkgODoxMCBBTSwgSmVucyBBeGJvZSB3cm90ZToKPiBPbiAxMS8xOS8xOSAxOjE2 IEFNLCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4+IENvbnZlcnQgZnMvaW9fdXJpbmcgdG8gdXNlIHRo ZSBuZXcgcGluX3VzZXJfcGFnZXMoKSBjYWxsLCB3aGljaCBzZXRzCj4+IEZPTExfUElOLiBTZXR0 aW5nIEZPTExfUElOIGlzIG5vdyByZXF1aXJlZCBmb3IgY29kZSB0aGF0IHJlcXVpcmVzCj4+IHRy YWNraW5nIG9mIHBpbm5lZCBwYWdlcywgYW5kIHRoZXJlZm9yZSBmb3IgYW55IGNvZGUgdGhhdCBj YWxscwo+PiBwdXRfdXNlcl9wYWdlKCkuCj4+Cj4+IEluIHBhcnRpYWwgYW50aWNpcGF0aW9uIG9m IHRoaXMgd29yaywgdGhlIGlvX3VyaW5nIGNvZGUgd2FzIGFscmVhZHkKPj4gY2FsbGluZyBwdXRf dXNlcl9wYWdlKCkgaW5zdGVhZCBvZiBwdXRfcGFnZSgpLiBUaGVyZWZvcmUsIGluIG9yZGVyIHRv Cj4+IGNvbnZlcnQgZnJvbSB0aGUgZ2V0X3VzZXJfcGFnZXMoKS9wdXRfcGFnZSgpIG1vZGVsLCB0 byB0aGUKPj4gcGluX3VzZXJfcGFnZXMoKS9wdXRfdXNlcl9wYWdlKCkgbW9kZWwsIHRoZSBvbmx5 IGNoYW5nZSByZXF1aXJlZAo+PiBoZXJlIGlzIHRvIGNoYW5nZSBnZXRfdXNlcl9wYWdlcygpIHRv IHBpbl91c2VyX3BhZ2VzKCkuCj4+Cj4+IFJldmlld2VkLWJ5OiBKYW4gS2FyYSA8amFja0BzdXNl LmN6Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKb2huIEh1YmJhcmQgPGpodWJiYXJkQG52aWRpYS5jb20+ Cj4gCj4gWW91IGRyb3BwZWQgbXkgcmV2aWV3ZWQtYnkgbm93Li4uIEdpdmVuIHRoZSBmaWxlLCB5 b3UnZCBwcm9iYWJseSB3YW50Cj4gdG8ga2VlcCB0aGF0LgoKSGkgSmVucywKClllcywgSSB3YXMg YmVpbmcgdG9vIGNvbnNlcnZhdGl2ZSBJIGd1ZXNzLiBJIGNoYW5nZWQgdGhlIHBhdGNoIHNvbWV3 aGF0CmFuZCBkcm9wcGVkIHRoZSByZXZpZXdlZC1ieSBiZWNhdXNlIG9mIHRob3NlIGNoYW5nZXMu Li5JJ20gYWRkaW5nIGl0CmJhY2sgZm9yIHY3IGJhc2VkIG9uIHRoaXMsIHRoYW5rcyEKCnRoYW5r cywKLS0gCkpvaG4gSHViYmFyZApOVklESUEKIApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw=