From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: Karol Wachowski <karol.wachowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Subject: Re: [PATCH 1/2] accel/ivpu: Fix VPU register access in irq disable
Date: Wed, 5 Jul 2023 10:26:40 +0200 [thread overview]
Message-ID: <42d3dd5a-1669-48ff-81eb-0dbe1229720c@linux.intel.com> (raw)
In-Reply-To: <20230703080725.2065635-1-stanislaw.gruszka@linux.intel.com>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
On 03.07.2023 10:07, Stanislaw Gruszka wrote:
> From: Karol Wachowski <karol.wachowski@linux.intel.com>
>
> Incorrect REGB_WR32() macro was used to access VPUIP register.
> Use correct REGV_WR32().
>
> Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU")
> Cc: stable@vger.kernel.org # 6.3.x
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_hw_mtl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_hw_mtl.c b/drivers/accel/ivpu/ivpu_hw_mtl.c
> index 3ff60fbbc8d9..d3ba633daaa0 100644
> --- a/drivers/accel/ivpu/ivpu_hw_mtl.c
> +++ b/drivers/accel/ivpu/ivpu_hw_mtl.c
> @@ -874,7 +874,7 @@ static void ivpu_hw_mtl_irq_disable(struct ivpu_device *vdev)
> REGB_WR32(MTL_BUTTRESS_GLOBAL_INT_MASK, 0x1);
> REGB_WR32(MTL_BUTTRESS_LOCAL_INT_MASK, BUTTRESS_IRQ_DISABLE_MASK);
> REGV_WR64(MTL_VPU_HOST_SS_ICB_ENABLE_0, 0x0ull);
> - REGB_WR32(MTL_VPU_HOST_SS_FW_SOC_IRQ_EN, 0x0);
> + REGV_WR32(MTL_VPU_HOST_SS_FW_SOC_IRQ_EN, 0x0);
> }
>
> static void ivpu_hw_mtl_irq_wdt_nce_handler(struct ivpu_device *vdev)
next prev parent reply other threads:[~2023-07-05 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 8:07 [PATCH 1/2] accel/ivpu: Fix VPU register access in irq disable Stanislaw Gruszka
2023-07-03 8:07 ` [PATCH 2/2] accel/ivpu: Clear specific interrupt status bits on C0 Stanislaw Gruszka
2023-07-05 8:26 ` Jacek Lawrynowicz
2023-07-05 8:26 ` Jacek Lawrynowicz [this message]
2023-07-05 10:38 ` [PATCH 1/2] accel/ivpu: Fix VPU register access in irq disable Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42d3dd5a-1669-48ff-81eb-0dbe1229720c@linux.intel.com \
--to=jacek.lawrynowicz@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karol.wachowski@linux.intel.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox