From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 4/4] drm/i915/ttm: ensure we unmap when purging
Date: Fri, 7 Jan 2022 09:27:21 +0100 [thread overview]
Message-ID: <4348e218-cacb-3392-ad4c-529f5a2ef00f@linux.intel.com> (raw)
In-Reply-To: <20220106174910.280616-4-matthew.auld@intel.com>
On 1/6/22 18:49, Matthew Auld wrote:
> Purging can happen during swapping out, or directly invoked with the
> madvise ioctl. In such cases this doesn't involve a ttm move, which
> skips umapping the object.
>
> v2(Thomas):
> - add ttm_truncate helper, and just call into i915_ttm_move_notify() to
> handle the unmapping step
>
> Fixes: cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Should this Fixes: tag be when we we introduce truncate for the TTM
backend. IIRC that was in a later commit?
Otherwise
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
/Thomas
prev parent reply other threads:[~2022-01-07 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 17:49 [PATCH v3 1/4] drm/i915: don't call free_mmap_offset when purging Matthew Auld
2022-01-06 17:49 ` [PATCH v3 2/4] drm/i915/ttm: only fault WILLNEED objects Matthew Auld
2022-01-06 17:49 ` [PATCH v3 3/4] drm/i915/ttm: add unmap_virtual callback Matthew Auld
2022-01-07 8:33 ` Thomas Hellström
2022-01-06 17:49 ` [PATCH v3 4/4] drm/i915/ttm: ensure we unmap when purging Matthew Auld
2022-01-07 8:27 ` Thomas Hellström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4348e218-cacb-3392-ad4c-529f5a2ef00f@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox