From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Huacai Chen <chenhuacai@loongson.cn>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Huacai Chen <chenhuacai@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: Xiaotian Wu <wuxiaotian@loongson.cn>, dri-devel@lists.freedesktop.org
Subject: Re: [V2] drm/loongson: Error out if no VRAM detected
Date: Wed, 24 Jan 2024 19:37:19 +0800 [thread overview]
Message-ID: <434aaa97-f263-4dfb-a9fb-4e8fd43290eb@linux.dev> (raw)
In-Reply-To: <20240124101607.2910998-1-chenhuacai@loongson.cn>
Hi,
On 2024/1/24 18:16, Huacai Chen wrote:
> If there is no VRAM (it can be true if there is a discreted card, this
> is probably a hardware configuration issue in BIOS but it is observed in
> GDC-1401 laptop, L71 laptop and some Loongson-3C5000L based servers), we
> get such an error and Xorg fails to start:
>
> [ 136.401131] loongson 0000:00:06.1: [drm] *ERROR* Requesting(0MiB) failed
> [ 137.444342] loongson 0000:00:06.1: [drm] *ERROR* Requesting(0MiB) failed
> [ 138.871166] loongson 0000:00:06.1: [drm] *ERROR* Requesting(0MiB) failed
> [ 140.444078] loongson 0000:00:06.1: [drm] *ERROR* Requesting(0MiB) failed
> [ 142.403993] loongson 0000:00:06.1: [drm] *ERROR* Requesting(0MiB) failed
> [ 143.970625] loongson 0000:00:06.1: [drm] *ERROR* Requesting(0MiB) failed
> [ 145.862013] loongson 0000:00:06.1: [drm] *ERROR* Requesting(0MiB) failed
>
> So in lsdc_get_dedicated_vram() we error out if no VRAM (or VRAM is less
> than 1MB which is also an unusable case) detected.
>
> Tested-by: Xiaotian Wu <wuxiaotian@loongson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
By the way, sending patch should Cc Maxime and Thomas in the future.
Since this patch is small patch, not a big deal, so it probably okay.
This serve as a basic sanity check, hopes this helps to mitigate the pains.
Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev>
prev parent reply other threads:[~2024-01-24 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 10:16 [PATCH V2] drm/loongson: Error out if no VRAM detected Huacai Chen
2024-01-24 11:37 ` Sui Jingfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434aaa97-f263-4dfb-a9fb-4e8fd43290eb@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=airlied@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wuxiaotian@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox