From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F330DCF6480 for ; Fri, 27 Sep 2024 21:28:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C5EC10ED29; Fri, 27 Sep 2024 21:28:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.b="dLiF+gTl"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31A4B10ED29 for ; Fri, 27 Sep 2024 21:28:43 +0000 (UTC) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48RG1JAv014838; Fri, 27 Sep 2024 21:28:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= epZPtFnwuWHQO9eRDNP7YScTEj/7u51mH9+ce4gCaL8=; b=dLiF+gTlK2xse7j3 KMGwAFAquzJqDbw/W6T5eChC7nnuOA22n3LTiryk2dMvnNQqTArJk3JPXIjyf6I1 BKTnctC75VvuAo2WqtjmsUkDY9aCcBhfhuaeOWvG3fVpg6YyrvIGyLfICgemGGFs 3o69rpckdYaHI/tCFNe5IfEZNEeiXkAlL80+3tLUDNobvuWFfBOyHfObyXkvyald 5M2rxMnji9IkF8hdLAeczFLqV3PAEMzaO/MecNsOXCK+DMJuj97u1latfRzvZlPF NtFQmnXrQVuVbI4HzrcYv1wOVyGfOQ87kcXnau1kZRV6I0T/HFMULe7sV4b6+qJr DncKYQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41spc34289-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 21:28:39 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 48RLSdW1010213 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 21:28:39 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 27 Sep 2024 14:28:38 -0700 Message-ID: <43a19468-8691-8947-e306-40de75cd7e4d@quicinc.com> Date: Fri, 27 Sep 2024 15:28:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 20/29] accel/ivpu: Prevent recovery invocation during probe and resume Content-Language: en-US To: Jacek Lawrynowicz , CC: , Karol Wachowski References: <20240924081754.209728-1-jacek.lawrynowicz@linux.intel.com> <20240924081754.209728-21-jacek.lawrynowicz@linux.intel.com> From: Jeffrey Hugo In-Reply-To: <20240924081754.209728-21-jacek.lawrynowicz@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 83462HiyzgD0pJHD7wYbfU1hKo0P2C64 X-Proofpoint-ORIG-GUID: 83462HiyzgD0pJHD7wYbfU1hKo0P2C64 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 mlxlogscore=628 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409270157 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: > From: Karol Wachowski > > Refactor IPC send and receive functions to allow correct > handling of operations that should not trigger a recovery process. > > Expose ivpu_send_receive_internal(), which is now utilized by the D0i3 > entry, DCT initialization, and HWS initialization functions. > These functions have been modified to return error codes gracefully, > rather than initiating recovery. > > The updated functions are invoked within ivpu_probe() and ivpu_resume(), > ensuring that any errors encountered during these stages result in a proper > teardown or shutdown sequence. The previous approach of triggering recovery > within these functions could lead to a race condition, potentially causing > undefined behavior and kernel crashes due to null pointer dereferences. Fixing possible kernel panics, sounds like a great idea. Should have a fixes tag through?