From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>, Matthew Wilcox <willy@infradead.org>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Minchan Kim <minchan@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
intel-gfx@lists.freedesktop.org, x86@kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
linux-mm@kvack.org, Matthew Auld <matthew.auld@intel.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [Intel-gfx] [PATCH 3/6] drm/i915: use vmap in shmem_pin_map
Date: Tue, 22 Sep 2020 09:23:59 +0100 [thread overview]
Message-ID: <43d10588-2033-038b-14e4-9f41cd622d7b@linux.intel.com> (raw)
In-Reply-To: <20200922062249.GA30831@lst.de>
On 22/09/2020 07:22, Christoph Hellwig wrote:
> On Mon, Sep 21, 2020 at 08:11:57PM +0100, Matthew Wilcox wrote:
>> This is awkward. I'd like it if we had a vfree() variant which called
>> put_page() instead of __free_pages(). I'd like it even more if we
>> used release_pages() instead of our own loop that called put_page().
>
> Note that we don't need a new vfree variant, we can do this manually if
> we want, take a look at kernel/dma/remap.c. But I thought this code
> intentionally doesn't want to do that to avoid locking in the memory
> for the pages array. Maybe the i915 maintainers can clarify.
+ Chris & Matt who were involved with this part of i915.
If I understood this sub-thread correctly, iterating and freeing the
pages via the vmapped ptes, so no need for a
shmem_read_mapping_page_gfp loop in shmem_unpin_map looks plausible to me.
I did not get the reference to kernel/dma/remap.c though, and also not
sure how to do the error unwind path in shmem_pin_map at which point the
allocated vm area hasn't been fully populated yet. Hand-roll the loop
walking vm area struct in there?
Regards,
Tvrtko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-22 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200918163724.2511-1-hch@lst.de>
[not found] ` <20200918163724.2511-2-hch@lst.de>
2020-09-21 17:42 ` [PATCH 1/6] zsmalloc: switch from alloc_vm_area to get_vm_area Minchan Kim
[not found] ` <20200921181708.GA2067@lst.de>
2020-09-21 18:42 ` Minchan Kim
[not found] ` <20200918163724.2511-4-hch@lst.de>
2020-09-21 19:11 ` [PATCH 3/6] drm/i915: use vmap in shmem_pin_map Matthew Wilcox
[not found] ` <20200922062249.GA30831@lst.de>
2020-09-22 8:23 ` Tvrtko Ursulin [this message]
[not found] ` <20200922143141.GA26637@lst.de>
2020-09-22 16:13 ` [Intel-gfx] " Tvrtko Ursulin
[not found] ` <20200922163346.GA1701@lst.de>
2020-09-22 17:04 ` Tvrtko Ursulin
2020-09-22 11:21 ` Matthew Wilcox
[not found] ` <20200922143906.GB26664@lst.de>
2020-09-22 14:53 ` Matthew Wilcox
[not found] ` <20200918163724.2511-7-hch@lst.de>
2020-09-21 20:44 ` [PATCH 6/6] x86/xen: open code alloc_vm_area in arch_gnttab_valloc boris.ostrovsky
[not found] ` <20200922145819.GA28420@lst.de>
2020-09-22 15:24 ` boris.ostrovsky
[not found] ` <20200922152706.GA30633@lst.de>
2020-09-22 15:34 ` boris.ostrovsky
[not found] ` <20200918163724.2511-5-hch@lst.de>
2020-09-23 9:52 ` [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map Tvrtko Ursulin
[not found] ` <20200923134117.GB9893@lst.de>
2020-09-23 13:58 ` Tvrtko Ursulin
[not found] ` <20200923144455.GA15036@lst.de>
2020-09-24 12:22 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43d10588-2033-038b-14e4-9f41cd622d7b@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.auld@intel.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=peterz@infradead.org \
--cc=sstabellini@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox