From: Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Nicolai Hähnle"
<nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 0/2] drm/ttm, amdgpu: fix use-after-free in recent deadlock fix
Date: Tue, 14 Feb 2017 12:11:18 +0100 [thread overview]
Message-ID: <43fa34bf-a9ca-790f-ff7f-029bda69f5a0@gmail.com> (raw)
In-Reply-To: <20170214091845.1225-1-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 02/14/2017 10:18 AM, Nicolai Hähnle wrote:
> Hi all,
>
> based on my current theory on how a deadlock could happen in the
> buffer allocation code, these two patches should fix the deadlock
> without having a use-after-free.
>
> I'm still working on a way to clean up the ttm_bo_init sequence
> overall, but I'm separating these two out for a hopefully quick fix,
> since in my book use-after-frees are worse than deadlocks.
>
> Samuel, I'd very much appreciate if you could check that the
> deadlocks in Hitman remain fixed with these two patches.
Looks good. Thanks!
>
> Thanks,
> Nicolai
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-02-14 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 9:18 [PATCH 0/2] drm/ttm, amdgpu: fix use-after-free in recent deadlock fix Nicolai Hähnle
[not found] ` <20170214091845.1225-1-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-14 9:18 ` [PATCH 1/2] drm/ttm: never add BO that failed to validate to the LRU list Nicolai Hähnle
2017-02-14 10:38 ` Christian König
[not found] ` <ef1d2448-4296-5eaf-a852-5000bd16a947-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-02-14 11:37 ` Nicolai Hähnle
[not found] ` <3ac4923c-61b9-8ee9-e9cb-d7a60fc51dbf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-14 12:53 ` Christian König
2017-02-14 10:10 ` [PATCH 0/2] drm/ttm, amdgpu: fix use-after-free in recent deadlock fix Samuel Pitoiset
2017-02-14 11:11 ` Samuel Pitoiset [this message]
2017-02-14 9:18 ` [PATCH 2/2] Revert "drm/amdgpu: fix a potential deadlock in amdgpu_bo_create_restricted()" Nicolai Hähnle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43fa34bf-a9ca-790f-ff7f-029bda69f5a0@gmail.com \
--to=samuel.pitoiset-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox