From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56F00C4345F for ; Fri, 19 Apr 2024 07:34:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A4D0010FDC0; Fri, 19 Apr 2024 07:34:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="HMBWiD7o"; dkim-atps=neutral Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E71F10FDC0 for ; Fri, 19 Apr 2024 07:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713512092; bh=DyISyQg7WS1Y2u3RPJgVFUSFFcKg59nL1uyitoy15Lc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HMBWiD7oXdDRH9iC8ExLKlQq5mc7XNH3+hVD1yFkSG3rGi92pQAxlxV0ccasgXLnp SrBwxTUPSiRQNmJAfGlnnJuxOK3kcnZTIm+NuKq8cJa4NQq/6NZjBBpns1SEKdc8uj 2OYNu64SxBUgcE6Hd8FNDHyZcAR4vKVghsHONTo7AS9C/3vkMxJ8gbWS8s15x+Go2a HLdSyhWI7bcxmUeqq+OeCTSuQo/hvWZP0r5dN+fJ2gKB6sLkIJ8n7N+OLM54UQkih1 OOM1iqEEfSv3pQeCDQuV0ospWe4XU8Bkkp1XR7VuHlmNwtPKv93G8x72S9dpq3XqCx RIJlidE3jCP7A== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 867053781104; Fri, 19 Apr 2024 07:34:50 +0000 (UTC) Message-ID: <46549dca-95c0-48f0-acd7-e4a7725437bc@collabora.com> Date: Fri, 19 Apr 2024 09:34:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/17] clk: mediatek: mt8365-mm: fix DPI0 parent To: Alexandre Mergnat , Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Jitao Shi , CK Hu , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Michael Turquette , Stephen Boyd , Fabien Parent , Markus Schneider-Pargmann , Catalin Marinas , Will Deacon Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org References: <20231023-display-support-v3-0-53388f3ed34b@baylibre.com> <20231023-display-support-v3-12-53388f3ed34b@baylibre.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20231023-display-support-v3-12-53388f3ed34b@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 18/04/24 16:17, Alexandre Mergnat ha scritto: > To have a working display through DPI, a workaround has been > implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to > the DPI node. Shortly, that add an extra clock. > > It seems consistent to have the "dpi0_sel" as parent. > Additionnaly, "vpll_dpix" isn't used/managed. > > Then, set the "mm_dpi0_dpi0" parent clock to "dpi0_sel". > > The new clock tree is: > > clk26m > lvdspll > lvdspll_X (2, 4, 8, 16) > dpi0_sel > mm_dpi0_dpi0 > > Fixes: d46adccb7966 ("clk: mediatek: add driver for MT8365 SoC") > Signed-off-by: Alexandre Mergnat I wonder what CLK_TOP_VPLL_DPIX_EN is for, but since you've ruled it out by removing the dependency, this clock is 100% being disabled because unused and the DPI interface clearly still works. I also wonder if that clock is getting en/disabled by HW control mechanism... ...because that'd make sense, as this is .. well, a DPI clock. That's just out of curiosity though, as I'd really like to understand whenwhatwhy for stuff.... In any case, whether you have an answer or not, this commit is: Reviewed-by: AngeloGioacchino Del Regno Cheers!