From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies
Date: Tue, 21 Dec 2021 11:11:23 +0000 [thread overview]
Message-ID: <47327eb4-cf45-0681-d56f-bc877d40a424@intel.com> (raw)
In-Reply-To: <20211217145228.10987-2-thomas.hellstrom@linux.intel.com>
On 17/12/2021 14:52, Thomas Hellström wrote:
> Since the gt migration code was using only a single fence for
> dependencies, these were collected in a dma_fence_array. However, it
> turns out that it's illegal to use some dma_fences in a dma_fence_array,
> in particular other dma_fence_arrays and dma_fence_chains, and this
> causes trouble for us moving forward.
>
> Have the gt migration code instead take a const struct i915_deps for
> dependencies. This means we can skip the dma_fence_array creation
> and instead pass the struct i915_deps instead to circumvent the
> problem.
>
> v2:
> - Make the prev_deps() function static. (kernel test robot <lkp@intel.com>)
> - Update the struct i915_deps kerneldoc.
>
> Fixes: 5652df829b3c ("drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous")
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2021-12-21 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 14:52 [PATCH v3 0/7] drm/i915: Asynchronous vma unbinding Thomas Hellström
2021-12-17 14:52 ` [PATCH v3 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies Thomas Hellström
2021-12-21 11:11 ` Matthew Auld [this message]
2021-12-17 14:52 ` [PATCH v3 2/7] drm/i915: Break out the i915_deps utility Thomas Hellström
2021-12-21 11:13 ` Matthew Auld
2021-12-17 14:52 ` [PATCH v3 3/7] drm/i915: Require the vm mutex for i915_vma_bind() Thomas Hellström
2021-12-21 11:32 ` Matthew Auld
2021-12-17 14:52 ` [PATCH v3 4/7] drm/i915: Initial introduction of vma resources Thomas Hellström
2021-12-17 14:52 ` [PATCH v3 5/7] drm/i915: Use the vma resource as argument for gtt binding / unbinding Thomas Hellström
2021-12-17 14:52 ` [PATCH v3 6/7] drm/i915: Use vma resources for async unbinding Thomas Hellström
2021-12-21 14:02 ` Matthew Auld
2021-12-21 16:07 ` Thomas Hellström
2021-12-21 17:08 ` Matthew Auld
2021-12-17 14:52 ` [PATCH v3 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47327eb4-cf45-0681-d56f-bc877d40a424@intel.com \
--to=matthew.auld@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).