From: John Hubbard <jhubbard@nvidia.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH] nouveau: no need to check return value of debugfs_create functions
Date: Thu, 13 Feb 2020 15:23:23 -0800 [thread overview]
Message-ID: <482aafcb-a50f-1ec5-4e1b-3a1fb799464f@nvidia.com> (raw)
In-Reply-To: <20200213223931.GA3877216@kroah.com>
On 2/13/20 2:39 PM, Greg Kroah-Hartman wrote:
> On Thu, Feb 13, 2020 at 02:30:09PM -0800, John Hubbard wrote:
>> On 2/9/20 2:55 AM, Greg Kroah-Hartman wrote:
>>> When calling debugfs functions, there is no need to ever check the
>>> return value. The function can work or not, but the code logic should
>>> never do something different based on this.
>>>
>>
>> Should we follow that line of reasoning further, and simply return void
>> from the debugfs functions--rather than playing whack-a-mole with this
>> indefinitely?
>
> That is what we (well I) have been doing. Look at all of the changes
> that have happened to include/linux/debugfs.h over the past few
> releases. I'm slowly winnowing down the api to make it impossible to
> get wrong for this type of thing, and am almost there.
>
Oops, I see now that you have already been very busy with this. :)
Looking good...
thanks,
--
John Hubbard
NVIDIA
> DRM is the big fish left to tackle, I have submitted some patches in the
> past, but lots more cleanup needs to be done to get them into mergable
> shape. I just need to find the time...
>>
> thanks,
>
> greg k-h
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-13 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 10:55 [PATCH] nouveau: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2020-02-10 8:25 ` [Nouveau] " Ben Skeggs
2020-02-13 22:30 ` John Hubbard
2020-02-13 22:39 ` Greg Kroah-Hartman
2020-02-13 23:23 ` John Hubbard [this message]
2020-02-13 23:30 ` Daniel Vetter
2020-02-13 23:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482aafcb-a50f-1ec5-4e1b-3a1fb799464f@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox