Re: [PATCH 00/13] Support DSI output on rk3576 and roc-rk3576-pc board

["Heiko Stübner" <heiko@sntech.de>]

Am Dienstag, 8. Juli 2025, 15:23:32 Mitteleuropäische Sommerzeit schrieb Rob Herring (Arm):
> 
> On Mon, 07 Jul 2025 18:48:53 +0200, Heiko Stuebner wrote:
> > This enables all the necesary bits and bindings to get display output
> > on the dm-m10r800-v3s addon module for the Firefly roc-rk3576-pc board.
> > 
> > A bit of cleanup of the ili9881c, because the driver was still trying
> > to send dcs commands when the underlying DSI driver might have already
> > switched to video-mode, which caused me quite a bit of headache until
> > I realized this being the culprit for my garbled display output :-) .
> > 
> > Only the last patch has a dependency on Nicolas' pwm series [0]
> > everything else, is directly usable.
> > 
> > 
> > [0] https://lore.kernel.org/lkml/20250602-rk3576-pwm-v2-0-a6434b0ce60c@collabora.com/
> > 
> > Guochun Huang (1):
> >   drm/rockchip: dsi2: add support rk3576
> > 
> > Heiko Stuebner (12):
> >   drm/panel: ilitek-ili9881c: turn off power-supply when init fails
> >   drm/panel: ilitek-ili9881c: move display_on/_off dcs calls to
> >     (un-)prepare
> >   drm/panel: ilitek-ili9881c: convert (un-)prepare to
> >     mipi_dsi_multi_context
> >   dt-bindings: vendor-prefixes: Add prefix for Shenzhen Bestar
> >     Electronic
> >   dt-bindings: display: ili9881c: Add Bestar BSD1218-A101KL68 LCD panel
> >   drm/panel: ilitek-ili9881c: Add Bestar BSD1218-A101KL68 support
> >   dt-bindings: soc: rockchip: add rk3576 mipi dcphy syscon
> >   dt-bindings: display: rockchip: Add rk3576 to RK3588 DW DSI2
> >     controller schema
> >   arm64: dts: rockchip: add mipi-dcphy to rk3576
> >   arm64: dts: rockchip: add the dsi controller to rk3576
> >   arm64: dts: rockchip: add vcc3v3-lcd-s0 regulator to roc-rk3576-pc
> >   arm64: dts: rockchip: add dm-m10r800-v3s overlay for roc-rk3576-pc
> > 
> >  .../display/panel/ilitek,ili9881c.yaml        |   1 +
> >  .../rockchip/rockchip,rk3588-mipi-dsi2.yaml   |   1 +
> >  .../devicetree/bindings/soc/rockchip/grf.yaml |   1 +
> >  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
> >  arch/arm64/boot/dts/rockchip/Makefile         |   5 +
> >  .../rk3576-roc-pc-dm-m10r800-v3s.dtso         | 134 ++++++++
> >  .../arm64/boot/dts/rockchip/rk3576-roc-pc.dts |  16 +
> >  arch/arm64/boot/dts/rockchip/rk3576.dtsi      |  50 +++
> >  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 301 ++++++++++++++----
> >  .../gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c  |  21 ++
> >  10 files changed, 475 insertions(+), 57 deletions(-)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-roc-pc-dm-m10r800-v3s.dtso
> > 
> > --
> > 2.47.2
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/v6.16-rc1-17-g63289206e26f (best guess, 8/9 blobs matched)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250707164906.1445288-1-heiko@sntech.de:
> 
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm1:pwm1m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm0:pwm0m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:1:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1_sda:i3c1_sdam1-pu:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch4:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch0:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch6:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
> 	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dtb: syscon@26034000 (rockchip,rk3576-dcphy-grf): clocks: False schema does not allow [[21, 492]]
> 	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: syscon@26034000 (rockchip,rk3576-dcphy-grf): clocks: False schema does not allow [[20, 492]]
> 	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: syscon@26034000 (rockchip,rk3576-dcphy-grf): clocks: False schema does not allow [[21, 492]]
> 	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dtb: syscon@26034000 (rockchip,rk3576-dcphy-grf): clocks: False schema does not allow [[21, 492]]
> 	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#

that stems from the depdency on the pwm-series of only the last patch in
this series - see cover-letter above.


Heiko