From: Jiri Slaby <jirislaby@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Kristian Høgsberg" <krh@bitplanet.net>,
"David Airlie" <airlied@linux.ie>,
"Jesse Barnes" <jbarnes@virtuousgeek.org>,
dri-devel@lists.sourceforge.net
Subject: Re: [patch] i915: missing unlock on error path
Date: Fri, 07 May 2010 10:43:59 +0200 [thread overview]
Message-ID: <4BE3D2CF.3090809@gmail.com> (raw)
In-Reply-To: <20100507083701.GW27064@bicker>
On 05/07/2010 10:37 AM, Dan Carpenter wrote:
> There was a missing mutex_unlock(&dev->struct_mutex) on this error path.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I thought Jiri sent this patch earlier but a google search for "stanse
> struct_mutex i965_reset" didn't find any patches, so I'm resending.
I don't remember either. I found I had only fixed potential NULL-deref
in i915_suspend.
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 01e91ea..a605c87 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags)
> }
> } else {
> DRM_ERROR("Error occurred. Don't know how to reset this chip.\n");
> + mutex_unlock(&dev->struct_mutex);
> return -ENODEV;
> }
>
--
js
------------------------------------------------------------------------------
--
next prev parent reply other threads:[~2010-05-07 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 8:37 [patch] i915: missing unlock on error path Dan Carpenter
2010-05-07 8:43 ` Jiri Slaby [this message]
2010-05-26 21:18 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE3D2CF.3090809@gmail.com \
--to=jirislaby@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=error27@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=krh@bitplanet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox