From: Prarit Bhargava <prarit@redhat.com>
To: Alan Coopersmith <alan.coopersmith@oracle.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH]: i915: Fix missing linux/types.h warning in header
Date: Thu, 27 May 2010 11:39:17 -0400 [thread overview]
Message-ID: <4BFE9225.1060408@redhat.com> (raw)
In-Reply-To: <4BFE8FCA.5020700@oracle.com>
>
> Prarit Bhargava wrote:
>
>> Fixes warning:
>>
>> /usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include<linux/types.h>
>>
>> Signed-off-by: Prarit Bhargava<prarit@redhat.com>
>>
>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>> index b64a8d7..5cf7f5b 100644
>> --- a/include/drm/i915_drm.h
>> +++ b/include/drm/i915_drm.h
>> @@ -27,6 +27,7 @@
>> #ifndef _I915_DRM_H_
>> #define _I915_DRM_H_
>>
>> +#include<linux/types.h>
>> #include "drm.h"
>>
> drm.h includes it, safely tucked inside #ifdef __linux__ so it won't
> break BSD& OpenSolaris DRI builds - isn't that good enough?
>
Hmm ... it doesn't appear to be :/ From a week-old compile of linux-next
/home/linux-next/usr/include/drm/drm_mode.h:84: found __[us]{8,16,32,64}
type without #include <linux/types.h>
/home/linux-next/usr/include/drm/i915_drm.h:119: found
__[us]{8,16,32,64} type without #include <linux/types.h>
/home/linux-next/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64}
type without #include <linux/types.h>
/home/linux-next/usr/include/drm/radeon_drm.h:758: found
__[us]{8,16,32,64} type without #include <linux/types.h>
/home/linux-next/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64}
type without #include <linux/types.h>
It could certainly be that the error check is busted ...
P.
>
prev parent reply other threads:[~2010-05-27 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 15:23 [PATCH]: i915: Fix missing linux/types.h warning in header Prarit Bhargava
2010-05-27 15:29 ` Alan Coopersmith
2010-05-27 15:39 ` Prarit Bhargava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFE9225.1060408@redhat.com \
--to=prarit@redhat.com \
--cc=alan.coopersmith@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox