From: Thomas Hellstrom <thellstrom@vmware.com>
To: "airlied@redhat.com" <airlied@redhat.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/ttm: Fix missing return
Date: Fri, 01 Oct 2010 12:14:28 +0200 [thread overview]
Message-ID: <4CA5B484.2010002@vmware.com> (raw)
In-Reply-To: <1285920578-10101-1-git-send-email-thellstrom@vmware.com>
Hmm. Forget this patch! I must have been extremely tired today. A new
one coming up in a moment.
/Thomas
On 10/01/2010 10:09 AM, Thomas Hellstrom wrote:
> The commit "drm/ttm: Fix two race conditions"
> was missing a return statement in a very unlikely code path.
>
> Signed-off-by: Thomas Hellstrom<thellstrom@vmware.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index b98cb2c..d6000d7 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -524,6 +524,7 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, bool remove_all)
> atomic_set(&bo->reserved, 0);
> wake_up_all(&bo->event_queue);
> spin_unlock(&glob->lru_lock);
> + return 0;
> }
>
> put_count = ttm_bo_del_from_lru(bo);
>
prev parent reply other threads:[~2010-10-01 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 8:09 [PATCH] drm/ttm: Fix missing return Thomas Hellstrom
2010-10-01 10:14 ` Thomas Hellstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA5B484.2010002@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox