From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thomas@shipmail.org>
Subject: Re: [PATCH 10/49] drivers/gpu: Use vzalloc
Date: Fri, 05 Nov 2010 10:29:32 +0100
Message-ID: <4CD3CE7C.4040407@shipmail.org>
References: <alpine.DEB.2.00.1011031108260.11625@router.home>
	<82d9fb31aa5f4e28acfda333331a30ef382d27b9.1288925424.git.joe@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com
	[65.115.85.69])
	by gabe.freedesktop.org (Postfix) with ESMTP id D07579E760
	for <dri-devel@lists.freedesktop.org>;
	Fri,  5 Nov 2010 02:29:44 -0700 (PDT)
In-Reply-To: <82d9fb31aa5f4e28acfda333331a30ef382d27b9.1288925424.git.joe@perches.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 11/05/2010 04:07 AM, Joe Perches wrote:
> Signed-off-by: Joe Perches<joe@perches.com>
>    
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>

> ---
>   drivers/gpu/drm/via/via_dmablit.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c
> index 9b5b4d9..3e038a3 100644
> --- a/drivers/gpu/drm/via/via_dmablit.c
> +++ b/drivers/gpu/drm/via/via_dmablit.c
> @@ -235,9 +235,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg,  drm_via_dmablit_t *xfer)
>   	vsg->num_pages = VIA_PFN(xfer->mem_addr + (xfer->num_lines * xfer->mem_stride - 1)) -
>   		first_pfn + 1;
>
> -	if (NULL == (vsg->pages = vmalloc(sizeof(struct page *) * vsg->num_pages)))
> +	vsg->pages = vzalloc(sizeof(struct page *) * vsg->num_pages);
> +	if (NULL == vsg->pages)
>   		return -ENOMEM;
> -	memset(vsg->pages, 0, sizeof(struct page *) * vsg->num_pages);
>   	down_read(&current->mm->mmap_sem);
>   	ret = get_user_pages(current, current->mm,
>   			     (unsigned long)xfer->mem_addr,
>