Re: [PATCH 0/1][-next] drm/radeon: Move over to the ttm execbuf utilities

[Thomas Hellstrom <thellstrom@vmware.com>]

On 11/17/2010 08:11 PM, Jerome Glisse wrote:
> On Wed, Nov 17, 2010 at 7:38 AM, Thomas Hellstrom<thellstrom@vmware.com>  wrote:
>    
>> The patch is compile-tested ony and not very intrusive. It should be applied
>> on top of the latest TTM patches.
>>
>> Besides reduced CPU-usage on SMP kernels, there is the benefit of using
>> shared code. Will also ease implementation of concurrent CS due to the
>> deadlock prevention mechanisms.
>>
>> If time allows, I'll write a patch to do the same on Novueau, although
>> Novueau does things a little differently than the other TTM-aware drivers.
>>
>>
>>      
> Test on on rs780 and it seems to work properly, but i haven't really
> stress test it beside few games. I see no perf or CPU use improvement
> but it could very well be hidden by others cost.
>    

Probably. I would have expected that a CPU-bound app, for example ipers 
if running at 100% CPU (before the patch) would've seen some frame rate 
improvements..


> Note that we can't really have concurrent cs due to the way checking
> work. Anyway you could add my reviewed by.
>    

Thanks, Jerome.
/Thomas

> Reviewed-by: Jerome Glisse<jglisse@redhat.com>
> Tested-by: Jerome Glisse<jglisse@redhat.com>
>