From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?IkRhdmlkIE3DvGxsZXIgKEVMU09GVCBBRyki?= Subject: [Regression] [PATCH] intel_crt_detect_ddc() seems to be broken for DVI-I Date: Thu, 06 Jan 2011 12:11:38 +0100 Message-ID: <4D25A36A.6030605@elsoft.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020809070509010308040402" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.sourceforge.net List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --------------020809070509010308040402 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello Since Linux 2.6.36 the digital output on my system (855GME + DVI-I) is not working any longer. The analog output is always activated regardless of the type of monitor attached. The culprit seems to be intel_crt_detect_ddc(), which returns true as soon as an ACK from the EDID device is received. Obviously this approach does not work with DVI-I where the analog and digital outputs share a common DDC bus. The patch below adds an additional check to make sure that there is really an analog device attached (similar to the "Mac mini hack" in intel_sdvo.c) --------------020809070509010308040402 Content-Type: text/plain; name="intel_crt.c.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="intel_crt.c.patch" U2lnbmVkLW9mZi1ieTogRGF2aWQgTcO8bGxlciA8ZC5tdWVsbGVyQGVsc29mdC5jaD4KCmRp ZmYgLWRwdXJOIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYwotLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9jcnQuYwkyMDExLTAxLTA1IDEwOjM1OjE4LjQ0OTAwMDAyMyArMDEwMAorKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYwkyMDExLTAxLTA2IDEyOjE2OjQ3LjYz MDk5ODk1MiArMDEwMApAQCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUgImRybS5oIgogI2lu Y2x1ZGUgImRybV9jcnRjLmgiCiAjaW5jbHVkZSAiZHJtX2NydGNfaGVscGVyLmgiCisjaW5j bHVkZSAiZHJtX2VkaWQuaCIKICNpbmNsdWRlICJpbnRlbF9kcnYuaCIKICNpbmNsdWRlICJp OTE1X2RybS5oIgogI2luY2x1ZGUgImk5MTVfZHJ2LmgiCkBAIC0yODcsOCArMjg4LDkgQEAg c3RhdGljIGJvb2wgaW50ZWxfY3J0X2RkY19wcm9iZShzdHJ1Y3QgZAogCXJldHVybiBpMmNf dHJhbnNmZXIoJmRldl9wcml2LT5nbWJ1c1tkZGNfYnVzXS5hZGFwdGVyLCBtc2dzLCAxKSA9 PSAxOwogfQogCi1zdGF0aWMgYm9vbCBpbnRlbF9jcnRfZGV0ZWN0X2RkYyhzdHJ1Y3QgaW50 ZWxfY3J0ICpjcnQpCitzdGF0aWMgYm9vbCBpbnRlbF9jcnRfZGV0ZWN0X2RkYyhzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQogeworCXN0cnVjdCBpbnRlbF9jcnQgKmNydCA9 IGludGVsX2F0dGFjaGVkX2NydChjb25uZWN0b3IpOwogCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IGNydC0+YmFzZS5iYXNlLmRldi0+ZGV2X3ByaXZhdGU7CiAKIAkv KiBDUlQgc2hvdWxkIGFsd2F5cyBiZSBhdCAwLCBidXQgY2hlY2sgYW55d2F5ICovCkBAIC0z MDEsOCArMzAzLDI2IEBAIHN0YXRpYyBib29sIGludGVsX2NydF9kZXRlY3RfZGRjKHN0cnVj dAogCX0KIAogCWlmIChpbnRlbF9kZGNfcHJvYmUoJmNydC0+YmFzZSwgZGV2X3ByaXYtPmNy dF9kZGNfcGluKSkgewotCQlEUk1fREVCVUdfS01TKCJDUlQgZGV0ZWN0ZWQgdmlhIEREQzow eDUwIFtFRElEXVxuIik7Ci0JCXJldHVybiB0cnVlOworCQlzdHJ1Y3QgZWRpZCAqZWRpZDsK KwkJYm9vbCBpc19kaWdpdGFsID0gZmFsc2U7CisKKwkJZWRpZCA9IGRybV9nZXRfZWRpZChj b25uZWN0b3IsCisJCQkmZGV2X3ByaXYtPmdtYnVzW2Rldl9wcml2LT5jcnRfZGRjX3Bpbl0u YWRhcHRlcik7CisJCS8qCisJCSAqIFRoaXMgbWF5IGJlIGEgRFZJLUkgY29ubmVjdG9yIHdp dGggYSBzaGFyZWQgRERDCisJCSAqIGxpbmsgYmV0d2VlbiBhbmFsb2cgYW5kIGRpZ2l0YWwg b3V0cHV0cywgc28gd2UKKwkJICogaGF2ZSB0byBjaGVjayB0aGUgRURJRCBpbnB1dCBzcGVj IG9mIHRoZSBhdHRhY2hlZCBkZXZpY2UuCisJCSAqLworCQlpZiAoZWRpZCAhPSBOVUxMKSB7 CisJCQlpc19kaWdpdGFsID0gZWRpZC0+aW5wdXQgJiBEUk1fRURJRF9JTlBVVF9ESUdJVEFM OworCQkJY29ubmVjdG9yLT5kaXNwbGF5X2luZm8ucmF3X2VkaWQgPSBOVUxMOworCQkJa2Zy ZWUoZWRpZCk7CisJCX0KKworCQlpZiAoIWlzX2RpZ2l0YWwpIHsKKwkJCURSTV9ERUJVR19L TVMoIkNSVCBkZXRlY3RlZCB2aWEgRERDOjB4NTAgW0VESURdXG4iKTsKKwkJCXJldHVybiB0 cnVlOworCQl9CiAJfQogCiAJcmV0dXJuIGZhbHNlOwpAQCAtNDU4LDcgKzQ3OCw3IEBAIGlu dGVsX2NydF9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmMKIAkJfQogCX0KIAotCWlm IChpbnRlbF9jcnRfZGV0ZWN0X2RkYyhjcnQpKQorCWlmIChpbnRlbF9jcnRfZGV0ZWN0X2Rk Yyhjb25uZWN0b3IpKQogCQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQ7CiAK IAlpZiAoIWZvcmNlKQpAQCAtNDcyLDcgKzQ5Miw3IEBAIGludGVsX2NydF9kZXRlY3Qoc3Ry dWN0IGRybV9jb25uZWN0b3IgKmMKIAkJY3J0YyA9IGludGVsX2dldF9sb2FkX2RldGVjdF9w aXBlKCZjcnQtPmJhc2UsIGNvbm5lY3RvciwKIAkJCQkJCSAgTlVMTCwgJmRwbXNfbW9kZSk7 CiAJCWlmIChjcnRjKSB7Ci0JCQlpZiAoaW50ZWxfY3J0X2RldGVjdF9kZGMoY3J0KSkKKwkJ CWlmIChpbnRlbF9jcnRfZGV0ZWN0X2RkYyhjb25uZWN0b3IpKQogCQkJCXN0YXR1cyA9IGNv bm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkOwogCQkJZWxzZQogCQkJCXN0YXR1cyA9IGludGVs X2NydF9sb2FkX2RldGVjdChjcnRjLCBjcnQpOwo= --------------020809070509010308040402 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl --------------020809070509010308040402 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel --------------020809070509010308040402 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --------------020809070509010308040402--