From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [PATCH] i915: slab shrinker have to return -1 if it cant shrink any objects Date: Thu, 14 Jul 2011 11:48:08 +0900 Message-ID: <4E1E58E8.6040200@jp.fujitsu.com> References: <4E0444CA.3080407@jp.fujitsu.com> <1309424153_44559@CP5-2952> <4E1C15B2.9020800@jp.fujitsu.com> <4E1CE48C.2070402@jp.fujitsu.com> <4E1D550A.80301@jp.fujitsu.com> <20110713104236.GS23038@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110713104236.GS23038@dastard> Sender: linux-kernel-owner@vger.kernel.org To: david@fromorbit.com Cc: chris@chris-wilson.co.uk, keithp@keithp.com, linux-kernel@vger.kernel.org, airlied@linux.ie, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org >> If you are thinking the shrinker protocol is too complicated, doc update >> patch is really welcome. > > Slab shrinkers have a nasty, crappy interface and the shrink_slab() > code is full of bugs. Rather that telling people to "update the > documentation" because it's too complex, how about we fix the > interface and the bugs? If you can take your time for that, I don't hesitate to help you. ;)