dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jerome Glisse <j.glisse@gmail.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	bskeggs@redhat.com
Subject: Re: [PATCH] fixes to drm-next - TTM DMA code (v1)
Date: Mon, 19 Dec 2011 20:51:15 +0100	[thread overview]
Message-ID: <4EEF95B3.9000204@vmware.com> (raw)
In-Reply-To: <20111213164031.GA32052@phenom.dumpdata.com>

On 12/13/2011 05:40 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 13, 2011 at 05:23:30PM +0100, Thomas Hellstrom wrote:
>    
>> On 12/13/2011 05:07 PM, Jerome Glisse wrote:
>>      
>>> On Mon, Dec 12, 2011 at 03:09:26PM -0500, Konrad Rzeszutek Wilk wrote:
>>>        
>>>> Jerome pointed me to some accounting error in the DMA API debugging code and
>>>> while I can't figure it out yet, I did notice some extreme slowness - which
>>>> is due to the nouveau driver calling the unpopulate (now that unbind +
>>>> unpopulate are squashed) quite a lot (this is using Gnome Shell - I think GNOME2
>>>> did not have those issues but I can't recall).
>>>>
>>>> Anyhow these patches fix the 50% perf regression I saw and also some minor bugs
>>>> that I noticed.
>>>>
>>>>          
>>> Gonna review those today and test them.
>>>
>>> Cheers,
>>> Jerome
>>>        
>> Hi!
>>
>> I'm not whether any drivers are still using the AGP backend?
>>      
> Uh, probably they do if the cards are AGP?
> The problem I encountered was with an PCIe Nvidia card:
>
> 01:00.0 VGA compatible controller: nVidia Corporation G84 [GeForce 8600 GT] (rev a1
>
>    
>> Calling unpopulate / (previous clear) each time unbind is done
>> should be quite
>> inefficient with that one, as AGP sets up its own data structures
>> and copies page tables
>> on each populate. That should really be avoided unless there is a
>> good reason to have it.
>>      
> nouveau_bo_rd32 and nv50_crtc_cursor_set showed up as the callers that
> were causing the unpopulate calls. It did happen _a lot_ when I moved the
> cursor madly.
>    

Konrad, Jerome
Was there a resolution to this. If the ttm_tt rewrite results in 
unpopulate being called more often than before,
and that causes performance regressions, that must be fixed as soon as 
possible.

/Thomas



> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>    

  reply	other threads:[~2011-12-19 19:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 20:09 [PATCH] fixes to drm-next - TTM DMA code (v1) Konrad Rzeszutek Wilk
2011-12-12 20:09 ` [PATCH 1/3] drm/ttm/dma: Only call set_pages_array_wb when the page is not in WB pool Konrad Rzeszutek Wilk
2011-12-12 20:09 ` [PATCH 2/3] drm/ttm/dma: Fix accounting error when calling ttm_mem_global_free_page Konrad Rzeszutek Wilk
2011-12-21 15:17   ` Jerome Glisse
2011-12-21 15:30     ` Konrad Rzeszutek Wilk
2011-12-12 20:09 ` [PATCH 3/3] drm/ttm/dma: Optimize when free-ing the recycled page pool Konrad Rzeszutek Wilk
2011-12-21 15:22   ` Jerome Glisse
2011-12-13 16:07 ` [PATCH] fixes to drm-next - TTM DMA code (v1) Jerome Glisse
2011-12-13 16:23   ` Thomas Hellstrom
2011-12-13 16:40     ` Konrad Rzeszutek Wilk
2011-12-19 19:51       ` Thomas Hellstrom [this message]
2011-12-20 17:35         ` Konrad Rzeszutek Wilk
2012-01-05 19:37       ` Jerome Glisse
2011-12-13 22:09     ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEF95B3.9000204@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j.glisse@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox