dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: James Simmons <jsimmons@infradead.org>
Cc: DRI development list <dri-devel@lists.freedesktop.org>
Subject: Re: TTM and AGP conflicts
Date: Mon, 09 Jan 2012 10:07:02 +0100	[thread overview]
Message-ID: <4F0AAE36.6080909@vmware.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1201061550250.14746@casper.infradead.org>

On 01/06/2012 04:51 PM, James Simmons wrote:
>    
>>>> You can achieve what you want by either adding a new domain so you would have
>>>> system, vram, agp, pcidma and object can be bound to one and only one. Or you
>>>> can hack your own agp ttm backend that could bind bo to agp or pci or
>>>> both at the same time depending on what you want to achieve.
>>>>          
>>> The question is how does one know which domain you want in tt_create.
>>> Currenty drivers are using there dev_priv but if you have have more than
>>> one option available how does one choose? Would you be okay with passing
>>> in a domain flag?
>>>
>>>        
>> Well i agree that something would be usefull there so the driver know
>> which bind/unbind function it should use. Thomas i would prefer
>> passing the bo to the tt_create callback but a flag is the minimum we
>> need.
>>      
> We can discuss this after the merge widow. Jerome your patch does fix a
> regression whereas my proposal is a enhancement.
>    

..Back from parental leave.

I'm not 100% sure I understand the problem correctly, but I assume the 
problem is that
you receive a "bind" request for pages allocated out of the wrong DMA 
pool? Is that correct?

In that case we need to make both the following happen:
1) The backend should be required to supply a fallback that can bind 
anyway by allocating the correct page type and copy.
2) I'm OK with providing a hint to tt_create. IIRC we're passing bo::mem 
to tt_bind. Would it be ok to pass the same to tt_create?

/Thomas

  reply	other threads:[~2012-01-09  9:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 21:56 TTM and AGP conflicts James Simmons
2011-12-22 22:00 ` Alex Deucher
2011-12-23  1:19   ` James Simmons
2011-12-24  3:44     ` Jerome Glisse
2012-01-03 22:43     ` Jerome Glisse
2012-01-03 22:59       ` Konrad Rzeszutek Wilk
2012-01-06  2:26         ` Konrad Rzeszutek Wilk
2012-01-04 15:36       ` James Simmons
2012-01-04 15:49         ` Jerome Glisse
2012-01-04 16:04           ` James Simmons
2012-01-04 16:35             ` Jerome Glisse
2012-01-06 15:51               ` James Simmons
2012-01-09  9:07                 ` Thomas Hellstrom [this message]
2012-01-09 15:21                   ` Jerome Glisse
2012-01-09 16:46                   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0AAE36.6080909@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsimmons@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox