From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH] drm/radeon/kms: need to set up ss on DP bridges as well Date: Sun, 29 Apr 2012 16:08:06 +0200 Message-ID: <4F9D4B46.1020609@vodafone.de> References: <1335561539-2227-1-git-send-email-alexdeucher@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D5E39F394 for ; Sun, 29 Apr 2012 07:08:13 -0700 (PDT) In-Reply-To: <1335561539-2227-1-git-send-email-alexdeucher@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: alexdeucher@gmail.com Cc: Alex Deucher , stable@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 27.04.2012 23:18, alexdeucher@gmail.com wrote: > From: Alex Deucher > > Makes Nutmeg DP to VGA bridges work for me. > > Fixes: > https://bugs.freedesktop.org/show_bug.cgi?id=3D42490 > > Noticed by Jerome Glisse > > Signed-off-by: Alex Deucher > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/radeon/atombios_crtc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/rad= eon/atombios_crtc.c > index c5c31e0..af1054f 100644 > --- a/drivers/gpu/drm/radeon/atombios_crtc.c > +++ b/drivers/gpu/drm/radeon/atombios_crtc.c > @@ -958,8 +958,8 @@ static void atombios_crtc_set_pll(struct drm_crtc *cr= tc, struct drm_display_mode > break; > } > > - if (radeon_encoder->active_device& > - (ATOM_DEVICE_LCD_SUPPORT | ATOM_DEVICE_DFP_SUPPORT)) { > + if ((radeon_encoder->active_device& (ATOM_DEVICE_LCD_SUPPORT | ATOM_DE= VICE_DFP_SUPPORT)) || > + (radeon_encoder_get_dp_bridge_encoder_id(encoder) !=3D ENCODER_OBJE= CT_ID_NONE)) { > struct radeon_encoder_atom_dig *dig =3D radeon_encoder->enc_priv; > struct drm_connector *connector =3D > radeon_get_connector_for_encoder(encoder); Also gets the NUTMEG bridge on my llano board working, but DP on trinity = is still problematic. Anyway: Tested-by: Christian K=F6nig