From: Adam Jackson <ajax@redhat.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 02/14] drm: handle HDP and polled connectors separately
Date: Fri, 25 May 2012 13:26:46 -0400 [thread overview]
Message-ID: <4FBFC0D6.5050200@redhat.com> (raw)
In-Reply-To: <1337887609-14703-3-git-send-email-daniel.vetter@ffwll.ch>
On 5/24/12 3:26 PM, Daniel Vetter wrote:
> Instead of reusing the polling code for hdp handling, split them up.
> This has a few consequences:
> - Don't touch HDP capable connectors in the poll loop.
> - Only touch HDP capable connectors in drm_helper_hpd_irq_event.
> - Run the HDP handling directly instead of going through a work item -
> all callers already call drm_helper_hpd_irq_event from process
> context without holding the mode_config mutex.
"HPD".
> - /* if this is HPD or polled don't check it -
> - TV out for instance */
> - if (!connector->polled)
> + /* Ignore HDP capable connectors and connectors where we don't
> + * want any hotplug detection at all for polling. */
> + if (!connector->polled || connector->polled == DRM_CONNECTOR_POLL_HPD)
Here too. Also in the subject.
- ajax
next prev parent reply other threads:[~2012-05-25 17:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 19:26 [RFC] [PATCH 00/14] HPD/connector-polling rework Daniel Vetter
2012-05-24 19:26 ` [PATCH 01/14] drm: extract drm_kms_helper_hotplug_event Daniel Vetter
2012-05-24 19:26 ` [PATCH 02/14] drm: handle HDP and polled connectors separately Daniel Vetter
2012-05-25 17:26 ` Adam Jackson [this message]
2012-05-29 7:50 ` [PATCH] drm: handle HPD " Daniel Vetter
2012-05-29 9:22 ` [PATCH 1/2] " Daniel Vetter
2012-05-29 9:22 ` [PATCH 2/2] drm: run the hpd irq event code directly Daniel Vetter
2012-05-24 19:26 ` [PATCH 03/14] drm: introduce DRM_CONNECTOR_POLL_FORCE Daniel Vetter
2012-05-25 10:54 ` [PATCH] " Daniel Vetter
2012-05-24 19:26 ` [PATCH 04/14] drm/i915: set POLL_FORCE for sdvo outputs Daniel Vetter
2012-05-24 19:26 ` [PATCH 05/14] drm: properly init/reset connector status Daniel Vetter
2012-05-24 19:26 ` [PATCH 06/14] drm: kill unnecessary calls to connector->detect Daniel Vetter
2012-05-24 19:26 ` [PATCH 07/14] drm: don't start the poll engine in probe_single_connector Daniel Vetter
2012-05-24 19:26 ` [PATCH 08/14] drm: don't unnecessarily enable the polling work Daniel Vetter
2012-05-24 19:26 ` [PATCH 09/14] drm: don't poll forced connectors Daniel Vetter
2012-05-24 19:26 ` [PATCH 10/14] drm/i915: cache crt edid Daniel Vetter
2012-05-24 19:26 ` [PATCH 11/14] drm/i915: cache dp edid Daniel Vetter
2012-05-24 19:26 ` [PATCH 12/14] drm/i915: cache hdmi edid Daniel Vetter
2012-05-24 19:26 ` [PATCH 13/14] drm/i915/sdvo: implement correct return value for ->get_modes Daniel Vetter
2012-05-24 19:26 ` [PATCH 14/14] drm/i915: s/mdelay/msleep/ in the sdvo detect function Daniel Vetter
2012-05-31 8:29 ` Daniel Vetter
2012-05-31 19:24 ` Singh, Satyeshwar
2012-05-31 19:36 ` Daniel Vetter
2012-10-04 16:07 ` [RFC] [PATCH 00/14] HPD/connector-polling rework Alex Deucher
2012-10-04 17:16 ` Daniel Vetter
2012-10-04 17:43 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBFC0D6.5050200@redhat.com \
--to=ajax@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).