From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [Intel-gfx] [PATCH 02/14] drm: handle HDP and polled connectors separately Date: Fri, 25 May 2012 13:26:46 -0400 Message-ID: <4FBFC0D6.5050200@redhat.com> References: <1337887609-14703-1-git-send-email-daniel.vetter@ffwll.ch> <1337887609-14703-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1337887609-14703-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org On 5/24/12 3:26 PM, Daniel Vetter wrote: > Instead of reusing the polling code for hdp handling, split them up. > This has a few consequences: > - Don't touch HDP capable connectors in the poll loop. > - Only touch HDP capable connectors in drm_helper_hpd_irq_event. > - Run the HDP handling directly instead of going through a work item - > all callers already call drm_helper_hpd_irq_event from process > context without holding the mode_config mutex. "HPD". > - /* if this is HPD or polled don't check it - > - TV out for instance */ > - if (!connector->polled) > + /* Ignore HDP capable connectors and connectors where we don't > + * want any hotplug detection at all for polling. */ > + if (!connector->polled || connector->polled == DRM_CONNECTOR_POLL_HPD) Here too. Also in the subject. - ajax