From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59A3CC001DD for ; Tue, 11 Jul 2023 03:43:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F21910E2FA; Tue, 11 Jul 2023 03:43:44 +0000 (UTC) Received: from mail.208.org (unknown [183.242.55.162]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1168210E2F8 for ; Tue, 11 Jul 2023 03:43:41 +0000 (UTC) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4R0RYR1JdmzBJFS0 for ; Tue, 11 Jul 2023 11:43:39 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1689047019; x=1691639020; bh=PROXNSRNkmtHn8K/s7RFD4PL/CT OhC4irdWGixGUyVM=; b=1C/rS180+1xqNa9qU67FhPsrfoKHF13ZcVl5yEw35Ir h+0Z/gF7udnawEOTpzRJSXtkP1M5keVlBF3ZDZJRGQxN24LGwJbjbFvUPR4EIP9P Pzo6l8hhlccC9Y4u6UeSIyMHV+JqeTneiCNFF0TMvdKalvfJcGRk/yGqjEfEuzka yxLBW6fxI90ASVftLXIInXg2rcNVORdupRfD1y/6YOZ8eQWej0oM6sHVjmFg7E4h 1xsonX6nLDXcKQhkbjfEwK3IXA6fExZENeKuf1Bq+CX3Vh9yp6U642voj6ZamPoC W3lcrc14mH74Q22+ETow9bHY7UotrnieR39So6TPQMA== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qCIaqiuVKfPO for ; Tue, 11 Jul 2023 11:43:39 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4R0RYQ6Q7mzBJ8kq; Tue, 11 Jul 2023 11:43:38 +0800 (CST) MIME-Version: 1.0 Date: Tue, 11 Jul 2023 11:43:38 +0800 From: sunran001@208suo.com To: airlied@gmail.com, daniel@ffwll.ch Subject: [PATCH] drm/nouveau/flcn/qmgr: Move assignment outside if condition In-Reply-To: <20230711034221.79302-1-xujianghui@cdjrlc.com> References: <20230711034221.79302-1-xujianghui@cdjrlc.com> User-Agent: Roundcube Webmail Message-ID: <4a21bb7bb79108ae96518a8d1372ef1d@208suo.com> X-Sender: sunran001@208suo.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c b/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c index a453de341a75..48abdb124326 100644 --- a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c +++ b/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c @@ -73,7 +73,8 @@ nvkm_falcon_qmgr_new(struct nvkm_falcon *falcon, struct nvkm_falcon_qmgr *qmgr; int i; - if (!(qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL))) + qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL); + if (!qmgr) return -ENOMEM; qmgr->falcon = falcon;