From: "Grodzovsky, Andrey" <Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Cc: "Deucher,
Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"Koenig,
Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.
Date: Fri, 2 Nov 2018 15:59:16 +0000 [thread overview]
Message-ID: <4a71addd-3bd9-4caf-72d0-fe4de4475fef@amd.com> (raw)
In-Reply-To: <08e1a7c5-7e2e-9706-404d-4c1217b95e07-otUistvHUpPR7s880joybQ@public.gmane.org>
On 11/02/2018 10:24 AM, Michel Dänzer wrote:
> On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote:
>> Illegal access will cause CP hang followed by job timeout and
>> recovery kicking in.
>> Also, disable the suite for all APU ASICs until GPU
>> reset issues for them will be resolved and GPU reset recovery
>> will be enabled by default.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>>
>> [...]
>>
>> @@ -94,7 +119,9 @@ CU_BOOL suite_deadlock_tests_enable(void)
>> &minor_version, &device_handle))
>> return CU_FALSE;
>>
>> - if (device_handle->info.family_id == AMDGPU_FAMILY_SI) {
>> + if (device_handle->info.family_id == AMDGPU_FAMILY_SI ||
>> + device_handle->info.family_id == AMDGPU_FAMILY_CZ ||
>> + device_handle->info.family_id == AMDGPU_FAMILY_RV) {
>> printf("\n\nCurrently hangs the CP on this ASIC, deadlock suite disabled\n");
>> enable = CU_FALSE;
>> }
> Indentation is wrong here and in other places. The libdrm tree contains
> configuration files for EditorConfig (https://editorconfig.org/); since
> you're using Eclipse, https://github.com/ncjones/editorconfig-eclipse
> should help.
I installed the eclipse plugin.
>
>
> I run amdgpu_test as part of my daily build/test script during lunch
> break; when I came back today, I was greeted by a GFX hang of the
> Bonaire in my development box due to this test. Please disable it for
> all pre-GFX8 ASICs. Ideally, it should also check at runtime that GPU
> recovery is actually enabled, as that still isn't the case by default
> except with bleeding edge amdgpu kernel code.
Thanks for testing - I will send a fix.
Andrey
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-11-02 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 18:33 [PATCH libdrm] amdgpu/test: Add illegal register and memory access test Andrey Grodzovsky
2018-10-31 19:49 ` Alex Deucher
[not found] ` <CADnq5_O-PgE57kRmF1TrnS1LPZi4_7-_TeALM5VnuxTFuLUpdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-31 20:04 ` Grodzovsky, Andrey
2018-10-31 20:05 ` Grodzovsky, Andrey
[not found] ` <05e62106-331f-adf8-4cc3-18da6a7e0a78-5C7GfCeVMHo@public.gmane.org>
2018-11-01 1:44 ` Alex Deucher
[not found] ` <CADnq5_NnyeG3w+-a67Vw3Ow0J6=5C7qypSaxg7fx6YcvhAgctA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-02 7:35 ` Christian König
[not found] ` <1541010808-1293-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2018-11-02 14:24 ` Michel Dänzer
[not found] ` <08e1a7c5-7e2e-9706-404d-4c1217b95e07-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-11-02 15:59 ` Grodzovsky, Andrey [this message]
[not found] ` <4a71addd-3bd9-4caf-72d0-fe4de4475fef-5C7GfCeVMHo@public.gmane.org>
2018-11-02 18:12 ` Alex Deucher
[not found] ` <CADnq5_M_t5Rg3_MRvLiJQkNMrM_ZLXz2jgb2VxR2OmRGB4750g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-02 18:14 ` Grodzovsky, Andrey
[not found] ` <40e6d884-f03b-58f3-88b0-d22560812f50-5C7GfCeVMHo@public.gmane.org>
2018-11-02 19:17 ` Grodzovsky, Andrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a71addd-3bd9-4caf-72d0-fe4de4475fef@amd.com \
--to=andrey.grodzovsky-5c7gfcevmho@public.gmane.org \
--cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
--cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox