From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41147C87FCB for ; Tue, 12 Aug 2025 17:04:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADAAD10E0E9; Tue, 12 Aug 2025 17:04:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="hPQ4TyI0"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAF7810E0E9 for ; Tue, 12 Aug 2025 17:04:48 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C13A5A577E8; Tue, 12 Aug 2025 17:04:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1776C4CEF0; Tue, 12 Aug 2025 17:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755018287; bh=TaXN39wQlu2XcAIkf4Jqd33tt8qogJy/MlkjdkiPELc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=hPQ4TyI0Z5a7uLYzDvDXSO6sLlBnVjmOEHv2o0dHeNEUeHVLf/wJTVUOMDI7vewW0 kNcEzmQOjl4TaquG8R9X0ASHRHy05fCYbharglP4edcJqYVGksDNnPC6my3CPI++bV rqKcKv/8VFsZFFRWy4RdJFp0bPdoAOffoJPC+OnqA4kaAXjkSZslr5WQjzBOONx4+s k9B3mrhS5ncPCGdBJa1//fJOmRcdqc7QH9gFoymi7rSWgG3i6QstsAeAFA6jgGsL6c 1KjebXOmV6cQ7GzWMImOFl5xRK7NouOC1nLSHfCWV1hq9xWnqTNw2VsPUcRVTGtaX/ 8obF2y/921s0Q== Message-ID: <4abed396-5225-4b5c-a538-ced4f4619239@kernel.org> Date: Tue, 12 Aug 2025 19:04:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] drm/nouveau: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct() From: Danilo Krummrich To: Imre Deak Cc: dri-devel@lists.freedesktop.org, =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Lyude Paul , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard References: <20250728101603.243788-1-imre.deak@intel.com> <20250728101603.243788-3-imre.deak@intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 8/1/25 11:08 AM, Danilo Krummrich wrote: > On 7/28/25 12:16 PM, Imre Deak wrote: >> Plumb the format info from .fb_create() all the way to >> drm_helper_mode_fill_fb_struct() to avoid the redundant >> lookup. >> >> The patch is based on the driver parts of the patchset at Link: >> below, which missed converting the nouveau driver. >> >> Cc: Ville Syrjälä >> Cc: Lyude Paul >> Cc: Danilo Krummrich >> Cc: Thomas Zimmermann >> Cc: Maarten Lankhorst >> Cc: Maxime Ripard >> Fixes: 41ab92d35ccd ("drm: Make passing of format info to >> drm_helper_mode_fill_fb_struct() mandatory") >> Link: https://lore.kernel.org/all/20250701090722.13645-1- >> ville.syrjala@linux.intel.com >> Signed-off-by: Imre Deak > > Acked-by: Danilo Krummrich Any concerns if I just pick this one? It's a bit annoying to not have this fixed in drm-misc-fixes and -next. I'd hope for -rc2 getting backmerged.