From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>, <rodrigo.vivi@intel.com>,
<alexander.usyskin@intel.com>, <gregkh@linuxfoundation.org>,
<jgg@nvidia.com>
Subject: Re: [PATCH v2 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware
Date: Thu, 12 Jun 2025 20:41:22 +0530 [thread overview]
Message-ID: <4b7e9d3c-90a4-40fa-abda-b90d7107a2d0@intel.com> (raw)
In-Reply-To: <d4497be8-3536-47a4-99b9-58b5f1468172@intel.com>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On 12-06-2025 16:05, Nilawar, Badal wrote:
>>> +static int late_bind_fw_init(struct xe_late_bind *late_bind, u32 type)
>>> +{
>>> + struct xe_device *xe = late_bind_to_xe(late_bind);
>>> + struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
>>> + struct xe_late_bind_fw *lb_fw;
>>> + const struct firmware *fw;
>>> + u32 num_fans;
>>> + int ret;
>>> +
>>> + if (!late_bind->component_added)
>>> + return 0;
>>> +
>>> + lb_fw = &late_bind->late_bind_fw;
>>> +
>>> + lb_fw->type = type;
>>
>> Should we validate that "type" is sane?
> You mean if type is not max supported type. Sure, I will add.
IMO we don't need to validate type, CSC will return -4 i.e. invalid
parameter error.
[-- Attachment #2: Type: text/html, Size: 1728 bytes --]
next prev parent reply other threads:[~2025-06-12 15:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 17:56 [PATCH v2 00/10] Introducing firmware late binding Badal Nilawar
2025-06-06 17:56 ` [PATCH v2 01/10] mei: bus: add mei_cldev_mtu interface Badal Nilawar
2025-06-15 18:19 ` Umesh Nerlige Ramappa
2025-06-06 17:56 ` [PATCH v2 02/10] mei: late_bind: add late binding component driver Badal Nilawar
2025-06-14 8:02 ` Gupta, Anshuman
2025-06-16 15:13 ` Nilawar, Badal
2025-06-06 17:57 ` [PATCH v2 03/10] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw Badal Nilawar
2025-06-10 21:47 ` Daniele Ceraolo Spurio
2025-06-14 9:57 ` Gupta, Anshuman
2025-06-06 17:57 ` [PATCH v2 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware Badal Nilawar
2025-06-11 0:06 ` Daniele Ceraolo Spurio
2025-06-12 10:35 ` Nilawar, Badal
2025-06-12 15:11 ` Nilawar, Badal [this message]
2025-06-06 17:57 ` [PATCH v2 05/10] drm/xe/xe_late_bind_fw: Load " Badal Nilawar
2025-06-11 0:17 ` Daniele Ceraolo Spurio
2025-06-12 11:54 ` Usyskin, Alexander
2025-06-12 13:26 ` Nilawar, Badal
2025-06-12 13:31 ` Nilawar, Badal
2025-06-15 18:26 ` Umesh Nerlige Ramappa
2025-06-17 9:00 ` Nilawar, Badal
2025-06-06 17:57 ` [PATCH v2 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume Badal Nilawar
2025-06-06 17:57 ` [PATCH v2 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw in S2Idle/S3 resume Badal Nilawar
2025-06-06 17:57 ` [PATCH v2 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding Badal Nilawar
2025-06-12 21:28 ` Daniele Ceraolo Spurio
2025-06-06 17:57 ` [PATCH v2 09/10] {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl Badal Nilawar
2025-06-16 14:42 ` Rodrigo Vivi
2025-06-06 17:57 ` [PATCH v2 10/10] [CI]drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI Do not review Badal Nilawar
2025-06-07 8:02 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b7e9d3c-90a4-40fa-abda-b90d7107a2d0@intel.com \
--to=badal.nilawar@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).